[Not a bug] class.html2text.php

[mprough]

Zen 1.5.4

    public $callback_search = array(
        '/<(a) [^>]*href=("|\')([^"\']+)\2([^>]*)>(.*?)<\/a>/i', // <a href="">
        '/<(h)[123456]( [^>]*)?>(.*?)<\/h[123456]>/i',         // h1 - h6
        '/<(b)( [^>]*)?>(.*?)<\/b>/i',                         // <b>
        '/<(strong)( [^>]*)?>(.*?)<\/strong>/i',               // <strong>
        '/<(th)( [^>]*)?>(.*?)<\/th>/i',                       // <th> and </th>
    );

shouldn't it be

    public $callback_search = array(
        '/<(a) [^>]*href=("|\')([^"\']+)\2([^>]*)>(.*?)<\/a>/i', // <a href="">
        '/<(h)[123456]( [^>]*)(.*?)<\/h[123456]>/i',         // h1 - h6
        '/<(b)( [^>]*)(.*?)<\/b>/i',                         // <b>
        '/<(strong)( [^>]*)(.*?)<\/strong>/i',               // <strong>
        '/<(th)( [^>]*)(.*?)<\/th>/i',                       // <th> and </th>
    );

Bunch of validation issues as well with regard to the script tags and their location. I suspect that the script tag location problem for jquery is because the head/html are not correctly closed

But the tags all have no type in any case.

~Melanie

[DrByte]

That comes directly from PHPMailer. https://github.com/PHPMailer/PHPMailer/releases

ZC v1.5.4 includes the files from PHPMailer v5.2.6.
Haven't done regression testing for PHPMailer v5.2.9 onto Zen Cart v1.5.4 to ensure there aren't any issues with it.

In the meantime you might want to try that version to see if it sorts out your validation issues.

[mprough]

That comes directly from PHPMailer. https://github.com/PHPMailer/PHPMailer/releases

ZC v1.5.4 includes the files from PHPMailer v5.2.6.
Haven't done regression testing for PHPMailer v5.2.9 onto Zen Cart v1.5.4 to ensure there aren't any issues with it.

In the meantime you might want to try that version to see if it sorts out your validation issues.

The syntax is broken in all of the versions including 5.2.8 & 5.2.9

/**
* List of preg* regular expression patterns to search for
* and replace using callback function.
*
* @type array
*/
protected $callback_search = array(
'/<(a) [^>]*href=("|\')([^"\']+)\2([^>]*)>(.*?)<\/a>/i', // <a href="">
'/<(h)[123456]( [^>]*)?>(.*?)<\/h[123456]>/i', // h1 - h6
'/<(b)( [^>]*)?>(.*?)<\/b>/i', // <b>
'/<(strong)( [^>]*)?>(.*?)<\/strong>/i', // <strong>
'/<(th)( [^>]*)?>(.*?)<\/th>/i', // <th> and </th>
);

[mprough]

Should be

    protected $callback_search = array(
        '/<(a) [^>]*href=("|\')([^"\']+)\2([^>]*)>(.*?)<\/a>/i', // <a href="">
        '/<(h)[123456]( [^>]*)>(.*?)<\/h[123456]>/i',           // h1 - h6
        '/<(b)( [^>]*)>(.*?)<\/b>/i',                           // <b>
        '/<(strong)( [^>]*)>(.*?)<\/strong>/i',                 // <strong>
        '/<(th)( [^>]*)>(.*?)<\/th>/i',                         // <th> and </th>
    );

I think

[DrByte]

The ? symbol means "previous character may occur 0 or more times" ... which seems reasonable as it allows for attributes to be included in those tags. I would think removing it is likely to cause misinterpretation, wouldn't it?

By the way, what jQuery issues are you talking about? This class is used for email translation. How are you connecting jQuery to email contents?

[mprough]

Well, this came up as i was looking for errors.... the syntax is broken, which in turn breaks everything in the file from line 173 down.

By the way, what jQuery issues are you talking about? This class is used for email translation. How are you connecting jQuery to email contents?

Because you said

That comes directly from PHPMailer. https://github.com/PHPMailer/PHPMailer/releases

ZC v1.5.4 includes the files from PHPMailer v5.2.6.
Haven't done regression testing for PHPMailer v5.2.9 onto Zen Cart v1.5.4 to ensure there aren't any issues with it.

In the meantime you might want to try that version to see if it sorts out your validation issues.

Validation Output: 10 Errors

Vanilla 1.5.4 (http://validator.w3.org/check?uri=ht...org%2Fservices)

[DrByte]

Notwithstanding your W3C validation comment (entirely separate issue IMO), I still don't understand the connection between jQuery and class.html2text.php

[mprough]

I was simply posting both errors, that and the validation issues. You suggested

In the meantime you might want to try that version to see if it sorts out your validation issues.

[DrByte]

Ok, thanks for clarifying that we were talking about 2 different things.

Now, how did you come upon discovering an issue with class.html2txt.php ? Were you triggering a specific kind of email that converted HTML to text incorrectly?
I'm trying to understand a use-case so the problem can be fixed properly, even if that means posting a bug report to the phpmailer project.

[mprough]

No I was scanning the files over for errors and it popped up