Admin categories search -Creating default object from empty value (see in debug logs)

[torvista]

I use the search extensively, could a few strategically placed "@" suppress the creation of these logs?

[DrByte]

Before you bother with suppressing things, where *else* in the admin are you able to trigger the same kind of message?

[torvista]

I haven't seen it occur anywhere else.

[DrByte]

To get rid of that warning entry in the log file, you can remove those lines causing it, as they're not used. It appears they're leftover from when that file was split into multiples for (slightly) easier maintenance:

These at 1005-1007 in /admin/categories.php can be removed:

  if (empty($pInfo->products_id)) {
    $pInfo->products_id= $pID;
  }

[torvista]

Additional information is that prior to commenting-out those lines, I found a note in my categories file at another point

if (empty($pInfo->products_id)) {
    //$pInfo = new stdClass();//steve added to 1.53 for php 5.4 and E_STRICT warnings, removed for 1.54, maybe fixed?
    $pInfo->products_id= $pID;
  } 

If I re-enable that commented-out declaration, the error log does not occur.

Which "solution" is recommended, or it really doesn't matter?

[DrByte]

Your suggestion works; however, I don't see where that object is used after that point in the code, hence the suggestion to simply remove it.

[DrByte]

Additional information is that prior to commenting-out those lines, I found a note in my categories file at another point

if (empty($pInfo->products_id)) {
    //$pInfo = new stdClass();//steve added to 1.53 for php 5.4 and E_STRICT warnings, removed for 1.54, maybe fixed?
    $pInfo->products_id= $pID;
  } 

Indeed, you had posted about that very thing in another thread, but it got lost due to hijacked discussions that got added to it. Apologies that it got missed in 1.5.4.