Illegal string offset 'id' in order.php

[marcopolo]

The edits are minimum and more below that line, can I send you the file to look at?

[swguy]

I believe this is still an issue. Seeing in an unmodified 1.5.4 includes/classes/order.php on line 462 with PHP 5.6.2. I can try with other PHPs if needed.

[marcopolo]

I was able to resolve the issue by changing:

if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

to

 if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && isset($_SESSION['shipping']['id']) && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

[mc12345678]

I was able to resolve the issue by changing:

if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

to

 if (STORE_PRODUCT_TAX_BASIS == 'Shipping' && isset($_SESSION['shipping']['id']) && stristr($_SESSION['shipping']['id'], 'storepickup') == TRUE) 

Perhaps I need to do more research, but it seems to me that this simply fixes the result of a previous problem not the problem that is causing this fix to be needed... I say this partially because I once had to apply a similar fix for a shipping module, but found out it was the shipping module that was not "generated" properly that made this issue appear...

Earlier in this thread it was asked if all modules were needed... If anything I would think those that have an effect on shipping propably would be prudent. :)

[swguy]

This fixes the symptom but not the cause. I will review the shipping modules in use on this site and post back with my findings.

[swguy]

I seem to get this error on one particular cart when I change the shipping address from the checkout shipping page (and when I return to the checkout shipping page after having changed the address).

[lat9]

Hmm, changing the address should/would require that the shipping calculations be redone within the checkout_shipping page's header ...