Mod List Support Thread

**dbltoe** · 12 Jul 2020, 06:40 PM

1.5.7 - PHP 7.3.19 with Quick Updates, Clone, OPC, news box, Sales Report.

Getting huge files with repetition of

Code:

[12-Jul-2020 17:34:51 UTC] Request URI: /******/index.php?cmd=mod_list, IP address: *************
#1 in_array() called at [/zc_plugins/ModList/1.4.0/admin/mod_list.php:75]
#2 require(/zc_plugins/ModList/1.4.0/admin/mod_list.php) called at [/******/index.php:23]
--> PHP Warning: in_array() expects parameter 2 to be array, null given in /zc_plugins/ModList/1.4.0/admin/mod_list.php on line 75.

**swguy** · 16 Jul 2020, 12:40 PM

Thanks for this report, @dbltoe. A number of changes were required for correct interoperation with Plugin Manager, and some issues were found in Plugin Manager itself that will be addressed soon.

1.5.7 users who installed Mod List version 1.4.0 ONLY:

Please run these commands in your Tools > Install SQL Patches screen:

DELETE FROM plugin_control WHERE unique_key = 'ModList';

DELETE FROM plugin_control_versions WHERE unique_key = 'ModList';

Then grab Mod List 1.4.1 from the Plugins Library and install it.

**carlwhat** · 6 Aug 2020, 06:22 PM

i am playing with 1.4.1 using the plugin manager on a base 1.5.7 system. i have a few comments. considering, we are in a 1.5.7 system, i would prefer the following change:

PHP Code:


<?php

//from:

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<html <?php echo HTML_PARAMS; ?>>

<head>

<meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>">

<title><?php echo TITLE; ?></title>

<link rel="stylesheet" type="text/css" href="includes/stylesheet.css">

<link rel="stylesheet" type="text/css" href="includes/cssjsmenuhover.css" media="all" id="hoverJS">

<script language="javascript" src="includes/menu.js"></script>

<script language="javascript" src="includes/general.js"></script>

<script type="text/javascript">

  <!--

  function init()

  {

    cssjsmenu('navbar');

    if (document.getElementById)

    {

      var kill = document.getElementById('hoverJS');

      kill.disabled = true;

    }

  }

  // -->

</script>

</head>

<body onLoad="init()">

<!-- header //-->

<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<!-- header_eof //-->

<?php



//to:

?>

<!doctype html>

<html <?= HTML_PARAMS; ?>>

<head>

    <?php require DIR_WS_INCLUDES . 'admin_html_head.php'; ?>

    <script src="includes/general.js"></script>

</head>

<body>

<!-- header //-->

<?php require(DIR_WS_INCLUDES . 'header.php'); ?>

<!-- header_eof //-->

in addition, i am not sure i understand this plugin. why does it have all of the base 1.5.7 things listed here? see:

Click image for larger version.

Name: Screenshot from 2020-08-06 10-16-32.jpg
Views: 98
Size: 52.0 KB
ID: 19127

are those items supposed to be there? those do not seem new to me....

the payment modules seem correct, but why are the shipping modules and the order total modules listed? see:

Click image for larger version.

Name: Screenshot from 2020-08-06 10-19-21.png
Views: 101
Size: 19.9 KB
ID: 19128

what might i be doing wrong? or reading incorrectly?

**dbltoe** · 6 Aug 2020, 07:23 PM

Not only are we getting everything in every menu, we are getting

Code:

[06-Aug-2020 18:11:43 UTC] Request URI: /jetmar/index.php?cmd=mod_list, IP address: 216.177.186.199
#1 require(/zc_plugins/ModList/1.4.1/admin/mod_list.php) called at [/jetmar/index.php:23]
--> PHP Warning: Use of undefined constant BUILT_IN_BOXES - assumed 'BUILT_IN_BOXES' (this will throw an Error in a future version of PHP) in /zc_plugins/ModList/1.4.1/admin/mod_list.php on line 75.

for every listing.

This winds up making a HUGE log file.

Looks like the system is not really picking up the admin/includes/extra_configures/modlist.php even though the define is there.

Lines 71 - 79 of admin/mod_list.php

Code:

<?php    } else { 
       while (!$pages->EOF) {
          $key = $pages->fields['language_key']; 
          if (in_array($key, BUILT_IN_BOXES)) { 
             $pages->MoveNext();
             continue;
          }
   ?>

**carlwhat** · 6 Aug 2020, 07:52 PM

yeah, i did not notice the log files, that makes sense now. i thought updates to the plugin manager had addressed this problem.

guess not.

who approved this plugin?!?

**dbltoe** · 6 Aug 2020, 08:05 PM

Originally Posted by carlwhat

who approved this plugin?!?

Inquiring minds want to know!

**carlwhat** · 6 Aug 2020, 07:58 PM

Originally Posted by dbltoe

Looks like the system is not really picking up the admin/includes/extra_configures/modlist.php even though the define is there.

if you rename extra_configures to extra_datafiles, i think that will help.

not sure if that is 'approved'; but it resolves the issue and makes this mod work. and keeps everything within the plugins directory.

best.

**swguy** · 6 Aug 2020, 08:05 PM

Are you guys using the latest Mod List on 1.5.7? That version shouldn't have any of these issues.

**carlwhat** · 6 Aug 2020, 08:12 PM

Originally Posted by swguy

Are you guys using the latest Mod List on 1.5.7? That version shouldn't have any of these issues.

current version does not work. my fix does.

best.

**dbltoe** · 6 Aug 2020, 08:08 PM

Originally Posted by carlwhat

if you rename extra_configures to extra_datafiles, i think that will help.

not sure if that is 'approved'; but it resolves the issue and makes this mod work. and keeps everything within the plugins directory.

best.

Works a treat AND it gives just the right info versus listing EVERYTHING.

Thread: Mod List Support Thread

Thread Tools

Search Thread

Display

Hybrid View

Re: Mod List Support Thread

Re: Mod List Support Thread

Re: Mod List Support Thread

Re: Mod List Support Thread

Re: Mod List Support Thread

Re: Mod List Support Thread

Re: Mod List Support Thread

Re: Mod List Support Thread

Re: Mod List Support Thread

Re: Mod List Support Thread

Similar Threads

Local Sales Tax Mod - Support Thread

Printable Price list :: support thread

Multi Cross Sell mod [Support thread]

Just another Cross-Sell mod (support thread)

SplitTaxLines mod support thread

Posting Permissions