BETA feedback for Responsive-Classic in v155-beta

**dbltoe** · 3 Feb 2016, 07:44 AM

Ran into a problem with additional images being larger than the productMainImage when viewed on an iPhone6 in portrait. I noticed that the portrait portion of the responsive_mobile.css has

PHP Code:


.additionalImages img{width:90%;margin:0 auto;}
.additionalImages{float:left !important;}

on line 382 while the landscape did not.
Commenting out those two lines fixed the problem.
It would be nice to have them side by side but, that's a horse of a different waterhole.

**mesnitu** · 3 Feb 2016, 02:36 PM

Hi
Why not add scss instead of css ?

**rbarbour** · 5 Feb 2016, 02:01 AM

I don't see any benefit to scss as far as the responsive code itself goes, Anne may choose to answer as far as the template styling, I really think her answer is going to fall somewhere in the lines of "design restrictions" and "template override minimums" to keep this as close to the "stock" classic template as possible.

Originally Posted by mesnitu

Hi
Why not add scss instead of css ?

**mesnitu** · 5 Feb 2016, 11:33 AM

hi
I haven't seen the template, nor tested 1.55. So it's not criticism, more of a suggestion, because I honestly dont' see myself writing pure css anymore, or making a site without a grid system(susy, singulaitygs or whatever) and media query's.
I've made for myself, didn't shared because it's not finish, and I made some changes to use semantics, that later i realize that there's was a module that did that.
The template based on the classic (not the default).
And basically it's "inspired" on some drupal subthemes and drush, in a very ingenious way.
But basically I made a bash script, where I named the new template and type some other info to the template info. Then he copies, creates all the basic and needed stuff from classic to a new template.
In the process, I actually overrided (or renamed the breadcrumd class), because I wanted to have semantics on it. That's the only core file, that actually changed, but the original it's there
The bash script creates the node_modules folder and bower, and sass folder and sub-folders, plus a gulp, json, but it only install the npm modules, if I type install at the end of the bash script.

In the admin, yes, there's a template config fields in the configuration section, where I can paste what script files I want to send to the footer.

And some options, like if I want to use the main table, or just use div ( I just use divs) , a option to disable Column / Boxes width ( I want to contrel them with media querys), and a option to add to <body> all the category classes , products, and manufactures ( as I recall ) , so I can work with classes and not new css files with that name. Example:

<body id="productbookxinfoBody" class="pID-1 p-product_bookx_info l-pt l-pt-product_bookx_info c_1 l-pt_c_1 l-pt_pID_1">

The only thing left , was to change all css colors to a sass way, using variables, etc... that I actually didn't fininsh.

This works for me, possibly not fo others.
The responsive way. Well, i actually use the media querys and grid layouts when I need them, not so much different responsive style files, but I think there's also a npm module that aggregates media querys to different files. Not to mention the use of gulp tasks or grunt, in images, sprites...etc.

But again, this are just ideas, not critics. I know all that work that's involved and for free, and I very much appreciated the spirit.

Best regards

**Design75** · 5 Feb 2016, 12:13 PM

Originally Posted by mesnitu

Hi
Why not add scss instead of css ?

Although you and I may be familiar with scss and how to compile it to CSS. For the big majority of users it would over complicate things.
When I use scss I tend to leave the on the dev site, and only copy the CSS files to the live environment.

**mesnitu** · 5 Feb 2016, 01:05 PM

Originally Posted by Design75

Although you and I may be familiar with scss and how to compile it to CSS. For the big majority of users it would over complicate things.
When I use scss I tend to leave the on the dev site, and only copy the CSS files to the live environment.

I can see that, but let's be honest, in a zencart plataform and others, two things can happen: you hired someone and buy a template, or in a week you'll have a crash course in php and css, and if you fail, you'll hired someone and buy a template.
And, despite the sass structure is present, a user doesn't have to use it. That happen to me the first time I saw sass in a template. Didn't had time to learn all that, so I just work with css.
Anyway, it's fine for me.

Best Regards

**picaflor-azul** · 5 Feb 2016, 03:54 PM

Originally Posted by dbltoe

Ran into a problem with additional images being larger than the productMainImage when viewed on an iPhone6 in portrait. I noticed that the portrait portion of the responsive_mobile.css has

PHP Code:


.additionalImages img{width:90%;margin:0 auto;}

.additionalImages{float:left !important;}

on line 382 while the landscape did not.
Commenting out those two lines fixed the problem.
It would be nice to have them side by side but, that's a horse of a different waterhole.

Do you have a link to a page with this? With the demo products this code is working for portrait phones with the additional images the correct size and floating left in a row. Can you also let me know your image size settings and how many additional images you have set per row?

Thanks,

Anne

Thread: BETA feedback for Responsive-Classic in v155-beta

Thread Tools

Search Thread

Display

Hybrid View

Re: Responsive Classic (built in to Zen Cart v1.5.5) [Support Thread]

Re: Responsive Classic (built in to Zen Cart v1.5.5) [Support Thread]

Re: Responsive Classic (built in to Zen Cart v1.5.5) [Support Thread]

Re: Responsive Classic (built in to Zen Cart v1.5.5) [Support Thread]

Re: Responsive Classic (built in to Zen Cart v1.5.5) [Support Thread]

Re: Responsive Classic (built in to Zen Cart v1.5.5) [Support Thread]

Re: Responsive Classic (built in to Zen Cart v1.5.5) [Support Thread]

Similar Threads

Stock by Attributes 5.0 Beta (for v1.5.0)

v154 ZCA Responsive CSS Template Framework (BETA)

v155 [Closed] FEEDBACK ON BETA of v1.5.5

Community feedback invited for v155-beta [now closed]

Posting Permissions