var-type undefined: stringIgnoreNull(Daniel) - Account Edit

[swguy]

Note that the full name of this file is:

./includes/classes/db/mysql/query_factory.php

(for people searching for "query_factory.php")

[lat9]

It would be "really nice" if that function could be updated to log the issue rather than simply displaying it, i.e. changing the 1.5.5a version from:

  function getBindVarValue($value, $type) {
    $typeArray = explode(':',$type);
    $type = $typeArray[0];
    switch ($type) {
      case 'csv':
        return $value;
      break;
      case 'passthru':
        return $value;
      break;
      case 'float':
        return (!zen_not_null($value) || $value=='' || $value == 0) ? 0 : $value;
      break;
      case 'integer':
        return (int)$value;
      break;
      case 'string':
        if (preg_match('/NULL/', $value)) return 'null';
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'stringIgnoreNull':
        return '\'' . $this->prepare_input($value) . '\'';
        break;
      case 'noquotestring':
        return $this->prepare_input($value);
      break;
      case 'currency':
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'date':
        if (preg_match('/null/i', $value)) return 'null';
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'enum':
        if (isset($typeArray[1])) {
          $enumArray = explode('|', $typeArray[1]);
        }
        return '\'' . $this->prepare_input($value) . '\'';
      case 'regexp':
        $searchArray = array('[', ']', '(', ')', '{', '}', '|', '*', '?', '.', '$', '^');
        foreach ($searchArray as $searchTerm) {
          $value = str_replace($searchTerm, '\\' . $searchTerm, $value);
        }
        return $this->prepare_input($value);
      default:
      die('var-type undefined: ' . $type . '('.$value.')');
    }
  }

to

  function getBindVarValue($value, $type) {
    $typeArray = explode(':',$type);
    $type = $typeArray[0];
    switch ($type) {
      case 'csv':
        return $value;
      break;
      case 'passthru':
        return $value;
      break;
      case 'float':
        return (!zen_not_null($value) || $value=='' || $value == 0) ? 0 : $value;
      break;
      case 'integer':
        return (int)$value;
      break;
      case 'string':
        if (preg_match('/NULL/', $value)) return 'null';
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'stringIgnoreNull':
        return '\'' . $this->prepare_input($value) . '\'';
        break;
      case 'noquotestring':
        return $this->prepare_input($value);
      break;
      case 'currency':
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'date':
        if (preg_match('/null/i', $value)) return 'null';
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'enum':
        if (isset($typeArray[1])) {
          $enumArray = explode('|', $typeArray[1]);
        }
        return '\'' . $this->prepare_input($value) . '\'';
      case 'regexp':
        $searchArray = array('[', ']', '(', ')', '{', '}', '|', '*', '?', '.', '$', '^');
        foreach ($searchArray as $searchTerm) {
          $value = str_replace($searchTerm, '\\' . $searchTerm, $value);
        }
        return $this->prepare_input($value);
      default:
      trigger_error ("var-type undefined: $type ($value).", E_USER_ERROR);
    }
  }

[mesnitu]

trigger_error - I like how things look so simple !

[DrByte]

It would be "really nice" if that function could be updated to log the issue rather than simply displaying it, i.e. changing the 1.5.5a version from:

  function getBindVarValue($value, $type) {
    $typeArray = explode(':',$type);
    $type = $typeArray[0];
    switch ($type) {
      case 'csv':
        return $value;
      break;
      case 'passthru':
        return $value;
      break;
      case 'float':
        return (!zen_not_null($value) || $value=='' || $value == 0) ? 0 : $value;
      break;
      case 'integer':
        return (int)$value;
      break;
      case 'string':
        if (preg_match('/NULL/', $value)) return 'null';
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'stringIgnoreNull':
        return '\'' . $this->prepare_input($value) . '\'';
        break;
      case 'noquotestring':
        return $this->prepare_input($value);
      break;
      case 'currency':
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'date':
        if (preg_match('/null/i', $value)) return 'null';
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'enum':
        if (isset($typeArray[1])) {
          $enumArray = explode('|', $typeArray[1]);
        }
        return '\'' . $this->prepare_input($value) . '\'';
      case 'regexp':
        $searchArray = array('[', ']', '(', ')', '{', '}', '|', '*', '?', '.', '$', '^');
        foreach ($searchArray as $searchTerm) {
          $value = str_replace($searchTerm, '\\' . $searchTerm, $value);
        }
        return $this->prepare_input($value);
      default:
      die('var-type undefined: ' . $type . '('.$value.')');
    }
  }

to

  function getBindVarValue($value, $type) {
    $typeArray = explode(':',$type);
    $type = $typeArray[0];
    switch ($type) {
      case 'csv':
        return $value;
      break;
      case 'passthru':
        return $value;
      break;
      case 'float':
        return (!zen_not_null($value) || $value=='' || $value == 0) ? 0 : $value;
      break;
      case 'integer':
        return (int)$value;
      break;
      case 'string':
        if (preg_match('/NULL/', $value)) return 'null';
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'stringIgnoreNull':
        return '\'' . $this->prepare_input($value) . '\'';
        break;
      case 'noquotestring':
        return $this->prepare_input($value);
      break;
      case 'currency':
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'date':
        if (preg_match('/null/i', $value)) return 'null';
        return '\'' . $this->prepare_input($value) . '\'';
      break;
      case 'enum':
        if (isset($typeArray[1])) {
          $enumArray = explode('|', $typeArray[1]);
        }
        return '\'' . $this->prepare_input($value) . '\'';
      case 'regexp':
        $searchArray = array('[', ']', '(', ')', '{', '}', '|', '*', '?', '.', '$', '^');
        foreach ($searchArray as $searchTerm) {
          $value = str_replace($searchTerm, '\\' . $searchTerm, $value);
        }
        return $this->prepare_input($value);
      default:
      trigger_error ("var-type undefined: $type ($value).", E_USER_ERROR);
    }
  }

lat9, are you encountering cases where that scenario actually occurs?

[lat9]

lat9, are you encountering cases where that scenario actually occurs?

I've only run into that scenario during a customization's development. I'll admit that it threw me off a bit and took additional time to debug, but no "production" cases where that issue arises.

[apogeerockets]

I had the same issue, upgrading from 1.5.4 to 1.5.5a. Reuploading (or uploading for the first time?) the query_factory file seems to have resolved it.

[swguy]

Note that ./includes/classes/db/mysql/query_factory.php changed from 1.5.5 to 1.5.5a, so if you upgraded but neglected to upgrade this file, or used the 1.5.5 copy, that would cause this problem.

[DTomlinson]

It's possibly uglier? I downloaded 1.5.5a from git-hub,

* @version GIT: $Id: Author: Ian Wilson Modified in v1.6.0 $

which has different definition for 'string' and no definition for 'stringIgnoreNull'

Is it now being taken out of the latest code?

Ouch!

[DrByte]

It's possibly uglier? I downloaded 1.5.5a from git-hub,

* @version GIT: $Id: Author: Ian Wilson Modified in v1.6.0 $

which has different definition for 'string' and no definition for 'stringIgnoreNull'

Is it now being taken out of the latest code?

Ouch!

Are you trying to say something's not working properly in your v155 site?

[swguy]

This should only happen in situations where there are customizations that have not been brought up to date. Prior to the Trustwave fixes, the array to be passed to $db->perform could be updated like this:

          $sql_data_array['tax_id'] = $tax_id;
          $sql_data_array['tax_exempt'] = $tax_exempt;

Now it needs to be updated like this:

          $sql_data_array[] = array('fieldName'=>'tax_id', 'value'=>$tax_id, 'type'=>'stringIgnoreNull');
          $sql_data_array[] = array('fieldName'=>'tax_exempt', 'value'=>$tax_exempt, 'type'=>'stringIgnoreNull');