[Done v155b] checkout_payment: Incorrect selector in form-submit jQuery

[lat9]

Within the file /includes/modules/pages/checkout_payment/jscript_main.php, there's this section:

    $(document).ready(function(){
      $('form[name="checkout_payment"]').submit(function() {
          $('.paymentSubmit').attr('disabled', true);
        <?php if ($flagOnSubmit) { ?>
          formPassed = check_form();
          if (formPassed == false) {
              $('.paymentSubmit').attr('disabled', false);
          }
          return formPassed;
        <?php } ?>
      });
    });

... but if you look at /includes/templates/template_default/templates/tpl_checkout_payment_default.php, you'll see:

<div class="buttonRow forward" id="paymentSubmit"><?php echo zen_image_submit(BUTTON_IMAGE_CONTINUE_CHECKOUT, BUTTON_CONTINUE_ALT, 'onclick="submitFunction('.zen_user_has_gv_account($_SESSION['customer_id']).','.$order->info['total'].')"'); ?></div>

Suggest changing the jQuery code to reference the "proper" selector:

   $(document).ready(function(){
      $('form[name="checkout_payment"]').submit(function() {
          $('#paymentSubmit').attr('disabled', true);
        <?php if ($flagOnSubmit) { ?>
          formPassed = check_form();
          if (formPassed == false) {
              $('#paymentSubmit').attr('disabled', false);
          }
          return formPassed;
        <?php } ?>
      });
    });

[DrByte]

Oh my. How did that get missed?

Can I ask ... how did you stumble upon this? ie: what were the symptoms you were investigating ... so we can use those as extra tests

[lat9]

I'm in the process of creating an alternate checkout modification for a client, merging the processing for the checkout_shipping, checkout_payment and checkout_confirmation pages and just happened to notice the discrepancy during the merge.

[DrByte]

https://github.com/zencart/zencart/pull/1098