One-Page Checkout [Support Thread]

[HeathenMagic]

Just noticed a strange thing, I was looking on the website checking listings for an order, and got an error 500 on every page. Or refresh. In private session or another browser I could access the site. But not in the affected browser session. Only other thing is I Was logged into admin at the same time. I could only see several logs like this:-

PHP Fatal error: Uncaught Error: Call to a member function guestCheckoutEnabled() on int in /includes/classes/observers/class.checkout_one_observer.php:216

I turned off one page checkout for now in case its that, though got a feeling it might be due to ip address logged into admin and somehow its blocking in same session on existing browser. I didn't see anyone else with same issue, I saw a code edit I applied to make this log disappear though. In case that helps.

[lat9]

Just noticed a strange thing, I was looking on the website checking listings for an order, and got an error 500 on every page. Or refresh. In private session or another browser I could access the site. But not in the affected browser session. Only other thing is I Was logged into admin at the same time. I could only see several logs like this:-



I turned off one page checkout for now in case its that, though got a feeling it might be due to ip address logged into admin and somehow its blocking in same session on existing browser. I didn't see anyone else with same issue, I saw a code edit I applied to make this log disappear though. In case that helps.

That method (guestCheckoutEnabled) in the OnePageCheckout.php class-file was introduced in OPC v2.5.0. It sounds like your version of that file and OPC's observer-class file have somehow gotten out-of-sync.

To what code-edit do you refer?

[HeathenMagic]

That method (guestCheckoutEnabled) in the OnePageCheckout.php class-file was introduced in OPC v2.5.0. It sounds like your version of that file and OPC's observer-class file have somehow gotten out-of-sync.

To what code-edit do you refer?

I found post #2838 and your fix after suggested, I amended that line as you recommended

[TamyA]

What is the Bottom instructions for?

[lat9]

What is the Bottom instructions for?

Any unique guidance that you want to give your customers prior to checking out.

[dbltoe]

It's a language define in includes/languages/english/lang.checkout_one.php. If you have no bottom instructions, you may want to blank that out. If you do, be careful to retain the single quotes.

[Dave224]

I'm working on the address change card in OPC when the customer edits the shipping or billing address during checkout. For larger screens the Save Changes button, Cancel button, and checkbox to add the address to the address book look fine. But on smaller screens, the buttons and checkbox run over the card width. In addition, looking at the code, the checkbox and its label should be on one row, while the two buttons should be on a separate row. I can't understand why block display style is not being followed. See attached screenshots. The relevant code snippet from includes/templates/bootstrap/templates/tpl_modules_opc_shipping_address.php is:

    if ($editShippingButtonLink === true) {
        $cancel_title = 'title="' . BUTTON_CANCEL_CHANGES_TITLE . '"';
        $save_title = 'title="' . BUTTON_SAVE_CHANGES_TITLE . '"';
        $show_add_address = $_SESSION['opc']->showAddAddressField();
        $parameters = ($show_add_address) ? '' : ' class="hiddenField"';
?>
        <div class="opc-buttons">
<?php
        if ($show_add_address === true) {
?>
            <div class="custom-control custom-checkbox">
                <?php echo zen_draw_checkbox_field("add_address['ship']", '1', false, 'id="opc-add-ship"' . $parameters); ?>
                <label class="checkboxLabel custom-control-label" for="opc-add-ship" title="<?php echo TITLE_ADD_TO_ADDRESS_BOOK; ?>"><?php echo TEXT_ADD_TO_ADDRESS_BOOK; ?></label>
            </div>
<?php
        }
?>
            <div class="d-flex justify-content-around mt-2">
                <div id="opc-ship-cancel"><?php echo zen_image_button(BUTTON_IMAGE_CANCEL, BUTTON_CANCEL_CHANGES_ALT, $cancel_title); ?></div>
                <div id="opc-ship-save"><?php echo zen_image_button(BUTTON_IMAGE_UPDATE, BUTTON_SAVE_CHANGES_ALT, $save_title); ?></div>
            </div>
        </div>
<?php
    }

The images are attached.

Thank you,

Dave
zc1.5.8a, bootstrap 3.7.7, opc 2.5.4

[lat9]

I'm working on the address change card in OPC when the customer edits the shipping or billing address during checkout. For larger screens the Save Changes button, Cancel button, and checkbox to add the address to the address book look fine. But on smaller screens, the buttons and checkbox run over the card width. In addition, looking at the code, the checkbox and its label should be on one row, while the two buttons should be on a separate row. I can't understand why block display style is not being followed. See attached screenshots. The relevant code snippet from includes/templates/bootstrap/templates/tpl_modules_opc_shipping_address.php is:

    if ($editShippingButtonLink === true) {
        $cancel_title = 'title="' . BUTTON_CANCEL_CHANGES_TITLE . '"';
        $save_title = 'title="' . BUTTON_SAVE_CHANGES_TITLE . '"';
        $show_add_address = $_SESSION['opc']->showAddAddressField();
        $parameters = ($show_add_address) ? '' : ' class="hiddenField"';
?>
        <div class="opc-buttons">
<?php
        if ($show_add_address === true) {
?>
            <div class="custom-control custom-checkbox">
                <?php echo zen_draw_checkbox_field("add_address['ship']", '1', false, 'id="opc-add-ship"' . $parameters); ?>
                <label class="checkboxLabel custom-control-label" for="opc-add-ship" title="<?php echo TITLE_ADD_TO_ADDRESS_BOOK; ?>"><?php echo TEXT_ADD_TO_ADDRESS_BOOK; ?></label>
            </div>
<?php
        }
?>
            <div class="d-flex justify-content-around mt-2">
                <div id="opc-ship-cancel"><?php echo zen_image_button(BUTTON_IMAGE_CANCEL, BUTTON_CANCEL_CHANGES_ALT, $cancel_title); ?></div>
                <div id="opc-ship-save"><?php echo zen_image_button(BUTTON_IMAGE_UPDATE, BUTTON_SAVE_CHANGES_ALT, $save_title); ?></div>
            </div>
        </div>
<?php
    }

The images are attached.

Thank you,

Dave
zc1.5.8a, bootstrap 3.7.7, opc 2.5.4

I'm not seeing that behavior. For wide screens, the "Cancel" and "Save Changes" buttons are on their own lines and I'm guessing that some CSS change that you've made is causing that change (which is also why the smaller screens' display has gone wonky).

[Dave224]

I'm not seeing that behavior. For wide screens, the "Cancel" and "Save Changes" buttons are on their own lines and I'm guessing that some CSS change that you've made is causing that change (which is also why the smaller screens' display has gone wonky).

I believe the offending CSS is line 25 in includes/templates/bootstrap/css/checkout_one.css:

.opc-buttons > div:first-child { float: left; }

which I have not edited. Float left apparently changes the block display. I got around the problem by adding a div before the checkbox div thus changing the first child div so the float left does not affect remaining div's. There are probably more elegant solutions.

        if ($show_add_address === true) {
?>
            <div class="p-2"></div>
            <div class="custom-control custom-checkbox">
                <?php echo zen_draw_checkbox_field("add_address['ship']", '1', false, 'id="opc-add-ship"' . $parameters); ?>
                <label class="checkboxLabel custom-control-label" for="opc-add-ship" title="<?php echo TITLE_ADD_TO_ADDRESS_BOOK; ?>"><?php echo TEXT_ADD_TO_ADDRESS_BOOK; ?></label>
            </div>
<?php
        }

Dave

[lat9]

I believe the offending CSS is line 25 in includes/templates/bootstrap/css/checkout_one.css:

.opc-buttons > div:first-child { float: left; }

which I have not edited. Float left apparently changes the block display. I got around the problem by adding a div before the checkbox div thus changing the first child div so the float left does not affect remaining div's. There are probably more elegant solutions.

        if ($show_add_address === true) {
?>
            <div class="p-2"></div>
            <div class="custom-control custom-checkbox">
                <?php echo zen_draw_checkbox_field("add_address['ship']", '1', false, 'id="opc-add-ship"' . $parameters); ?>
                <label class="checkboxLabel custom-control-label" for="opc-add-ship" title="<?php echo TITLE_ADD_TO_ADDRESS_BOOK; ?>"><?php echo TEXT_ADD_TO_ADDRESS_BOOK; ?></label>
            </div>
<?php
        }

Dave

You've missed the bit in the One-Page Checkout readme.html (Step B of the Initial Installation section):

If your store is not using the Bootstrap template (or a clone there-of), rename the YOUR_TEMPLATE sub-directories (5 of them)  to match your store's template name.  The Bootstrap template (v3.4.0  and later) already includes its template-specific integration, so the  files from this distribution are neither needed nor wanted!

The checkout_one.css file distributed with the Bootstrap template is only 23 lines long.