One-Page Checkout [Support Thread]

[lat9]

@simon1066, what happens if you change the line you identified to read

$opc_disable_address_change = !$editShippingButtonLink;

[simon1066]

You're a star! I had tried a couple of similar changes but not that one.

Thank you.

[lat9]

You're a star! I had tried a couple of similar changes but not that one.

Thank you.

I'll get that issue noted on GitHub. Its correction will be included in the 2.0.1 release of One-Page Checkout.

[shayne]

LOST IN V 2.0

Was working fine before the upgrade from 1.5 but now I have two problems .
First the Enable One-Page Checkout? true false setting on the configuration - doesnt work !

I get the correct "The One-Page Checkout plugin was successfully upgraded from [] to [2.0.0 (2018-04-27)]." message Enable One-Page Checkout?OPC does not kick in and there is no apparent difference between checkout sequence with either setting - I have reloaded it three times.
I tried dropping back to the previous version 1.5.0 which does work. Am I just being really stupid and missing something ??

Second editing the confirmation email (I want to miss out a few Divs) now seems to have no effect
Surely that hasnt gone to a new file ?

Not very urgent - 1.5 does all i require - but I am puzzled!

[lat9]

LOST IN V 2.0

Was working fine before the upgrade from 1.5 but now I have two problems .
First the Enable One-Page Checkout? true false setting on the configuration - doesnt work !

I get the correct "The One-Page Checkout plugin was successfully upgraded from [] to [2.0.0 (2018-04-27)]." message Enable One-Page Checkout?OPC does not kick in and there is no apparent difference between checkout sequence with either setting - I have reloaded it three times.
I tried dropping back to the previous version 1.5.0 which does work. Am I just being really stupid and missing something ??

Second editing the confirmation email (I want to miss out a few Divs) now seems to have no effect
Surely that hasnt gone to a new file ?

Not very urgent - 1.5 does all i require - but I am puzzled!

What, specifically, do you mean when you say that OPC does not "kick in"?
Have you verified that OPC is, in fact, enabled through its configuration?
Did you make any template-override customizations to OPC 1.5? Many of the templates changed significantly going from 1.5 to 2.0.

Your question regarding confirmation email is outside of the OPC's changes and would be best asked outside of this support thread.

[shayne]

First - yes indeed the Confirmation Email I would expect to be totally a different issue - but the problem did/does go along with the change from 1.5 to 2 - so I mentioned it. But it seems we can just put that to one side.

However I have a working install ZC 1.5.5f using responsive classic which works fine with OPC1.5.
Indeed there are a number of changes I have made but nothing I can see which would be SO basic as to just stop OPC dead.

I have a full backup code and DB which I am using as reference - done BEFORE the original 1.5 OPC install .

I install 1.5 - all works as expected

Starting from the same point I install OPC 2.

I get the confirmation message - "The One-Page Checkout plugin was successfully upgraded from [] to [2.0.0 (2018-04-27)].
I set Enable One-Page Checkout? to true.
So far exactly as 1.5
BUT the Checkout sequence remains as standard !


So wheel off somewhere - I am a bit suspicious that I may have problem with template definition but cant see where.

So the simple question is - if the OPC says it is installed and the switch is set to true - what would stop the OPC firing and the standard one running??


I am IT guy of tens of years of experience - but could I just check precisely what you mean when you talk about merging files just in case your definition is not the same as mine - i am using WinMerge.

I have a file " The old ONE " from ZC I have a file "the new one" from the OPCInstall
They are different .
By Merge do you mean
Retain all the old code but overwrite any differences including additions from the New or
Aditionally dump any parts of the old code which do not exist in the new
or do I simply replace the old with the new?
May seem obvious but always good to check !

If no one can give me a pointer then I shall do an install from base ZC and add OPC 2 from scratch

[lat9]

@shayne, the "brains" of the One-Page Checkout is /includes/classes/OnePageCheckout.php, working in conjunction with /includes/classes/observers/class.checkout_one_observer.php. If either of those are "damaged" (especially the observer-class), then the page-to-page handling won't kick in.

[simon1066]

@simon1066, what happens if you change the line you identified to read

$opc_disable_address_change = !$editShippingButtonLink;

Probable bug report related to the above change:

index.php?main_page=checkout_one

- change shipping address on page
- select 'cancel'
- change shipping address on page, again
- add/cancel/save buttons do not show


removing the if statement from this code in tpl_modules_opc_shipping_address.php allows the display of buttons (but then removes the shipping address dropdown)

if ($editShippingButtonLink) {
$cancel_title = 'title="' . BUTTON_CANCEL_CHANGES_TITLE . '"';
$save_title = 'title="' . BUTTON_SAVE_CHANGES_TITLE . '"';
$show_add_address = $_SESSION['opc']->showAddAddressField();
$parameters = ($show_add_address) ? '' : ' class="hiddenField"';
?>
...
<?php
}
?></code>

[lat9]

A bug it is! I've created a GitHub issue to track the changes: https://github.com/lat9/one_page_checkout/issues/132

[haredo]

All Fixed ....
Helps after I read the square edit button and turn it to TRUE instead of FALSE ...
Grrrrrrrrrrrrrrrrrrrrrrrrrrrr ...