One-Page Checkout [Support Thread]

[lat9]

I think I found an issue. I noticed this issue under 2.4.4 beta2 and 2.4.4 release version.

Open a fresh browser tab. Add a product to the shopping cart. Click "My Account" link on the bottom (/index.php?main_page=account), it will display the login page (/index.php?main_page=login), which is correct.

Then go back to the shopping cart, click "Go to checkout", then click "Go to checkout" button under the Guest Checkout section. You don't need to fill anything. Go to the bottom of the page then click "My Account" ((/index.php?main_page=account)). You will see error "ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED" on the top of the page. A log file will be generated as the following:

[08-Dec-2022 14:25:27 America/New_York] Request URI: /index.php?main_page=account
#1 checkout_one_observer->messageCheck() called at [/includes/autoload_func.php:61]
#2 require(/includes/autoload_func.php) called at [/includes/application_top.php:222]
#3 require(/includes/application_top.php) called at [/index.php:25]
--> PHP Warning: Use of undefined constant ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED - assumed 'ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED' (this will throw an Error in a future version of PHP) in /includes/classes/observers/class.checkout_one_observer.php on line 258.

Hmm, that constant is defined in /includes/languages/english/extra_definitions/lang.checkout_one_extra_definitions.php. Did you, perhaps, forget to copy that file when you installed?

[njcyx]

Hmm, that constant is defined in /includes/languages/english/extra_definitions/lang.checkout_one_extra_definitions.php. Did you, perhaps, forget to copy that file when you installed?

Hi @lat9, thanks for your always help.

I just checked my testing site directory, and I did find that file lang.checkout_one_extra_definitions.php under the directory /includes/languages/english/extra_definitions/.

To avoid any mistake, I got a fresh copy from the 2.4.4 zip file and uploaded it again to my directory to overwrite the previous file. Unfortunately, the issue remains...

Also, I used the developer took kit function from zen cart to search keyword "ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED". I can find two files have this keyword:

/includes/classes/observers/class.checkout_one_observer.php

and

/includes/languages/english/extra_definitions/lang.checkout_one_extra_definitions.php

[simon1066]

Hmm, that constant is defined in /includes/languages/english/extra_definitions/lang.checkout_one_extra_definitions.php. Did you, perhaps, forget to copy that file when you installed?

In the above file, it appears that

'ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED', 'Access to that page ............

should be

'ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED' => 'Access to that page ............

[simon1066]

In the above file, it appears that

'ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED', 'Access to that page ............

should be

'ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED' => 'Access to that page ............

Raised as an issue on Github.

[njcyx]

In the above file, it appears that

'ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED', 'Access to that page ............

should be

'ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED' => 'Access to that page ............

Hi @Simon, I just tried your suggestion and it fixed! Thanks!

[swguy]

PR created. Thanks Simon.

[lat9]

v2.4.5 of One-Page Checkout is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2095

This release contains changes associated with the following GitHub issues:

#364: Correct missing language-constant ERROR_GUEST_CHECKOUT_PAGE_DISALLOWED.
#367: HTML5, remove type="text/javascript" from <script> tags.
#368: order_status page, correct PHP fatal error on initial installation on zc157.
#369: Ensure that $_SESSION['customers_email_address'] is set for registered-account creation and guest-checkout.