One-Page Checkout [Support Thread]

[jpda]

Please note that DrByte has provided a correction on the Zen Cart GitHub (https://github.com/zencart/zencart/p...b01164048b9c77).

@jpda, could you confirm that those changes correct the issue that you identified?

@lat9
Short answer: no, they didn't.

Explanation:
I am testing on:
zc157d
OPC 2.4.6 (OPC is essential))
shipping method: storepickup with 5 locations, each with their own price.
Problem was: shipping methods are shown but none selected -> payment choices are not shown.

To test the github version of shipping.php, I only replaced its public function cheapest() in the v157d shipping.php.
(The entire github version of shipping.php doesn't work in my v157d environment.)

Tested, but no joy.
Did some debugging:
Changed line 272:

 } elseif ($size === 1) {

in:

} elseif (count($modules_with_quotes) === 1) {

Reason:
module storepickup with more than one location has a $size that equals the number of locations (5 in my example).
Now it works.
Even whith more shipping modules than only storepickup, it is still working.
Tried with flat rate and table and storepickup together.
The lowest price is selected by OPC, even if it is one of the storepickup locations. Payment choices are shown.

Tested without OPC enabled. Three or four page checkout, no cheapest selected, user needs to select shipping to continue to next screen.

Would this be a solution?

Thanks,

jpda