Square Payment Module for Zen Cart [Support Thread]

[twitchtoo]

Hi

Using 156c.

I've just had a complaint about a payment going through twice on the same order.

Sure enough there are two payments.

In my logs I found the following -

"Card nonce already used; please request new nonce."

Based on my brief research of this error,

some can be found here - https://www.sellercommunity.com/t5/D...ard/td-p/27378

can I assume perhaps that the customer managed to refresh the screen (or go back) and trigger the payment twice?

I wonder if we need to add a script to disable the button after one click. Historically on sites where this has been enabled, folks still find a way to refresh or go back and forward (because they are impatient or have super high speed connections) and the problem repeats of 'double clicking the send request'.

Also, this error will display when there is a javascript interfering as mentioned previously - see post #364 in this thread:
https://www.zen-cart.com/showthread....55#post1366255

[royaldave]

I wonder if we need to add a script to disable the button after one click. Historically on sites where this has been enabled, folks still find a way to refresh or go back and forward (because they are impatient or have super high speed connections) and the problem repeats of 'double clicking the send request'.

Also, this error will display when there is a javascript interfering as mentioned previously - see post #364 in this thread:
https://www.zen-cart.com/showthread....55#post1366255

I've had a couple more "double payments" since originally posting. Does anyone else experience this ?

[haredo]

156c
PHP Version: 7.2.29
Upgraded from 155f

Last night I received a debug log file while accessing my Administration Panel.
I had to log into square for a Access Token request.
No biggie, but why am I not receiving an email when from the module itself when under the Log Mode I have this box checked? Log on Failures and Email on Failures
I do not see anywhere under the Edit of this module to submit my email address so upon this error last night I would have received an email.

[mvstudio]

Hello,
I'm running into this error log

[06-Apr-2020 12:42:49 America/Detroit] Request URI: /ADMIN/orders.php?selected_box=customers&status=1&page=1&oID=XXXXXXXXXXX&action=doCaptu re, IP address: XXXXXXXXXXX
#1 zen_update_orders_history() called at [/includes/modules/payment/square.php:1179]
#2 square->_doCapt() called at [/ADMIN/orders.php:308]
--> PHP Warning: Invalid argument supplied for foreach() in /includes/functions/functions_osh_update.php on line 207.

Any idea what's happening?

[mc12345678]

Hello,
I'm running into this error log

[06-Apr-2020 12:42:49 America/Detroit] Request URI: /ADMIN/orders.php?selected_box=customers&status=1&page=1&oID=XXXXXXXXXXX&action=doCaptu re, IP address: XXXXXXXXXXX
#1 zen_update_orders_history() called at [/includes/modules/payment/square.php:1179]
#2 square->_doCapt() called at [/ADMIN/orders.php:308]
--> PHP Warning: Invalid argument supplied for foreach() in /includes/functions/functions_osh_update.php on line 207.

Any idea what's happening?

Any idea what modified includes/functions/functions_osh_update.php away from the ZC installed version? There aren't even 200 lines in the original file...

[mvstudio]

Any idea what modified includes/functions/functions_osh_update.php away from the ZC installed version? There aren't even 200 lines in the original file...

I haven't modified that file. Is there any known plugin that could create that kind of issue?

Correction! Yes, there is a plugin that makes modifications to that file, TY Tracker. But I've never had that happen before. Weird.

[dbltoe]

PHP 7.2 is causing an error in line 1110 of includes/modules/payment/square.php.

[07-Apr-2020 17:35:49 UTC] Request URI: /Ud;reW/orders.php?origin=index&page=1&oID=1718&action=doRefund, IP address: 123.231.145.199#1  square->_doRefund() called at [/home/allpecans/public_html/Ud;reW/orders.php:254]
--> PHP Warning: count(): Parameter must be an array or an object that implements Countable in /home/Ud;reW/public_html/includes/modules/payment/square.php on line 1110.

Am I correct in assuming (I know) that

        if (count($errors_object)) {            $error = $this->parse_error_response($errors_object);
            $messageStack->add_session(MODULE_PAYMENT_SQUARE_TEXT_UPDATE_FAILED . ' [' . $error['detail'] . ']', 'error');


            return false;
        }

should be

        if (empty($errors_object) && is_array($errors_object)) {            $error = $this->parse_error_response($errors_object);
            $messageStack->add_session(MODULE_PAYMENT_SQUARE_TEXT_UPDATE_FAILED . ' [' . $error['detail'] . ']', 'error');


            return false;
        }