Inventory Updater...

[carlwhat]

@simon1066, version 1.2.1 removes the .php from the filename.

in addition, hopefully the ZC team will merge this PR that actually does fix this issue for other plugin authors like myself that make the same mistake:

https://github.com/zencart/zencart/pull/3653

best.

[carlwhat]

version 1.2.1 now available for download here:

https://www.zen-cart.com/downloads.php?do=file&id=2279

update base price as well as inventory!

also, no modifications necessary to work within admin profile security.

best.

[simon1066]

Inventory Updater v1.2.1
PHP v7.2.10

Upgrading to ZCv1.57, I get these myDEBUG logs notices when viewing the Inventory Updater page - I know the notices are not critical but if I don't address these undefined index notices (and many others unrelated to Inventory Updater, across the site) the number of log files will become unmanageable.

[08-Jul-2020 10:59:08 Europe/London] PHP Notice:  Undefined index: sort in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 73
[08-Jul-2020 10:59:08 Europe/London] PHP Stack trace:
[08-Jul-2020 10:59:08 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 10:59:08 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11
[08-Jul-2020 10:59:08 Europe/London] PHP Notice:  Undefined index: sort in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 285
[08-Jul-2020 10:59:08 Europe/London] PHP Stack trace:
[08-Jul-2020 10:59:08 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 10:59:08 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11

... followed by a line 285 entry for every product listed.

inventory.php line 71-76

$sort = (isset($_GET['sort']) ? $_GET['sort'] : '0');
	$order_by = " ";
	switch ($_GET['sort']) {
		case (0):
			$order_by = " ORDER BY p.products_sort_order, pd.products_name";
			break;

inventory.php line 284-286

 <a href="<?= zen_href_link(FILENAME_INVENTORY,
        'action=tg_stat' . '&pid=' . $prod_list->fields['products_id'] . $cid_params . '&sort=' . $_GET['sort'] . '&active=' . $_GET['active'],
        'SSL'); ?>">

'PHP Notice: Undefined index:' seems to be a bit of a theme with my upgrade to ZCv1.57 - seems to be mainly caused by old mods and my crude hacking of php files, still trying to get my head around the whys and wherefores.

[simon1066]

It strikes me that perhaps these notices are a result of the improved error logging in ZCv1.57. TBH I can't remember if ZCv1.56c showed notices or not. In any event I get too many of them.

[carlwhat]

It strikes me that perhaps these notices are a result of the improved error logging in ZCv1.57. TBH I can't remember if ZCv1.56c showed notices or not. In any event I get too many of them.

simon,
can you please provide me the first line in your debug log. the one that has the url you are going to.

thanks.

[simon1066]

simon,
can you please provide me the first line in your debug log. the one that has the url you are going to.

thanks.

Here are the first few lines of the debug, there is no url on the first line - but the link I followed to the Inventory Updater page is

mydomain.co.uk/myadmin/index.php?cmd=inventory

[08-Jul-2020 16:09:12 Europe/London] PHP Notice:  Undefined index: sort in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 73
[08-Jul-2020 16:09:12 Europe/London] PHP Stack trace:
[08-Jul-2020 16:09:12 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 16:09:12 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11
[08-Jul-2020 16:09:13 Europe/London] PHP Notice:  Undefined index: sort in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 285
[08-Jul-2020 16:09:13 Europe/London] PHP Stack trace:
[08-Jul-2020 16:09:13 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 16:09:13 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11
[08-Jul-2020 16:09:13 Europe/London] PHP Notice:  Undefined index: active in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 285
[08-Jul-2020 16:09:13 Europe/London] PHP Stack trace:
[08-Jul-2020 16:09:13 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 16:09:13 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11
[08-Jul-2020 16:09:13 Europe/London] PHP Notice:  Undefined index: sort in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 285
[08-Jul-2020 16:09:13 Europe/London] PHP Stack trace:
[08-Jul-2020 16:09:13 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 16:09:13 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11
[08-Jul-2020 16:09:13 Europe/London] PHP Notice:  Undefined index: active in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 285
[08-Jul-2020 16:09:13 Europe/London] PHP Stack trace:
[08-Jul-2020 16:09:13 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 16:09:13 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11

These notices only appear on first entry to the Updater page, subsequent actions using the various dropdowns yield no notices.

[simon1066]

BTW, the line numbers are different to your stock file because I added some custom lines to display product images - see a previous post for actual code.