PayPal RESTful API Payment Module

[mprough]

Zen Cart 2.1.0
PHP 8.3
Bootstrap 3.7.4
PayPal RESTful 1.1.0

The credit card expiration field, the month of March is there twice, and there is## no expiration option for the month of February.

[lat9]

Zen Cart 2.1.0
PHP 8.3
Bootstrap 3.7.4
PayPal RESTful 1.1.0

The credit card expiration field, the month of March is there twice, and there is## no expiration option for the month of February.

I'm guessing that if you use the browser's developers' tools to inspect that dropdown, there's an 02 id for February but the text reads March. That's a weird date-related issue with the base Zen Cart zcDate class.

[lat9]

I'm guessing that if you use the browser's developers' tools to inspect that dropdown, there's an 02 id for February but the text reads March. That's a weird date-related issue with the base Zen Cart zcDate class.

Yep, if you navigate to the admin's index.php?cmd=banner_statistics&page=0&bID=0&type=monthly&month=4, you'll see that "Mar" is repeated there, too.

[pilou2]

Yep, if you navigate to the admin's index.php?cmd=banner_statistics&page=0&bID=0&type=monthly&month=4, you'll see that "Mar" is repeated there, too.

I found the origin of this problem, and it is not ZcDate class, but the way it is used. It is generally called like this:

$zcDate->output('%b', mktime(0, 0, 0, $i))); 

Where $i is the month number. Day and year are not given as parameter which means the actual date day and year are used.
Problem is when actual date day is higher than the last day of a month. For PHP it is next month, like 30th of February is actually 2nd of March.
This bug only appears at the end of the month, from 29 to 31! The 31th of the month is worse case where all month less than 31 days (Feb., April, June,Sept. and Nov.) will be set to next month...

Solution is to call zcDate class output like this:

$zcDate->output('%b', mktime(0, 0, 0, $i,1))); 

There might be other places in ZC where this needs to be modified...
For this plugin, file paypalr.php needs to be modified on lines 782 and 1269. Line 874 might need it too, not sure yet.

[pilou2]

No modification needed on line 874!

[lat9]

I found the origin of this problem, and it is not ZcDate class, but the way it is used. It is generally called like this:

$zcDate->output('%b', mktime(0, 0, 0, $i))); 

Where $i is the month number. Day and year are not given as parameter which means the actual date day and year are used.
Problem is when actual date day is higher than the last day of a month. For PHP it is next month, like 30th of February is actually 2nd of March.
This bug only appears at the end of the month, from 29 to 31! The 31th of the month is worse case where all month less than 31 days (Feb., April, June,Sept. and Nov.) will be set to next month...

Solution is to call zcDate class output like this:

$zcDate->output('%b', mktime(0, 0, 0, $i,1))); 

There might be other places in ZC where this needs to be modified...
For this plugin, file paypalr.php needs to be modified on lines 782 and 1269. Line 874 might need it too, not sure yet.

Yep, thanks for the follow-up.

[mikestaps]

I found the origin of this problem, and it is not ZcDate class, but the way it is used. It is generally called like this:

$zcDate->output('%b', mktime(0, 0, 0, $i))); 

Where $i is the month number. Day and year are not given as parameter which means the actual date day and year are used.
Problem is when actual date day is higher than the last day of a month. For PHP it is next month, like 30th of February is actually 2nd of March.
This bug only appears at the end of the month, from 29 to 31! The 31th of the month is worse case where all month less than 31 days (Feb., April, June,Sept. and Nov.) will be set to next month...

Solution is to call zcDate class output like this:

$zcDate->output('%b', mktime(0, 0, 0, $i,1))); 

There might be other places in ZC where this needs to be modified...
For this plugin, file paypalr.php needs to be modified on lines 782 and 1269. Line 874 might need it too, not sure yet.

Would it be possible to provide the specific fixes needed on lines 782 and 129?

THX!

[lat9]

Would it be possible to provide the specific fixes needed on lines 782 and 129?

THX!

See this GitHub commit for the changes needed: https://github.com/lat9/paypalr/comm...6973e6a662156c

[mikestaps]

PERFECT! Thank you

[mprough]

I'm guessing that if you use the browser's developers' tools to inspect that dropdown, there's an 02 id for February but the text reads March. That's a weird date-related issue with the base Zen Cart zcDate class.

That's a negative ghost rider =) Looks like PayPal fixed it =)