PayPal RESTful API Payment Module

[pilou2]

I did some quick fix so that PayPalr module does not do its checking every time you want to do some setting on other modules.
But I think a more efficient approach would be to do the API checking only when PayPalr module is installed or one of its settings is modified, and at most when it is selected. More than that and it is useless and just add a time penalty on all your other actions. Two or three modules doing this could render the admin modules page nearly unusable.
Here is the code I changed in

includes/modules/payment/paypalr.php

after line 293:

        $this->enabled = ($this->enabled === true && $this->validateConfiguration($curl_installed));
        if ($this->enabled && IS_ADMIN_FLAG === true) {
            // register/update known webhooks
            $this->ppr->registerAndUpdateSubscribedWebhooks();
        } 

to this:

        if (IS_ADMIN_FLAG === false || ($this->enabled === true && $_GET['module'] === 'paypalr')) {
            $this->enabled = ($this->enabled === true && $this->validateConfiguration($curl_installed));
            if ($this->enabled && IS_ADMIN_FLAG === true) {
                // register/update known webhooks
                $this->ppr->registerAndUpdateSubscribedWebhooks();
            }
        } 

This just a quick fix for those who might have the same problem.

[pilou2]

I did some quick fix so that PayPalr module does not do its checking every time you want to do some setting on other modules.
But I think a more efficient approach would be to do the API checking only when PayPalr module is installed or one of its settings is modified, and at most when it is selected. More than that and it is useless and just add a time penalty on all your other actions. Two or three modules doing this could render the admin modules page nearly unusable.
Here is the code I changed in

includes/modules/payment/paypalr.php

after line 293:

        $this->enabled = ($this->enabled === true && $this->validateConfiguration($curl_installed));
        if ($this->enabled && IS_ADMIN_FLAG === true) {
            // register/update known webhooks
            $this->ppr->registerAndUpdateSubscribedWebhooks();
        } 

to this:

        if (IS_ADMIN_FLAG === false || ($this->enabled === true && $_GET['module'] === 'paypalr')) {
            $this->enabled = ($this->enabled === true && $this->validateConfiguration($curl_installed));
            if ($this->enabled && IS_ADMIN_FLAG === true) {
                // register/update known webhooks
                $this->ppr->registerAndUpdateSubscribedWebhooks();
            }
        } 

This just a quick fix for those who might have the same problem.

Forgot about this code, although it works when in admin module page, it will crash when editing an order that uses PayPal RESTful.
It seems that API initialization is taking time, validation is done at the same time but does not change much about delay...
I am adraid I am out of option.
Do you think it is possible to limit API connection to only when the module is actually used?

[lat9]

v1.3.0 of the PayPal/RESTful payment module is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2382

This release contains changes associated with these GitHub issues:

#100: Account for sites where allow_url_fopen is set to false.
#90: curl_close is deprecated in PHP 8.5
#89: Webhook accesses unconditionally create logs
#88: webhook auto-loader, PHP Fatal errors on ZC versions prior to 2.1.0
#86: Provide polyfills and extra-functions to enable additional PHP/ZenCart versions to be supported
#81: Warning messages caused by conflict with messageStack
#76: Integrate PayPal's PayLater Messaging via PayPal JS SDK