PayPal RESTful API Payment Module

[lat9]

Further inspection of the way that PayPal wants the phone number to be submitted (country-code separated from phone number) makes it "not that easy" to submit phone numbers ... especially since an improperly-formatted one will result in PayPal's rejection of a to-be-placed order.

[pilou2]

Did anybody notice that when PayPal Restfull payment module is installed, the payment module page becomes sluggish?
Normally, when selecting a new line by clicking on it, it takes like half a second, but when PayPal module is installed (sandbox mode on a test cart, last git version) it takes between 2 or 3 seconds!
Uninstalling the module will makes things goback to normal.

[pilou2]

Forgot to say that I used PayPal RESTful v1.2.1.

[lat9]

Forgot to say that I used PayPal RESTful v1.2.1.

Did anybody notice that when PayPal Restfull payment module is installed, the payment module page becomes sluggish?
Normally, when selecting a new line by clicking on it, it takes like half a second, but when PayPal module is installed (sandbox mode on a test cart, last git version) it takes between 2 or 3 seconds!
Uninstalling the module will makes things goback to normal.

What other payment modules are enabled?

[pilou2]

What other payment modules are enabled?

Freecharger.
I uninstalled it but nothing change, I know have PayPalRESTful only.
Does the module try to communicate with a particular PayPal server each time the page is reloaded?

[lat9]

Freecharger.
I uninstalled it but nothing change, I know have PayPalRESTful only.
Does the module try to communicate with a particular PayPal server each time the page is reloaded?

If you're adding PayPal/RESTful to a site that previously has only non-API-using payment methods, then you'll see a delay in the page-load since paypalr communicates with the PayPal server to make sure that it's got a valid order to be processed.

[pilou2]

I am speaking of admin modules page for payment, not on catalog side cart. Just clicking on another module line (installed or not) to select it and I have to wait 2-3s before the new line/module is actualy selected and this only when PayPalr is installed!
It seems some access to distant server is done on each new line selection (page refresh) which is not normal. There is nothing to process and a server response over 2 seconds is too much especially if its with PayPal network that should be fast.
There might be two problems here:
1 - When just selecting other modules, PayPalr module should not have to communicate with PayPal network.
2 - If PayPalr module communicates with PayPal network it should be with a local (country, Japan in my case) server (mirror?), not with a distant (US?) server.

Or it might be something completly different... I actually have no idea.

[lat9]

I am speaking of admin modules page for payment, not on catalog side cart. Just clicking on another module line (installed or not) to select it and I have to wait 2-3s before the new line/module is actualy selected and this only when PayPalr is installed!
It seems some access to distant server is done on each new line selection (page refresh) which is not normal. There is nothing to process and a server response over 2 seconds is too much especially if its with PayPal network that should be fast.
There might be two problems here:
1 - When just selecting other modules, PayPalr module should not have to communicate with PayPal network.
2 - If PayPalr module communicates with PayPal network it should be with a local (country, Japan in my case) server (mirror?), not with a distant (US?) server.

Or it might be something completly different... I actually have no idea.

During the admin's Modules processing, the paypalr payment module verifies that any PayPal credentials entered are valid and auto-disables itself if not.

[pilou2]

During the admin's Modules processing, the paypalr payment module verifies that any PayPal credentials entered are valid and auto-disables itself if not.

That's it! When setting or testing other modules for me maybe it is better to set PayPalr enable option to false? On a live site it should not be too much of a problem as you don't go there very often.
When I was counting 1 2 3 after each click before clicking on something else, it felt like ZC wanted to waltz!
1 2 3 click ... 1 2 3 click ... 1 2 3 clcik ... click, oh sh...t never been good at dansing...

[pilou2]

I did some quick fix so that PayPalr module does not do its checking every time you want to do some setting on other modules.
But I think a more efficient approach would be to do the API checking only when PayPalr module is installed or one of its settings is modified, and at most when it is selected. More than that and it is useless and just add a time penalty on all your other actions. Two or three modules doing this could render the admin modules page nearly unusable.
Here is the code I changed in

includes/modules/payment/paypalr.php

after line 293:

        $this->enabled = ($this->enabled === true && $this->validateConfiguration($curl_installed));
        if ($this->enabled && IS_ADMIN_FLAG === true) {
            // register/update known webhooks
            $this->ppr->registerAndUpdateSubscribedWebhooks();
        } 

to this:

        if (IS_ADMIN_FLAG === false || ($this->enabled === true && $_GET['module'] === 'paypalr')) {
            $this->enabled = ($this->enabled === true && $this->validateConfiguration($curl_installed));
            if ($this->enabled && IS_ADMIN_FLAG === true) {
                // register/update known webhooks
                $this->ppr->registerAndUpdateSubscribedWebhooks();
            }
        } 

This just a quick fix for those who might have the same problem.