That edit certainly works for the majority of the pricing display and it becomes obvious when performing an upgrade that there is a change or difference. Provided you keep the edit just where was suggested, yes many years ago, then plugins can still jump in as necessary or desired as long as you keep making that edit to the most recent version of that file.
An alternative may be to use an observer to adjust that price or other information. I'm not sure if load sequencing has been resolved (ensuring all observers in the same load sequence number are loaded in a known and consistent order), but no matter there are other ways to control that...
Without knowing the store configuration or other plugins loaded, I would create an auto loading observer based off the following notifier:
Code:
$zco_notifier->notify('NOTIFY_ATTRIBUTES_MODULE_ORIGINAL_PRICE', $next_option, $products_options_array, $products_options_display_price, $data_properties);
Adjusting `$products_options_display_proce` to an empty string like the direction of the above link. So that the observer class method would be like:
Code:
public function notify_attributes_module_original_price(&$callClass, $notif, $next_option, &$products_options_array, &$products_options_display_price, &$data_properties)
{
// Do not display a price per attribute for the attribute
// https://www.zen-cart.com/showthread.php/230910-Hide-Product-Attribute-Option-Price-(-XX-XX)?p=1409455#post1409455
$products_options_display_price = '';
}
Still have to build the remainder of the observer class and the above won't work directly for older carts or those having refused to upgrade portions of their base code, but incorporating that and perhaps other observers should allow you to sufficiently manage display of product pricing detail based either on the specific product or just across the board and anywhere in between.
I note that some attribute types have additional price options not controlled right there, like pricing by content being typed (price per character or price per word type pricing)