[BUG][install] Php Version Check

[moku]

My PHP version is "PHP 4.3.10-16" (package from a standard Debian Sarge)

But the installer does not recognize this patern (a.b.c-d) as valid:

PHP Version = 4.3.10-16 {You should consider upgrading!}

I modified the file "zc_install/includes/modules/pages/inspect/header_php.php", line 216 to 222, from

if (phpversion()=="4.1.2") { $php_ver = "<span class='errors'>".phpversion().' {'. SHOULD_UPGRADE . '}</span>'; $err_text = ERROR_TEXT_4_1_2; $err_code = ERROR_CODE_4_1_2; $zc_install->setError($err_text, $err_code, true); $this_class = 'WARN'; } elseif (phpversion() < "4.3.2" && phpversion() != "4.3.11" && phpversion() != "4.3.10") {

to

$phpver = explode('-', phpversion()); $phpver = $phpver[0]; if ($phpver=="4.1.2") { $php_ver = "<span class='errors'>".phpversion().' {'. SHOULD_UPGRADE . '}</span>'; $err_text = ERROR_TEXT_4_1_2; $err_code = ERROR_CODE_4_1_2; $zc_install->setError($err_text, $err_code, true); $this_class = 'WARN'; } elseif ($phpver < "4.3.2" && $phpver != "4.3.11" && $phpver != "4.3.10") {

[TheOracle]

This was already reported a couple of times in the past in the forum since v1.3 of Zen Cart was released. You might try using the forum's search engine on this subject. Only a few results could be returned to you but, these, should all contain bugfixes. ;)

[moku]

Thanks!

So, so far, DrByte is working on this bug. Good news :-)
http://www.zen-cart.com/forum/showthread.php?t=34089#5

I'm working on an alternative which does similar to what the PHP function claims it does, and then just drop anything non-numeric or maybe just take the first X number of characters for comparison after converting to forced-length numbers/strings etc. So far this approach seems to be much more reliable and cross-platform compatible.

[TheOracle]

Glad you found the answer to what you were looking for from the forum's search engine. ;)