Profit Markup/Margin Calculator

[wtashby]

Are the files that should be altered, already included in the download, and already altered? Also, is this 1.3 compatible?

I ask because I installed the sql and uploaded the files included with the download, and it "Broke" my admin. I had to re-upload the origionals just to get into my admin.

This is the error I get when I say that it "Broke" my admin:

Fatal error: Cannot redeclare zen_update_products_price_sorter() (previously declared in C:\Program Files\xampp\htdocs\store\admin\includes\functions\general.php:2495) in C:\Program Files\xampp\htdocs\store\admin\includes\functions\functions_prices.php on line 1311

[whocaresanyway]

open
admin\includes\functions\functions_prices.php
and comment out

lines 1302 to 1311

  function zen_update_products_price_sorter($product_id) {
    global $db;

    $products_price_sorter = zen_get_products_actual_price($product_id);

    $db->Execute("update " . TABLE_PRODUCTS . " set
         products_price_sorter='" . zen_db_prepare_input($products_price_sorter) . "'
         where products_id='" . $product_id . "'");

  }

this function is included in the core files and is whats causing your issue

[wtashby]

that is one of the files that is included in the module download. It also contains those lines. I tried to comment them out as you suggested but still get the same error.


Fatal error: Cannot redeclare zen_parse_salemaker_categories() (previously declared in C:\Program Files\xampp\htdocs\store\admin\includes\functions\general.php:3003) in C:\Program Files\xampp\htdocs\store\admin\includes\functions\functions_prices.php on line 1327

[whocaresanyway]

find

function zen_update_products_price_sorter($product_id) {
    global $db;

    $products_price_sorter = zen_get_products_actual_price($product_id);

    $db->Execute("update " . TABLE_PRODUCTS . " set
         products_price_sorter='" . zen_db_prepare_input($products_price_sorter) . "'
         where products_id='" . $product_id . "'");

  }

in admin\includes\functions\ functions_prices.php


and replace with

/*function zen_update_products_price_sorter($product_id) {
    global $db;

    $products_price_sorter = zen_get_products_actual_price($product_id);

    $db->Execute("update " . TABLE_PRODUCTS . " set
         products_price_sorter='" . zen_db_prepare_input($products_price_sorter) . "'
         where products_id='" . $product_id . "'");

  }*/

then make sure to save and re-upload....

then close browser and reopen the browser window to clear cache

I know that file is included in the download however that function is loaded by zen cart by default, so it dosnt need to be there in the new file

[Farrukh]

Hi

Download the latest version. I have fixed the bugs and cleaned out the wrong files.

Download Profit Markup/Margin Calculator v1.11 ( Zencart v1.3.0.1 Compatible)

USE THIS FILE and read the Readme File and follow it. Only use the files provided in the download, if you have a fresh Zencart v1.3.0.1 Install.


************
Download Link
************

Profit Markup/Margin Calculator v1.11



.

[plowe1]

Hi

Download the latest version. I have fixed the bugs and cleaned out the wrong files.

Download Profit Markup/Margin Calculator v1.11 ( Zencart v1.3.0.1 Compatible)

USE THIS FILE and read the Readme File and follow it. Only use the files provided in the download, if you have a fresh Zencart v1.3.0.1 Install.

I have just compared the files, and have updated the changes, but still i get the error :

Warning: Missing argument 2 for display_price() in /.../catalog/_XadminX/includes/classes/currencies.php on line 70

[Farrukh]

I have just compared the files, and have updated the changes, but still i get the error :

Warning: Missing argument 2 for display_price() in /.../catalog/_XadminX/includes/classes/currencies.php on line 70

The problem seems to be with your present setup of Zencart. Have you installed any other contributions or made any changes to the Zencart.

The error you mentioned cannot be present, since there is no changes involved in /classes/currencies.php

[plowe1]

my zencart is V 1.3.0.1, and is a clean install, there are no other modifications on those files already.


everything has worked fine until i uploaded this mod.. so i can't see how it can't not be something to do with this mod....

this error is displaying in the cost section of the products display in the admin side...

as i suggested earlier, not being a coder, but a wild guess that it must need some sort of refferenct to $products_cost or something like that adding into currencies.php ???


this would be a useful mod, and i hope between us all, we can get this issue fixed..



Simon-m has gone quiet on this topic... have you got it fixed simon ?

[Farrukh]

my zencart is V 1.3.0.1, and is a clean install, there are no other modifications on those files already.


everything has worked fine until i uploaded this mod.. so i can't see how it can't not be something to do with this mod....

this error is displaying in the cost section of the products display in the admin side...

as i suggested earlier, not being a coder, but a wild guess that it must need some sort of refferenct to $products_cost or something like that adding into currencies.php ???


this would be a useful mod, and i hope between us all, we can get this issue fixed..



Simon-m has gone quiet on this topic... have you got it fixed simon ?

I cannot reproduce the problem.

[plowe1]

i did change define('TEXT_PRODUCTS_PRICE_MARGIN_GROSS', 'Gross Margin $:'); to be define('TEXT_PRODUCTS_PRICE_MARGIN_GROSS', 'Gross Margin £:');


but this wouldn't make a difference would it ???

can u paste a copy of your currencies.php so i can compare???