Results 1 to 4 of 4
  1. #1
    Join Date
    Sep 2004
    Posts
    745
    Plugin Contributions
    4

    Default function zen_draw_textarea_field

    In 1.2x versions of ZC the function zen_draw_textarea_field was defined as:

    function zen_draw_textarea_field($name, $wrap, $width, $height, $text = '', $parameters = '', $reinsert_value = true)

    in the new 1.3x version it is defined as:

    function zen_draw_textarea_field($name, $width, $height, $text = '', $parameters = '', $reinsert_value = true)

    However when I search the latest 1.3.01 code base I find dozens of calls that still pass 'soft' as the second parameter. In all of these cases the zen_draw_textarea_field function fails. These calls will all need to be corrected I suspect...

    Jeff

  2. #2
    Join Date
    Sep 2004
    Posts
    745
    Plugin Contributions
    4

    Default Re: function zen_draw_textarea_field

    Never mind...

    I see that the admin version still passes $wrap so only contibutions that used the original version need to be changed...

    Still I'm not sure why a decision was made to do this since removing this param breaks all existing contributions that call zen_draw_textarea_field ??

    Not a good decision IMHO.

    Jeff

  3. #3
    Join Date
    Jun 2003
    Posts
    33,721
    Plugin Contributions
    0

    Default Re: function zen_draw_textarea_field

    The wrap parameter has been deprecated and doesn't validate XHTML.

  4. #4
    Join Date
    Sep 2004
    Posts
    745
    Plugin Contributions
    4

    Default Re: function zen_draw_textarea_field

    Yes, I understand that Kim... I was just suggesting in the future when a param is depricated, that leaving the parameter in the parameter list and just ignoring it would have been better than changing the function call parameters since that breaks any code that used the pre-1.3 call.

    Thanks!
    Jeff

 

 

Similar Threads

  1. v139f Add parameters to zen_draw_textarea_field() without emptying field
    By wolfderby in forum General Questions
    Replies: 2
    Last Post: 8 Jun 2014, 01:27 AM
  2. Replies: 2
    Last Post: 5 Dec 2013, 01:07 PM
  3. Replies: 3
    Last Post: 11 Jan 2011, 02:53 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg