Newsletter-Only Subscriptions for v1.3x

[kookiewookie]

Hi.... i am using zencart 1.3x and newletter only ....2.2 but i get an sql error when eidting and saving something in the clients information ( admin/customers.php )

Error is:

1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'confirmed = 1 WHERE customers_id = '2'' at line 4
in:
[UPDATE soemprefix_subscribers SET email_address = '[email protected]', email_format = 'TEXT' confirmed = 1 WHERE customers_id = '2' ]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.

I have no clue...what is wrong here..

[NotGoddess]

Error is:

1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'confirmed = 1 WHERE customers_id = '2'' at line 4
in:
[UPDATE soemprefix_subscribers SET email_address = '[email protected]', email_format = 'TEXT' confirmed = 1 WHERE customers_id = '2' ]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.

There is a comma missing.
Edit customers.php at at the end of line 274, add a comma:

	email_format = '" . $customers_email_format . "', <----

The entire query:

$db->Execute("UPDATE " . TABLE_SUBSCRIBERS . " 
	 SET	email_address = '" . $customers_email_address . "',
	email_format = '" . $customers_email_format . "',
               confirmed = 1
	 WHERE	customers_id = '" . (int)$customers_id . "' ");

Sorry!

-Ng_

[kookiewookie]

There is a comma missing.
Edit customers.php at at the end of line 274, add a comma:

	email_format = '" . $customers_email_format . "', <----

The entire query:

$db->Execute("UPDATE " . TABLE_SUBSCRIBERS . " 
	 SET	email_address = '" . $customers_email_address . "',
	email_format = '" . $customers_email_format . "',
               confirmed = 1
	 WHERE	customers_id = '" . (int)$customers_id . "' ");

Sorry!

-Ng_

OEF.. i should have seen that one myself really.
Strnagly enough IT only seems to occur when i am using Group Discount.
when i switched it off all worked well again.
NOW with this small "bugfix" it works wuth Discount Groups activated as well!

thank you NG

[ctcentralinfo]

I just installed image handler over this mod. Before if I but in an entry that wasn't an email address I would bet an error message, but now that I installed the new image handler mod I am getting a success message no matter what. What files might have been overwrittein with the installation of image handler that could have caused this?

[ctcentralinfo]

My bad, this is my test site:

http://www.books-japan-online.com/test/

[NotGoddess]

What files might have been overwrittein with the installation of image handler that could have caused this?

I assume you are using Image Handler 2.0 for v1.3 (Tim Kroeger) ?
Taking a quick look I don't see any overlap.
I'll check when I get to my dev machine in a few hours, but I don't see the connect. I have IH2 on a cart and haven't run into issues.

The function that checks for a valid email is:
zen_validate_email() which is in includes/functions/functions_email.php

Are you familiar with using WinMerge or similar file diff utility? If so you can try comparing the contrib to the existing files to see if any has changed.
Pay special attention to the file includes/modules/pages/subscribe/header_php.php as that is where the check is performed.

Unfortunately it's not something I can diagnose from here.

-Ng_

[oann- looks like you'll want the sidebox width patch. on my site or outlined in this thread (just need a few spaces or br's before input/submit)]

[soggychicken]

This is a great mod, except that I am running into some problems:

In the confirmation letter sent out to newsletter subscribers, the text listed under

EMAIL_CONFIRMATION_TEXT

is not displayed anywhere. There is no link for the subscriber to click on to confirm.

I have been poking around the files to look for an answer.

If somebody would care to enlighten me, it will be much appreciated.

[kookiewookie]

Hi!

I have some strange problem with the unsubscribe action on the website.
When i click unsubcribe from newsletter and then the button Unsubscibe
it gives me the message that the emailadres below is unsubscibed....
I did not put in a e-mailadres that should be removed from the list....and offcourse there is no emailaddress showing.

Any idea on this one?

>>> oeps, maybe just have to install the updated version 2.03 , am using 2.02 now.

[NotGoddess]

Do upgrade if you wish, but it's there in 2.0.3 too :) (I guess I should have put out a last call :)

If you edit the template/your_template/templates/tpl_unsubscribe_default.php and change line 14 from:

<?php if (!isset($_GET['action']) || ($_GET['action'] != 'unsubscribe')) { ?>

to

<?php if (empty($unsubscribe_address) || ((!isset($_GET['action']) || ($_GET['action'] != 'unsubscribe')))) { ?>

It will always show the "We're sorry you want to unsubscribe" text for blank emails.

The unsubscribe module is set so if a person enters a nonsense email it'll still tell them it's unsubscribed so people can't use it as a way to suss out emails. That's why it always repeats the email a person enters (in case they misspelled their email).

If people wish I can change that so it gives a 'invalid email' error message instead....3 votes gets it.

[NotGoddess]

I also noted the sorting works wonderfully...until you try to click on a string to edit.
Then it's resetting to the default display.

Also, I'm not sure if it's a 'first record' issue or 'customer' issue but clicking on the first address to edit gives you a blank edit box.

I'll work on both of these tonight and get out a patch.

-Ng_