[Done 1.3.5] No Tax Basis calc using Zones shipping module

[Ryk]

Looking at includes/modules/shipping/zones.php...Line 112->

function zones() {
      $this->code = 'zones';
      $this->title = MODULE_SHIPPING_ZONES_TEXT_TITLE;
      $this->description = MODULE_SHIPPING_ZONES_TEXT_DESCRIPTION;
      $this->sort_order = MODULE_SHIPPING_ZONES_SORT_ORDER;
      $this->icon = '';
      $this->tax_class = MODULE_SHIPPING_ZONES_TAX_CLASS;
      $this->tax_class = MODULE_SHIPPING_ZONES_TAX_CLASS;

Is that correct that the last 2 lines are identical?

[DrByte]

Good catch.

Should be:

      $this->tax_class = MODULE_SHIPPING_ZONES_TAX_CLASS;
      $this->tax_basis = MODULE_SHIPPING_ZONES_TAX_BASIS; 

[Ryk]

This is not exclusive to 1.3 by the way - that exists at least as far back as 1.2.6