[Done 1.3.5]EMAIL_SMTPAUTH_MAIL_SERVER_PORT - only exists in configuration table ?

[TheOracle]

I have discovered a weird problem a couple of mins ago.

Perhaps I missed a spot in the upgrade instructions ... if so, I apologize.

When I tried to search for: EMAIL_SMTPAUTH_MAIL_SERVER_PORT definition, it returns as '0'. I could only found it from my personal search software - which is only located under the configuration table but doesn't seem to be used from includes/functions/functions_email.php file.

It only states the server name, smtp login name, smtp password but not the port number (even if, I believe, is being requested from the admin when we switch the option to: 'smtpauth').

Have I spotted this wrong ?

[DrByte]

I'm not sure I follow what the "problem" is.

That constant is only supposed to be defined in the configuration table.

[DrByte]

Hmmm ... I wasn't following your explanation well... perhaps it's a language thing.

Confirmed.

This will only affect things if you are using SMTP email and are not using the standard Port 25 for sending mail.... which would be a rare occasion unless running from behind a firewall at home etc.

functions_email.php
replace

        $mail->Host = EMAIL_SMTPAUTH_MAIL_SERVER; 

with

        $mail->Host = EMAIL_SMTPAUTH_MAIL_SERVER;
        if (EMAIL_SMTPAUTH_MAIL_PORT != '25' & EMAIL_SMTPAUTH_MAIL_PORT != '') $mail->Port = EMAIL_SMTPAUTH_MAIL_PORT;