Sales report 2.0

[OldNGrey]

Sales Report 2.0 (Version 3.2.0) PHP 7.x

The following changes are required as a minimum. My line numbers are higher than for the original files due to inserted comments for all changes I make.

file: YOUR_ADMIN\includes\classes\sales_report.php
where: at the top of the file approx line 29

define('DATE_FORMAT', 'd/m/Y'); // this is used for date() // BMH addition PHP 7

file: YOUR_ADMIN\includes\classes\sales_report.php
where: at approx lines 266, 270 CHANGE

if (count($this->timeframe[$id]['orders']) == 0) {
        $this->timeframe[$id]['orders'] = false;

TO

 if (empty($this->timeframe[$id]['products'])) { 
        $this->timeframe[$id]['orders'] = false;

file: YOUR_ADMIN\includes\classes\sales_report.php
where: at approx line 411 CHANGE

if (!in_array($pID, $this->timeframe[$id]['total']['diff_products'])) {
       $this->timeframe[$id]['total']['diff_products'][] = $pID;
}

TO

if (!empty($this->timeframe[$id]['orders'][$oID]['diff_products']) ) {
		if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                   $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
		}
	}

file: YOUR_ADMIN\includes\classes\sales_report.php
where: at approx line 417 CHANGE

if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
                $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
       }

TO

if (!empty($this->timeframe[$id]['orders'][$oID]['diff_products']) ) {
    if (!in_array($pID, $this->timeframe[$id]['orders'][$oID]['diff_products'])) {
           $this->timeframe[$id]['orders'][$oID]['diff_products'][] = $pID;
    }
}

Perform these changes in a test environment making only one change at a time and review your log files after each test of the report. Add comments to your code.

[harry2cool]

------
will try and get back.
Thanks

[harry2cool]

Did the changes, however under date it still shows the same as below, however do not get any error in the logs:

IST0JanE_Tue0st+05:300AM2019_TueAM2019

[OldNGrey]

Sorry for the incorrect file reference.

The date format

define('DATE_FORMAT', 'd/m/Y'); // this is used for date() // BMH addition PHP 7

should be placed in YOUR_ADMIN\stats-sales_report.php at approx line 29.

[lat9]

I've got a GitHub update staged that, I believe, addresses this issue: https://github.com/lat9/sales_report/issues/4

[lat9]

I've got a GitHub update staged that, I believe, addresses this issue: https://github.com/lat9/sales_report/issues/4

I've just submitted v3.2.1 of Sales Report to the Zen Cart devs for review. Once accepted, it can be downloaded from this link: https://www.zen-cart.com/downloads.php?do=file&id=9

This release contains the changes associated with the following GitHub issue:


#4: zc156 inter-operation due to language-file load-order change.


If you can't wait for the changes to be posted on the Zen Cart link, you can download the report's distribution zip-file from its GitHub repository: https://github.com/lat9/sales_report...ses/tag/v3.2.1

[lat9]

v3.2.1 of Sales Report is now available for download (thanks, @swguy!).

[gwynwyffar]

Any idea how to fix the SpiffyCal layout? I'm assuming this has to do with the new Bootstrap based Admin style or the updates to the calendar javascript in 1.5.6a, but when attempting to choose a custom date, the calendar goes off the left side of the screen and browser doesn't allow scrolling to the left.

ZenCart 1.5.6a
PHP 7.1

Tested in Firefox 65, Chrome 72, MS Edge
Attachment 18358

[carlwhat]

Any idea how to fix the SpiffyCal layout? I'm assuming this has to do with the new Bootstrap based Admin style or the updates to the calendar javascript in 1.5.6a, but when attempting to choose a custom date, the calendar goes off the left side of the screen and browser doesn't allow scrolling to the left.

ZenCart 1.5.6a
PHP 7.1

Tested in Firefox 65, Chrome 72, MS Edge
Attachment 18358

the problem is with the spiffyCal plugin that comes with the base ZC package. it is version 2.1 and dated 2001. i think this is a plugin that needs to be replaced by the ZC team.

this spiffyCal is used in a number of places, so changes here can affect where it is used elsewhere. so use with caution.

if you go here:

YOUR_ADMIN/includes/javascript/spiffyCal/spiffyCal_v2_1.js

lines 1026 and 1037; you will see:

- 250

change that to

-10

not sure how it will affect other dates in your admin.

                if (scIE) {
                    if (this.displayLeft) {
                        scX = getOffsetLeft(document.images[this.btnName]) - 10 + document.images[this.btnName].width;
                    } else {
                        scX = getOffsetLeft(document.images[this.btnName]);
                    }
                    if (this.displayTop) {
                        scY = getOffsetTop(document.images[this.btnName]) - 138;
                    } else {
                        scY = getOffsetTop(document.images[this.btnName]) + document.images[this.btnName].height + 2;
                    }
                } else if (scNN) {
                    if (this.displayLeft) {
                        scX = document.images[this.btnName].x - 10 + document.images[this.btnName].width;
                    } else {
                        scX = document.images[this.btnName].x;

[lat9]

Thanks, @carlwhat, for that investigation. I've noted the issue on Sales Report's GitHub repository (https://github.com/lat9/sales_report/issues/5).

Please note that since it's a Zen Cart core-file involved, it's not likely that I'll be including that change with the plugin ... other than to document the anomaly and your fix.