Sales report 2.0

[lat9]

I've got a GitHub update staged that, I believe, addresses this issue: https://github.com/lat9/sales_report/issues/4

[lat9]

I've got a GitHub update staged that, I believe, addresses this issue: https://github.com/lat9/sales_report/issues/4

I've just submitted v3.2.1 of Sales Report to the Zen Cart devs for review. Once accepted, it can be downloaded from this link: https://www.zen-cart.com/downloads.php?do=file&id=9

This release contains the changes associated with the following GitHub issue:


#4: zc156 inter-operation due to language-file load-order change.


If you can't wait for the changes to be posted on the Zen Cart link, you can download the report's distribution zip-file from its GitHub repository: https://github.com/lat9/sales_report...ses/tag/v3.2.1

[lat9]

v3.2.1 of Sales Report is now available for download (thanks, @swguy!).

[gwynwyffar]

Any idea how to fix the SpiffyCal layout? I'm assuming this has to do with the new Bootstrap based Admin style or the updates to the calendar javascript in 1.5.6a, but when attempting to choose a custom date, the calendar goes off the left side of the screen and browser doesn't allow scrolling to the left.

ZenCart 1.5.6a
PHP 7.1

Tested in Firefox 65, Chrome 72, MS Edge
Attachment 18358

[carlwhat]

Any idea how to fix the SpiffyCal layout? I'm assuming this has to do with the new Bootstrap based Admin style or the updates to the calendar javascript in 1.5.6a, but when attempting to choose a custom date, the calendar goes off the left side of the screen and browser doesn't allow scrolling to the left.

ZenCart 1.5.6a
PHP 7.1

Tested in Firefox 65, Chrome 72, MS Edge
Attachment 18358

the problem is with the spiffyCal plugin that comes with the base ZC package. it is version 2.1 and dated 2001. i think this is a plugin that needs to be replaced by the ZC team.

this spiffyCal is used in a number of places, so changes here can affect where it is used elsewhere. so use with caution.

if you go here:

YOUR_ADMIN/includes/javascript/spiffyCal/spiffyCal_v2_1.js

lines 1026 and 1037; you will see:

- 250

change that to

-10

not sure how it will affect other dates in your admin.

                if (scIE) {
                    if (this.displayLeft) {
                        scX = getOffsetLeft(document.images[this.btnName]) - 10 + document.images[this.btnName].width;
                    } else {
                        scX = getOffsetLeft(document.images[this.btnName]);
                    }
                    if (this.displayTop) {
                        scY = getOffsetTop(document.images[this.btnName]) - 138;
                    } else {
                        scY = getOffsetTop(document.images[this.btnName]) + document.images[this.btnName].height + 2;
                    }
                } else if (scNN) {
                    if (this.displayLeft) {
                        scX = document.images[this.btnName].x - 10 + document.images[this.btnName].width;
                    } else {
                        scX = document.images[this.btnName].x;

[lat9]

Thanks, @carlwhat, for that investigation. I've noted the issue on Sales Report's GitHub repository (https://github.com/lat9/sales_report/issues/5).

Please note that since it's a Zen Cart core-file involved, it's not likely that I'll be including that change with the plugin ... other than to document the anomaly and your fix.

[lat9]

Thanks, @carlwhat, for that investigation. I've noted the issue on Sales Report's GitHub repository (https://github.com/lat9/sales_report/issues/5).

Please note that since it's a Zen Cart core-file involved, it's not likely that I'll be including that change with the plugin ... other than to document the anomaly and your fix.

Turns out, the correction can be made by adding the following block to the bottom of /admin/stats_sales_reports.php's additional CSS block:

<?php
if (PROJECT_VERSION_MAJOR . '.' . PROJECT_VERSION_MINOR > '1.5.6') {
?>
#spiffycalendar { left: 10px!important; }
<?php
}
?>

[gwynwyffar]

Thanks for the fix carlwhat. I checked most of the places I could remember that use the SpiffyCal (Specials, SaleMaker, Featured Products) and your fix doesn't seem to adversely affect the ability to select a date, however on the Featured Products admin page it does push the calendar off the page to the right, but at least the browser can scroll over to select a date on that one.

I will try lat9's fix instead.