Results 1 to 10 of 3727

Threaded View

  1. #23
    Join Date
    Jan 2007
    Location
    Los Angeles, California, United States
    Posts
    10,021
    Plugin Contributions
    32

    Default Re: Zen Lightbox addon [Support Thread]

    Quote Originally Posted by mc12345678 View Post
    Regarding the location that this was installed, and with consideration of default database settings of a new install, would the products_model value be set to NULL as a default or blank as the new code suggests? (Ie. Was this field in the tested database one that automatically fills with a blank when no model number is provided or as a Null as the original/core code suggests?) Perhaps the logic shold be switched such that it tests if null || == "" to show without the model_number info else show with the model_number. That way the database could have either setting independent of version history and the fix would still work.
    Blank not null.. and this code isn't new, I simply ported over the same code that is used on the "write reviews" page so that "write reviews" and "read reviews" handle the display of the product name and model number the exact same way. Trust me.. what I posted IS the right answer.. The "write reviews" page worked correctly, the "read reviews" page did not.. So porting over the "write reviews" code solves the issue on the "read reviews" page..

    Now is a better method for both pages to display the product name and model number?? Dunno.. there very well might be.. But the issue here is that the code being used by "write reviews" is not problematic, and the code on the "read reviews" is. My solution addresses that much..

    Are improvements to this code on both pages possible?? Maybe.. I'll let someone smarter than I figure that out.. it not the issue I was trying to solve..
    Last edited by DivaVocals; 25 Aug 2013 at 11:04 PM.
    My Site - Zen Cart & WordPress integration specialist
    I don't answer support questions via PM. Post add-on support questions in the support thread. The question & the answer will benefit others with similar issues.

 

 

Similar Threads

  1. Free Shipping Rules addon [Support Thread]
    By numinix in forum Addon Shipping Modules
    Replies: 36
    Last Post: 2 Dec 2016, 01:56 PM
  2. v151 Reviews Reply addon [Support Thread]
    By mikestaps in forum All Other Contributions/Addons
    Replies: 9
    Last Post: 17 Oct 2014, 01:29 AM
  3. Jquery Lightbox [Support thread]
    By yellow1912 in forum All Other Contributions/Addons
    Replies: 257
    Last Post: 2 Aug 2012, 10:57 PM
  4. File Upload Required addon [Support Thread]
    By 1100101 in forum All Other Contributions/Addons
    Replies: 21
    Last Post: 10 Dec 2011, 03:00 AM
  5. [Support Thread] IE only JavaScripts and Stylesheets Addon
    By Meshach in forum All Other Contributions/Addons
    Replies: 16
    Last Post: 31 May 2011, 08:18 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg