Zen Lightbox addon [Support Thread]

[pewe]

just forked and submitted a small change

What was the small change - did you find a problem somewhere?
(Github shows all the files as being last changed 2 days ago.)

[mc12345678]

What was the small change - did you find a problem somewhere?
(Github shows all the files as being last changed 2 days ago.)

Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.

[Design75]

Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.

That's the one :)

[pewe]

Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.

Forgive me - am I missing something.
The files on the Github link posted by @niestudio are still showing as posted 2 days ago, and the file there (slimbox.php) still appears to contain the same code as the one I have.

So is there a different link to the re-submitted file??

[mc12345678]

Forgive me - am I missing something.
The files on the Github link posted by @niestudio are still showing as posted 2 days ago, and the file there (slimbox.php) still appears to contain the same code as the one I have.

So is there a different link to the re-submitted file??

This really isn't the place to discuss how github works. If that type of assistance is needed a separate thread should be begun, possibly on an entirely different website. More can be seen at:
https://github.com/Zen4All/zen_light...f66243b95c709c

[pewe]

This really isn't the place to discuss how github works. If that type of assistance is needed a separate thread should be begun, possibly on an entirely different website. More can be seen at:
https://github.com/Zen4All/zen_light...f66243b95c709c

In which case - with all due respect - if someone makes a change to an zen cart plugin (particularly one already hosted on the zen cart plugins section) surely the changes should be uploaded to the Plugin repository where zen cart users would expect to find it (as niestudio kindly did) - or at least post details of the changes in the relevant plugin support thread so others could see them without visiting a third party hosting service.

[mc12345678]

In which case - with all due respect - if someone makes a change to an zen cart plugin (particularly one already hosted on the zen cart plugins section) surely the changes should be uploaded to the Plugin repository where zen cart users would expect to find it (as niestudio kindly did) - or at least post details of the changes in the relevant plugin support thread so others could see them without visiting a third party hosting service.

No disrespect observed, thank you for the concern. The issue(s) are this: the Zen Cart forum and plugin areas, do not as openly support a collaboration/testing of a product to be made available/acceptable to all that will use it. Generally speaking, github is an open source location (when not paying to have a private space) where yes collaboration can occur. In this case, one meber of the community posted the code and in essence is in control of that code. Another member of the community has provided their input (including a statement of such here as wellas performing the actions to notify the original poster.) That individual could go through the submission of an "updated" plug-in, or could allow the community to incorporate the suggestion or perhaps the change is not beneficial to the masses. Whatever the case, other than our coonversation on this portion of the topic, I don't see that Design75 nor niestudio have done anything wrong. At this point it is basically up to niestudio to accept the change that Design75 has suggested in order for that revision to appear in the final package of the github link. This is also how multiple versions of a product end up existing. One developer heads down a path, another picks up part way and goes another direction and the two do not get merged together offering multiple programs that essentially do the same thing but have different ways of getting there or slightly different features.

[DivaVocals]

In which case - with all due respect - if someone makes a change to an zen cart plugin (particularly one already hosted on the zen cart plugins section) surely the changes should be uploaded to the Plugin repository where zen cart users would expect to find it (as niestudio kindly did) - or at least post details of the changes in the relevant plugin support thread so others could see them without visiting a third party hosting service.

No disrespect observed, thank you for the concern. The issue(s) are this: the Zen Cart forum and plugin areas, do not as openly support a collaboration/testing of a product to be made available/acceptable to all that will use it. Generally speaking, github is an open source location (when not paying to have a private space) where yes collaboration can occur. In this case, one meber of the community posted the code and in essence is in control of that code. Another member of the community has provided their input (including a statement of such here as wellas performing the actions to notify the original poster.) That individual could go through the submission of an "updated" plug-in, or could allow the community to incorporate the suggestion or perhaps the change is not beneficial to the masses. Whatever the case, other than our coonversation on this portion of the topic, I don't see that Design75 nor niestudio have done anything wrong. At this point it is basically up to niestudio to accept the change that Design75 has suggested in order for that revision to appear in the final package of the github link. This is also how multiple versions of a product end up existing. One developer heads down a path, another picks up part way and goes another direction and the two do not get merged together offering multiple programs that essentially do the same thing but have different ways of getting there or slightly different features.

and to piggyback on this, this is EXACTLY where/how updates to the Zen Cart framework are conducted.. Zen Cart maintains an ACTIVE github repository. All niestudio did was to do the SAME THING with Zen Lightbox when he created the gibhub repository for this module.. and Design75 did what good community members do.. CONTRIBUTE/COLLABORATE..

mc12345678 is right.. No one is doing anything wrong.. In fact this is the RIGHT way to do it so that Zen Lightbox doesn't go the way of modules like Stock by Attributes which now has SO MANY forks/variants/versions (with various degrees of suitability/stability) that were created and submitted by well meaning community members NOT based on community needs, but the need of the individual authors. These well meaning authors fork this module to HELL without any regard for how these variations could cause more harm than good down the road. (multiple modules where a feature works on one, but not on another version, etc)

[DivaVocals]

Check the pull requests. Essentially the submitted change removes the echo statement in the includes/classes/zen_light_box/slimbox.php file that loads the jquery script from the template folder.

Without seeing this change, this sounds like the same change I made to the Colorbox module.. I removed the echo statement that calls the jQuery CDN and instead made this call to the CDN via a file in the jscript folder (plus I updated it to call the latest version of jQuery as well).. I did this for a number of reasons. The biggest reason is so that shopowners who have templates or other modules which ALSO include jQuery do not end up with jQuery loaded twice (they can remove the duplicates or not load them at all). Otherwise novice shopowners will end up being unable to trace WHERE the other jQuery call is.