Page 1 of 2 12 LastLast
Results 1 to 10 of 3727

Hybrid View

  1. #1
    Join Date
    Nov 2009
    Posts
    285
    Plugin Contributions
    5

    Default Re: Image Display Size Restriction

    Quote Originally Posted by DivaVocals View Post
    I agree with the fallback code.. it's a BIG problem with sooooo many modules and templates using jQuery and shopowners unwittingly having MULTIPLE versions of jQuery running in their shops.. (which was the inspiration for my contribution)

    Couldn't backwards compatibility be mitigated with the jQuery Migrate script??
    Code:
    <script src="http://code.jquery.com/jquery-migrate-1.2.1.js"></script>

    Have you ever suggested that ZC roll a latest jQuery call into the ZC default template?

    Hmm, I've never come across this before. Sounds interesting but would not have worked for this since it only supports jQuery 1.6.4 and later.
    Going forward it could be good though.

  2. #2
    Join Date
    Jan 2007
    Location
    Los Angeles, California, United States
    Posts
    10,021
    Plugin Contributions
    32

    Default Re: Image Display Size Restriction

    Quote Originally Posted by niestudio View Post
    Have you ever suggested that ZC roll a latest jQuery call into the ZC default template?
    I believe that v1.6 (though I haven't looked at the gibhub lately) is going to do JUST THAT.. Then there would be no NEED for plugin authors to have to include jQuery files which would also eliminate the issue with multiple jQuery versions being loaded on a shop..

    It's a path WordPress also took in recent versions so that plugin developers wouldn't have to include jQuery in their plugins. Eliminates the number of plugin clashes due to conflicting versions of jQuery loading at once on a site..

    Quote Originally Posted by niestudio View Post
    Hmm, I've never come across this before. Sounds interesting but would not have worked for this since it only supports jQuery 1.6.4 and later.
    Going forward it could be good though.
    Well I've used it with Zen Lightbox with no issues.. let me find the site and post the URL.. Here's the gihub for the jQuery Migrate script: https://github.com/jquery/jquery-migrate/#readme

    Edited to add: http://laserdiscvault(dot)com/
    CDN calls for jQuery and the jQuery Migrate script.. This is both the changes Design75 and I submitted to github with the addition of the jQuery Migrate script.. Lightbox works with no issues..
    Last edited by DivaVocals; 12 Nov 2013 at 09:24 PM.
    My Site - Zen Cart & WordPress integration specialist
    I don't answer support questions via PM. Post add-on support questions in the support thread. The question & the answer will benefit others with similar issues.

  3. #3
    Join Date
    Dec 2009
    Location
    Amersfoort, The Netherlands
    Posts
    2,845
    Plugin Contributions
    25

    Default Re: Image Display Size Restriction

    haha , you make one little change in code and get almost 2,5 pages of reading in return .

    The reason I did not change the jquery version, is because I wanted to make this first change as easy as possible. I know ZLB runs fine on JQ 1.8.4 , and probably later versions. My knowledge of Jquery is only limited. I wanted to integrate the latest version of slimbox, but since I do not have enough knowledge of Jquery, and a limited amount of time, I choose to only remove the echo command and rename the script-name to start with jscript_ .

  4. #4
    Join Date
    Nov 2009
    Posts
    285
    Plugin Contributions
    5

    Default Re: Image Display Size Restriction

    Quote Originally Posted by Design75 View Post
    haha , you make one little change in code and get almost 2,5 pages of reading in return .

    The reason I did not change the jquery version, is because I wanted to make this first change as easy as possible. I know ZLB runs fine on JQ 1.8.4 , and probably later versions. My knowledge of Jquery is only limited. I wanted to integrate the latest version of slimbox, but since I do not have enough knowledge of Jquery, and a limited amount of time, I choose to only remove the echo command and rename the script-name to start with jscript_ .

    has happened this way a lot over the years.

    I'll go ahead and update to Slimbox 2.05 then we can safely load jQuery latest.

  5. #5
    Join Date
    Nov 2009
    Posts
    285
    Plugin Contributions
    5

    Default Re: Image Display Size Restriction

    Quote Originally Posted by Design75 View Post
    haha , you make one little change in code and get almost 2,5 pages of reading in return .
    should we move this part of the discussion to github instead since this is not helpful for someone lookin for basic ZLB help?

  6. #6
    Join Date
    Nov 2009
    Posts
    285
    Plugin Contributions
    5

    Default Re: Image Display Size Restriction

    Quote Originally Posted by DivaVocals View Post

    Edited to add: http://laserdiscvault(dot)com/
    CDN calls for jQuery and the jQuery Migrate script.. This is both the changes Design75 and I submitted to github with the addition of the jQuery Migrate script.. Lightbox works with no issues..
    I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
    I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4

  7. #7
    Join Date
    Jan 2007
    Location
    Los Angeles, California, United States
    Posts
    10,021
    Plugin Contributions
    32

    Default Re: Image Display Size Restriction

    Quote Originally Posted by niestudio View Post
    I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
    I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4
    I'm sure I read elsewhere it will work with older versions too.. That's something I can EASILY and quickly test..
    My Site - Zen Cart & WordPress integration specialist
    I don't answer support questions via PM. Post add-on support questions in the support thread. The question & the answer will benefit others with similar issues.

  8. #8
    Join Date
    Jan 2007
    Location
    Los Angeles, California, United States
    Posts
    10,021
    Plugin Contributions
    32

    Default Re: Image Display Size Restriction

    Quote Originally Posted by niestudio View Post
    I see that you are using migrate 1.0 on this site, and maybe that encompasses jQuery 1.4 with no issues.
    I just saw on the GH page that the latest version (1.2.1) only covers jQuery 1.6.4
    Quote Originally Posted by DivaVocals View Post
    I'm sure I read elsewhere it will work with older versions too.. That's something I can EASILY and quickly test..
    Done.. take a look now.. Update the jQuery and jQuery Migrate versions.. Lightbox still works like a champ..

    Quote Originally Posted by niestudio View Post
    should we move this part of the discussion to github instead since this is not helpful for someone lookin for basic ZLB help?
    I would agree with this move..
    My Site - Zen Cart & WordPress integration specialist
    I don't answer support questions via PM. Post add-on support questions in the support thread. The question & the answer will benefit others with similar issues.

  9. #9
    Join Date
    Dec 2009
    Location
    Amersfoort, The Netherlands
    Posts
    2,845
    Plugin Contributions
    25

    Default Re: Image Display Size Restriction

    Quote Originally Posted by DivaVocals View Post
    I would agree with this move..
    I would also agree

  10. #10
    Join Date
    Nov 2013
    Location
    Toronto
    Posts
    1
    Plugin Contributions
    0

    Default Re: Image Display Size Restriction

    Hello, I am very new to zen cart. I have tried to install the lightbox addon (version: 1.6.4b_1.5). However, it was not successful. I have the following questions. in the installation file:
    4.Rename the following folders to match your template folder name.

    includes\languages\english\extra_definitions\YOUR-TEMPLATE-FOLDER
    includes\modules\YOUR-TEMPLATE-FOLDER
    includes\templates\YOUR-TEMPLATE-FOLDER

    I am wondering the "YOUR-TEMPLATE-FOLDER" is it the folder at Admin-->Tools-->Template Selection. In my case, it is theme377. Please help.

 

 
Page 1 of 2 12 LastLast

Similar Threads

  1. Free Shipping Rules addon [Support Thread]
    By numinix in forum Addon Shipping Modules
    Replies: 36
    Last Post: 2 Dec 2016, 01:56 PM
  2. v151 Reviews Reply addon [Support Thread]
    By mikestaps in forum All Other Contributions/Addons
    Replies: 9
    Last Post: 17 Oct 2014, 01:29 AM
  3. Jquery Lightbox [Support thread]
    By yellow1912 in forum All Other Contributions/Addons
    Replies: 257
    Last Post: 2 Aug 2012, 10:57 PM
  4. File Upload Required addon [Support Thread]
    By 1100101 in forum All Other Contributions/Addons
    Replies: 21
    Last Post: 10 Dec 2011, 03:00 AM
  5. [Support Thread] IE only JavaScripts and Stylesheets Addon
    By Meshach in forum All Other Contributions/Addons
    Replies: 16
    Last Post: 31 May 2011, 08:18 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg