Whats wrong with this query? Fresh eyes needed ;)

[paulm]

I think you are trying to use this line of code inside a function, but forgot to make $db global.

like:

global $db; 

[Reesy]

Thanks for that.
I now get an error
1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Object' at line 1
in:
[Object]

if (zen_not_null(POINTS_AUTO_EXPIRES)){
    global $db;
      $points_query = $db->Execute("SELECT customers_shopping_points FROM " . TABLE_CUSTOMERS . " WHERE customers_id = '" . (int)$id . "' AND customers_points_expires > CURDATE() LIMIT 1");
    } else {
      $points_query = $db->Execute("SELECT customers_shopping_points FROM " . TABLE_CUSTOMERS . " WHERE customers_id = '" . (int)$id . "' LIMIT 1");
    }
    $points = $db->Execute($points_query);

    return $points['customers_shopping_points'];
  } 

[Merlinpa1969]

try using the global Outside the if statement

[Reesy]

Hi Merlin,
I tried that first time around adding it to the top of the file.
If I do that I get the same fatal error
Fatal error: Call to a member function on a non-object

if (zen_not_null(POINTS_AUTO_EXPIRES)){
      $points_query = $db->Execute("SELECT customers_shopping_points FROM " . TABLE_CUSTOMERS . " WHERE customers_id = '" . (int)$id . "' AND customers_points_expires > CURDATE() LIMIT 1");
    } else {
      $points_query = $db->Execute("SELECT customers_shopping_points FROM " . TABLE_CUSTOMERS . " WHERE customers_id = '" . (int)$id . "' LIMIT 1");
    } 

Feeling much fresher today but cant figure this out for the life of me

[Reesy]

ahhhhh the wonders of coca cola ;)
Ive figured it out, theres not meant to be any _query on any of the queries so...

if (zen_not_null(POINTS_AUTO_EXPIRES)){
$points_query = $db->Execute("SELECT customers_shopping_points FROM " . TABLE_CUSTOMERS . " WHERE customers_id = '" . (int)$id . "' AND customers_points_expires > CURDATE() LIMIT 1");
} else {
$points_query = $db->Execute("SELECT customers_shopping_points FROM " . TABLE_CUSTOMERS . " WHERE customers_id = '" . (int)$id . "' LIMIT 1");
}

Isnt meant to be there.

[Ajeh]

Note: this line ...

return $points['customers_shopping_points']; 

Might result in a better answer if you use:

return $points->fields['customers_shopping_points']; 

[Reesy]

Thanks to Ajeh for the pointer...
In the end my cola power cotton wool fueled head decided to check how another file does this and finally came up with the following ...

    if (zen_not_null(POINTS_AUTO_EXPIRES)){
    global $db;
      $points_query = "SELECT customers_shopping_points FROM " . TABLE_CUSTOMERS . " WHERE customers_id = '" . (int)$id . "' AND customers_points_expires > CURDATE() LIMIT 1";
    } else {
      $points_query = "SELECT customers_shopping_points FROM " . TABLE_CUSTOMERS . " WHERE customers_id = '" . (int)$id . "' LIMIT 1";
    }
    $points = $db->Execute("$points_query");

    return $points->fields['customers_shopping_points'];
  }