CSS buttons v2.x

[paulm]

Hi Steven,

that's weird indeed. I have installed the latest css buttons version (2.5) on both my live shop (1.3.6 but modified) and on a fresh 1.3.6 install. And I don't have this problem on either. To be sure I just did some testorders on the fresh 1.3.6 install. Also I never heard about problems like this before with the CSS buttons.

Maybe you can try to comment out the $parameters hack I recently added to make the CSS buttons simulate image buttons (added to fix the GV edit button bug):

    // bof hack to simulate image button (replace parameter by _x parameter)
    // needed for gv name="edit" button (other named buttons are name="btn_submit" and name="submit1" and ...??)
    if (strpos($parameters, 'name')!== false){
    // replace by regular expression
      $s=strpos($parameters, '"', strpos($parameters, 'name'))+1;
      $e=strpos($parameters, '"', $s);
      $name = substr($parameters, $s, $e-$s);
      // replaces values of both name and value ()
      //$parameters = str_replace($name, $name . '_x', $parameters);
      // replaces the value of name only
      $parameters = substr_replace($parameters, $name . '_x', $s, $e-$s);
    }
    // eof hack to simulate image button

(in the includes/functions/extra_fuctions/css_buttons.php file)

[jettrue]

Anyone else noticing padding differences in IE for the submit buttons?

I've added just a tad of a top and bottom padding for the buttons, as I want them a little taller, but in IE, there is much more of a top padding than a bottom padding. I use this setting for padding: padding:0.2em 0.5em;.... yet even with the standard padding:0 0.5em;, there is still more top padding than bottom padding in IE. You can see what I mean here:
http://www.zencart136.jadetrue.com/i...&products_id=2

(look at the add to cart vs. tell a friend and write review)

[mat123slade]

Hi, when inserting the following into phpmyadmin :

INSERT INTO edl_configuration( configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, use_function, set_function )
VALUES (
'Enable CSS buttons (catalog)', 'CSSBUTTONS_CATALOG_ENABLE', 'true', 'If true, CSS buttons for the catalog are enabled', @cssbuttonsid , 10, NULL , 'zen_cfg_select_option(array("true", "false"),'
)

I'm getting the following error :

MySQL a répondu:Documentation
#1048 - Column 'configuration_group_id' cannot be null

Problem seams to come from the fact that it is considering : @cssbuttonsid as being null.

Any idea how to solve the problem.

Cheers.

[paulm]

Anyone else noticing padding differences in IE for the submit buttons?

I've added just a tad of a top and bottom padding for the buttons, as I want them a little taller, but in IE, there is much more of a top padding than a bottom padding. I use this setting for padding: padding:0.2em 0.5em;....

It's best to leave the top/bottom padding 0, and instead adjust the height and line-height (always giving both the same value!). It often helps to increase the font-size/height/line-height a little, at small sizes weird things can happen...


@mat123slade: are you trying to add only that part of the total sql? If so, @cssbuttonsid indeed will have no value.

[s_mack]

Hey Paul...

Ok, so its just mine. I can't figure it out... tres weird.

If I comment out the parameters it works fine... its something with those parameters that's doing it. I can't even see how it is possible... I've put in a debugging routine, and the page that loads the button is accessed once only, but ALL the routines that occur after you hit the button are run twice. Its like I'm hitting button two times. But only with css buttons (yours or my earlier hack)... the stock css buttons works fine. But now that I know its me, I'll continue to search for what I've done.

- Steven

[paulm]

Hi Steven,

I assume you've have taken a close look at the little hack (the code I posted above) that makes the buttons act like image buttons? It really *is* a hack, so maybe that part interferes with your modifications? The idea is that that part of the code looks for a name="value" in the $parameters and, if found, it should convert it to name_x="value".

[DjSap]

Hey i was just wondering why the buttons do not look uniform, for example, the add to cart button has more padding then the other buttons.

[s_mack]

Its been asked before... some buttons are "submit" type buttons where they are actually submitting an HTML form. Others are simply links. There must be something in css that you can do to make them equal, but for the life of me I couldn't figure it out. It bugged me enough, I actualy ended up deleting most of the link buttons, because they were usually just "back" buttons... and that's what the browser's back button is for.

If anyone does figure this out, I'd like to know too. I don't really care any more, but man that was frustrating.

- Steven

[paulm]

If anyone does figure this out, I'd like to know too. I don't really care any more, but man that was frustrating.

Actually it's exactly how it went here Steven. Although I think the current version generates buttons that are acceptable, and more or less stable, the result is not pixel perfect.

One of the other problems I encounter sometimes, is that the size of the buttons depend on other "surrounding" HTML/CSS. Not sure if this is typical for Zen Cart or that it's a general problem with dynamic CSS buttons.

As I mentioned before (in this thread?) examples of CSS buttons found on the internet are most of the time static (a.o. fixed with and height, and not used in different "surroundings") and not about both links and form buttons (as mentioned by Steven).

Nevertheless I still like CSS buttons over image buttons myself. I rather edit a couple of CSS lines to change the size color (or whatever) to make a particular button look different, than create a new image button everytime I need a new or different button. (but of course this is mostly about personal preference ;-) )

And please note that the default Zen Cart CSS buttons are different (less stable width and padding tmho) than the buttons generated by this contribution!

[s_mack]

You're right.. from a fresh 1.36 install with your contrib, the effect was very much minimized. On mine (very much NOT fresh 1.3.6) It was grotesquely obvious there was a difference in the buttons. And I never could understand why. I stripped the css down as much as I could to figure it out, but eventually just gave up.

My reason to use css buttons was different than yours. My goal was to make an elasticly rendered site so that visually-impaired people could increase the font size and still see my site the way it was intended. The graphical buttons make that impossible so I went toward css...

until I realized it wasn't impossible with graphical buttons.. just difficult :)

I'm there though. My site is 99% elastic! You can increase/decrease and zoom in/out to your heart's content (and browser's limits) and my site will stay exactly as it is intended.... formatting doesn't get screwed up because images now grow and shrink along with the text... something many "authorities" on the web say is impossible :)

DOWN WITH PIXELS!!

- Steven