Testimonial Manager Support Thread

[DivaVocals]

I installed the PHP 5.3.8, mySQL 5.5.16 version of xampps. Yes this mySQL 5.5.16 version does has issues with the install.sql statement for Testimonials Manager. Thanks again lat9 for your updated version of the new_install.sql statement. I have updated Testimonials Managers sql.statement. It has been uploaded waiting for approval from the zen team.

Thanks Diva for waiting on me.......

No worries..

FYI for future reference, the error message number is the hint that will tell you if it's a SQL error versus a PHP error.. 1064 is a mySQL syntax error message. And despite the long winded nature of error messages, the first part of most error messages really do tell you a good deal about an error and it's source: 1064:You have an error in your SQL syntax;

Additional reading on this (in case you're interested):
https://www.google.com/search?q=mySQ...ient=firefox-a

http://dev.mysql.com/doc/refman/5.5/...es-server.html)

In the meantime, and MOST importantly you need to use the updated SQL script I posted for your update submission.. The one lat9 posted still contains code that could inadvertently delete records from the configuration table.. You can simply resubmit it you do not have to wait for the submission you posted today to be approved. Simply reply to the e-mail you got acknowledging your submission and let the admins know you will be submitting a replacement update.. Then re-submit it with the SQL I posted..

Specifically this part is problematic:

#SET @t4=0;
SELECT (@t4:=configuration_group_id) as t4
FROM configuration_group
WHERE configuration_group_title= 'Testimonials Manager';

(The Zen Cart v1.5 threads on updating mods cover this and WHY it should NOT be included in SQL scripts for add-ons. If you recall I took this same kind of code out of the SQL for the Rewards points SQL)

[lat9]

No worries..
...
Specifically this part is problematic:

#SET @t4=0;
SELECT (@t4:=configuration_group_id) as t4
FROM configuration_group
WHERE configuration_group_title= 'Testimonials Manager';

(The Zen Cart v1.5 threads on updating mods cover this and WHY it should NOT be included in SQL scripts for add-ons. If you recall I took this same kind of code out of the SQL for the Rewards points SQL)

If you'll notice, I had turned the problematic SET statements into comments ... thus also removing the problem.

[countrycharm]

No worries..

FYI for future reference, the error message number is the hint that will tell you if it's a SQL error versus a PHP error.. 1064 is a mySQL syntax error message. And despite the long winded nature of error messages, the first part of most error messages really do tell you a good deal about an error and it's source: 1064:You have an error in your SQL syntax;

Additional reading on this (in case you're interested):
https://www.google.com/search?q=mySQ...ient=firefox-a

http://dev.mysql.com/doc/refman/5.5/...es-server.html)

In the meantime, and MOST importantly you need to use the updated SQL script I posted for your update submission.. The one lat9 posted still contains code that could inadvertently delete records from the configuration table.. You can simply resubmit it you do not have to wait for the submission you posted today to be approved. Simply reply to the e-mail you got acknowledging your submission and let the admins know you will be submitting a replacement update.. Then re-submit it with the SQL I posted..

Specifically this part is problematic:

#SET @t4=0;
SELECT (@t4:=configuration_group_id) as t4
FROM configuration_group
WHERE configuration_group_title= 'Testimonials Manager';

(The Zen Cart v1.5 threads on updating mods cover this and WHY it should NOT be included in SQL scripts for add-ons. If you recall I took this same kind of code out of the SQL for the Rewards points SQL)

Hi Diva I basically redid sql statement like you said in the first place. The only thing I didn't do was take out the engine part. Thank You for pointing that out. I did some reserch on MyISAM vs InnoDB and found out With the release of MySQL 5.5, InnoDB has become the default storage engine so thank you again. This will maybe cause others not to have the error when installing this module.
And thanks for the other 2 links for the sql errors.

If you'll notice, I had turned the problematic SET statements into comments ... thus also removing the problem.

Yes you did, but I we decided to remove them just in case others might not have understood what that was for.

[countrycharm]

Hi Diva I basically redid sql statement like you said in the first place. The only thing I didn't do was take out the engine part. Thank You for pointing that out. I did some reserch on MyISAM vs InnoDB and found out With the release of MySQL 5.5, InnoDB has become the default storage engine so thank you again. This will maybe cause others not to have the error when installing this module.
And thanks for the other 2 links for the sql errors.



Yes you did, but I we decided to remove them just in case others might not have understood what that was for.

Has been updated and submitted to the downloads. Thanks again Diva, lat9 for the help you provided.

[DivaVocals]

I did some reserch on MyISAM vs InnoDB and found out With the release of MySQL 5.5, InnoDB has become the default storage engine so thank you again. This will maybe cause others not to have the error when installing this module.

You didn't specify InnoDB in your SQL did you?? It would be better to take out the engine altogether than to include one that may not be supported by the shopowner's host.. Not including an engine won't harm anything as the default will be used. Unless there is a reason why a specific DB engine is needed, not including it in the create table statement won't affect the add-on.. (You can take a look at other add-ons and see that it's not always included in create table statements)

Has been updated and submitted to the downloads. Thanks again Diva, lat9 for the help you provided.

You're welcome..

[countrycharm]

You didn't specify InnoDB in your SQL did you?? It would be better to take out the engine altogether than to include one that may not be supported by the shopowner's host.. Not including an engine won't harm anything as the default will be used. Unless there is a reason why a specific DB engine is needed, not including it in the create table statement won't affect the add-on.. (You can take a look at other add-ons and see that it's not always included in create table statements)

You're welcome..

Na I didn't include and engine at all.
I was just letting you know what I read and learned.....

[DivaVocals]

Na I didn't include and engine at all.
I was just letting you know what I read and learned.....

Cool!!

[lat9]

I've got a multilingual site and enabled the "Display All Languages" in the Testimonial Manager admin section (TESTIMONIALS_DISPLAY_ALL_LANGUAGES is the database key). I had a couple of test testimonials in English and switched to a Spanish display ... and none were displayed. Turns out that the database key (above) isn't used at all.

Here's an updated version of /includes/modules/pages/display_all_testimonials/header_php.php that corrects the problem:

<?php
/**
 * Testimonials Manager
 *
 * @package Template System
 * @copyright 2007 Clyde Jones
  * @copyright Portions Copyright 2003-2007 Zen Cart Development Team
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: Testimonials_Manager.php v1.5.2 4-16-2010 Clyde Jones $
 */
 
  require(DIR_WS_MODULES . 'require_languages.php');
  $breadcrumb->add(NAVBAR_TITLE);
  
  $which_languages = (TESTIMONIALS_DISPLAY_ALL_LANGUAGES == 'true') ? '' : (" and language_id = '" . (int)$_SESSION['languages_id'] . "'");
  
  $testimonials_query_raw = "select * from " . TABLE_TESTIMONIALS_MANAGER . " where status = 1" . $which_languages . " order by date_added DESC, testimonials_title";

  $testimonials_split = new splitPageResults($testimonials_query_raw, MAX_DISPLAY_TESTIMONIALS_MANAGER_ALL_TESTIMONIALS);
//EOF