Results 1 to 2 of 2
  1. #1
    Join Date
    Mar 2004
    Location
    Calgary, Alberta
    Posts
    290
    Plugin Contributions
    1

    Default [Done v1.3.8] EZ Page problem

    Having never used this feature until today, its hard for me to know if it existed as problem in 1.3.6, but if I do a page with a setting of OPEN NEW PAGE... then go and click on the link, I am wondering about the additional parameter....

    <li><a href="http://www.totalgarage.ca/products/index.php?main_page=pricelist?target=&amp;quot;_blank" target="_blank">Price List</a></li>
    <li><a href="http://www.totalgarage.ca/products/rss2.php?target=&amp;quot;_blank" target="_blank">RSS2 Feed</a></li>

    the target= is not always accepted happily by other pages. I am wondering if this can be set as optional.

  2. #2
    Join Date
    Jan 2004
    Posts
    66,450
    Plugin Contributions
    81

    Default Re: EZ Page problem

    That's a bug.
    /includes/functions/functions_ezpages.php
    line 41 says:
    Code:
                                  ($ez_pages_alturl=='' ? '' : zen_href_link($ez_pages_alturl, 'target="_blank', ($ez_pages_is_ssl=='0' ? 'NONSSL' : 'SSL'), true, true, true));
    remove the 'target="_blank', like this:
    Code:
                                  ($ez_pages_alturl=='' ? '' : zen_href_link($ez_pages_alturl, '', ($ez_pages_is_ssl=='0' ? 'NONSSL' : 'SSL'), true, true, true));
    The proper rendering for target=_blank is done later on line 55 (which doesn't need any changes):
    Code:
          $ez_link .= ($ez_pages_open_new_window == '1' ? '" target="_blank' : '');
    Do the same for these files, removing the target="_blank from the zen_href_link function calls, but leaving it later in the file where the link is rendered.
    [FONT="Courier New"]/includes/modules/ezpages_bar_footer.php
    /includes/modules/ezpages_bar_header.php
    /includes/sideboxes/ezpages.php[/FONT]
    .
    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. [Done v1.5] Mandatory text attribute -problem
    By tsrplatelayer in forum Bug Reports
    Replies: 7
    Last Post: 16 Aug 2011, 02:50 AM
  2. [Done v1.5.0] coupon display problem
    By ethical in forum Bug Reports
    Replies: 4
    Last Post: 3 Dec 2010, 08:38 PM
  3. Replies: 26
    Last Post: 13 Aug 2008, 05:05 PM
  4. [Done v1.3.8] Problem w/ USPS shipping
    By theehman in forum Bug Reports
    Replies: 1
    Last Post: 15 Jan 2008, 10:41 PM
  5. [DONE] Checkout_shipping problem -- user error
    By topendspeed in forum Bug Reports
    Replies: 9
    Last Post: 8 Jun 2006, 05:02 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg