Embedded Javascript inside an EZ-Page

[dcarrith]

I discovered what I consider to be a bug in the EZ-Pages HTML editor (it's not a problem when in text-only mode). Basically, I came across the bug after embedding javascript into the text view (ie. text mode) of the HTML editor (ie. the text mode after clicking the Toggle HTML Mode button).

I've traced the problem down to the following section of code in the zen-cart/editors/htmlarea/htmlarea.js file.

Lines 1,951-1,961 of htmlarea.js:

// performs HTML encoding of some given string
HTMLArea.htmlEncode = function(str) {
// we don't need regexp for that, but.. so be it for now.
str = str.replace(/&/ig, "&");
str = str.replace(/</ig, "&lt;");
str = str.replace(/>/ig, "&gt;");
str = str.replace(/\x22/ig, "&quot;");
// \x22 means '"' -- we use hex reprezentation so that we don't disturb
// JS compressors (well, at least mine fails.. ;)
return str;
};

That section of code was causing me quite a headache the other day.

I embedded the following javascript code into the top of one of my EZ-Pages:


<script type="text/javascript" language="javascript"><!--

function openWindow(URL, windowName, windowFeatures) {
newWindow=window.open(URL, windowName, windowFeatures);
}

function closeWindow(windowName) {
newwindow.close(windowName);
}

function addWindowFeatures(w, h) {
var height=h;
var width=w;
var toolbar=0;
var status=0;
var menubar=0;
var directories=0;
var location=0;
var resizable=0;
var scrollbars=0;
var left=(screen.width - width)/2;
var top=(screen.availHeight - height)/2;
var features='left=' + left + ',' + 'top=' + top + ',' + 'toolbar=' + toolbar + ',' + 'status=' + status + ',' + 'menubar=' + menubar + ',' + 'directories=' + directories + ',' + 'location=' + location + ',' + 'resizable=' + resizable + ',' + 'scrollbars=' + scrollbars + ',' + 'height=' + height + ',' + 'width=' + width;
return features;
}

//--></script>


Lines 1954, 1955, and 1956 (the string replace of < > and &) was malforming my javascript. Specifically, as soon as I clicked the toggle HTML Mode button, it would transform the lead in and lead out portions of the javascript, ie. '<!--' and '//-->', into '&lt;!--' and '//--&gt;'. That, of course, broke the javascript portion of the page.

So, I guess my question is this:

What effect does commenting out lines 1954, 1955, and 1956 have on the functionality of the HTML editor? I have not noticed any ill effects. I suppose that I won't notice anything unless I try to use the <, >, or & signs as characters on an html page.

Has anyone else tried this hack?

// performs HTML encoding of some given string
HTMLArea.htmlEncode = function(str) {
// we don't need regexp for that, but.. so be it for now.
//str = str.replace(/&/ig, "&amp;");
//str = str.replace(/</ig, "&lt;");
//str = str.replace(/>/ig, "&gt;");
str = str.replace(/\x22/ig, "&quot;");
// \x22 means '"' -- we use hex reprezentation so that we don't disturb
// JS compressors (well, at least mine fails.. ;)
return str;
};

Thanks!

[dcarrith]

I forgot to mention the issue with line 1954 of htmlarea.js. If I toggled back and forth between HTML Mode and Text Mode, it would cause the following issue:

First, because of lines 1955 and 1956, the
<!--
and
//-->

would get transformed into

&lt;!--
and
//--&gt;

Then, if I toggled back and forth again, the problem caused by line 1954 kicks in...the

&lt;!--
and
//--&gt;

would get transformed into

&amp;lt;!--
and
//--&amp;gt;


Then, if I toggled back and forth again, the

&amp;lt;!--
and
//--&amp;gt;

would get transformed into

&amp;amp;lt;!--
and
//--&amp;amp;gt;


Then, if I toggled back and forth again, the

&amp;amp;lt;!--
and
//--&amp;amp;gt;

would get transformed into

&amp;amp;amp;lt;!--
and
//--&amp;amp;amp;gt;

and so on.


So...commenting out those 3 lines is the work-around. That is, as long as you don't need to use the <, >, or & in the html page.

Cheers!

[Merlinpa1969]

Im not 100% sure, and Dr Bytl will be the one to give the best answer but I think you are supposed to put your java in a special folder.

and then just refer to it

[mrmeech]

Has anyone figured this out yet? I am in need of putting a link to a JS file in the header of an EZ-Page but do not want to include it site-wide. I've been entirely unable to figure this out through existing forms or anything in the docs folder..

DrByte? Anyone?


Thanks in advance-

[DrByte]

Just follow the override system explained here:
http://www.zen-cart.com/wiki/index.p...s_-_Javascript

New file: /includes/modules/pages/page/jscript_my_fun_jscript_code.php

<?php
if ($ezpage_id == 32) {
?>
// javascript for ezpage 32 goes here
<?php
} 
?>
// javascript for all ezpages goes here