I had reason this evening to be looking closely at the upload class file in admin and noticed a minor (pretty much inconsequential) error in message stack use.
At lines 171-175 of admin/includes/classes/upload.php, this code
Code:
          if ($this->message_location == 'direct') {
            $messageStack->add_session(sprintf(ERROR_DESTINATION_NOT_WRITEABLE, $this->destination), 'error');
          } else {
            $messageStack->add_session(sprintf(ERROR_DESTINATION_NOT_WRITEABLE, $this->destination), 'error');
          }
should read
Code:
          if ($this->message_location == 'direct') {
            $messageStack->add(sprintf(ERROR_DESTINATION_NOT_WRITEABLE, $this->destination), 'error');
          } else {
            $messageStack->add_session(sprintf(ERROR_DESTINATION_NOT_WRITEABLE, $this->destination), 'error');
          }
That file hasn't been modified since Sep 2005, so it's obviously not a major problem...