Help? (Invalid Parameter)?

[andrabr]

FOUND IT!!!! Fixed it (maybe).

but first, the requested data:

1 Who do you host with? goDaddy

2 unix or windows? Linux

3 what version of php? 5.0.4

4 clean install or upgrade? Clean install + latest patch.

5 are you using IPN or PayPal Express? when receiving this error? Paypal Express

6 Do you have 1 or both installed? Meaning, if not using one or the other do you have the other one installed? - only Paypal Express

7 is there a pattern or specific country that this happens with? Definitely US, not certain of others.

8 Live or Sandbox? Live


Being impatient i started looking at the code. In paypalwpp.php in function ec_step2_finish around line 1770 there is a nice check

if (!isset($paypal_ec_payer_info['ship_country_code']))

Well, it just happens that it IS set to '' (nothing).

Changing that line to:
if ((!isset($paypal_ec_payer_info['ship_country_code'])) OR ($paypal_ec_payer_info['ship_country_code']=='')) {$paypal_ec_payer_info['ship_country_code'] = $country1->fields['countries_iso_code_2']; $_SESSION['paypal_ec_payer_info']['ship_country_code']= $country1->fields['countries_iso_code_2'];}

allowed me to successfully complete a transaction.

Now, I do NOT know PHP, and I do NOT understand Zen Cart guts well enough to say that this is IT. The problem is probably somewhere upstream and the fix is more elegant.

I can easily imagine though that PAyPal changed their protocol to return an empty but defined value instead of returning none, thus quietly throwing a wrench into Zen Cart machinery.

I can't wait what the PROs think!

~Andrey

[CafePrima]

FOUND IT!!!! Fixed it (maybe).

I can't wait what the PROs think!

~Andrey

I can't tell you what the PROs will think but I will tell you that *I* could kiss you right now! Thank you thank you!

I get a really long lag after the paypal screen when I'm back on my site and click "confirm" but the order DOES go through and I get both the payment and the order confirm. So slow is better than not at all and I'll take it!

THANK YOU!

[Rememberthemoments]

Ohh! Off to try it now!!

There are a few paypalwpp.php files. Were is it locater?

includes/modules/payment/paypalwpp.php

or

includes/lanugage/english/modules/payment/paypalwpp.php

[CafePrima]

includes/modules/payment/paypalwpp.php

I made the fix in that file and have been able to successfully (but slowly) check out

[Rememberthemoments]

Add me to the list of people that want to kiss you!

It works seemlessly for me (knock on wood) at the moment! Not even any lag! LOVE IT!

Thank you! Thank you ! THANK YOU!