Using include in product description

[jeking]

My mistake, it is 1.2.7 and the upgrade in on my list :-)

I found the file in:
/includes/modules/pages/product_info/main_template_vars_attributes.php

I then found this following code but am at a complete loss as to how to change it to display only if text exists. I think that's a bit beyond my skills. Any suggestions or references to figure it out?

// Read Only - just for display purposes

if ($products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_READONLY) {

// $tmp_html .= '<input type="hidden" name ="id[' . $products_options_names->fields['products_options_id'] . ']"' . '" value="' . stripslashes($products_options->fields['products_options_values_name']) . ' SELECTED' . '" /> ' . $products_options->fields['products_options_values_name'];

$tmp_html .= $products_options_details . '<br />';

} else {

$zv_display_select_option ++;

}

[Ajeh]

If this is blank then you don't want to show it:
$products_options->fields['products_options_values_name']

[jeking]

You've been so helpful, but you lost me. Don't I need some sort of if/then statement? If the field is blank, then do not display the attribute. If it contains text, then display the attribrute.

I'm not following where your statement goes, if it should replace something...

[gjh42]

You could add a test for $products_options->fields['products_options_values_name'] being not blank to the if statement:

// Read Only - just for display purposes

if (($products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_READONLY) and ($products_options->fields['products_options_values_name'] != ' ')) {

// $tmp_html .= '<input type="hidden" name ="id[' . $products_options_names->fields['products_options_id'] . ']"' . '" value="' . stripslashes($products_options->fields['products_options_values_name']) . ' SELECTED' . '" /> ' . $products_options->fields['products_options_values_name'];

$tmp_html .= $products_options_details . '<br />';

} else {

$zv_display_select_option ++;

} 

I am not positive I have phrased it correctly - Linda will probably be able to give a more elegant statement.

I wonder if the // (comment mark) should be removed from the $tmp_html line? That disables the main code in this snippet.

[jeking]

Thanks for the effort, but it still shows up when the field is blank. The comment mark was/is there in the original code.

[Ajeh]

$products_options->fields['products_options_values_name'] != ' ' is not the same as:
$products_options->fields['products_options_values_name'] != ''

You want to test when that field is blank and when blank show nothing ...

[jeking]

I'm understanding the logic but not the coding. This is what I have understood, but it's not working right.

// Read Only - just for display purposes

if (($products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_READONLY) and ($products_options->fields['products_options_values_name'] != '')) {

$tmp_html .= $products_options_details . '<br />';

} else {

$zv_display_select_option ++;

}

What did I misunderstand?

[Ajeh]

If you look for the constant, I believe there are 2 places to reference in that file ...

[jeking]

Linda,

What is the constant you're referring to? Is it PRODUCTS_OPTIONS_TYPE_READONLY?

If so, I did find two other references but I don't know what to do with them.

[Ajeh]

The constant is the:
PRODUCTS_OPTIONS_TYPE_READONLY

I forget off hand the code in 1.2.7 but it is similar ...

In the first location I change the code to:

                  // Read Only - just for display purposes
                  if ($products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_READONLY) {
                    //            $tmp_html .= '<input type="hidden" name ="id[' . $products_options_names->fields['products_options_id'] . ']"' . '" value="' . stripslashes($products_options->fields['products_options_values_name']) . ' SELECTED' . '" />  ' . $products_options->fields['products_options_values_name'];
                    if (empty($products_options_details)) {
                      $tmp_html = '';
                    } else {
                      $tmp_html .= $products_options_details . '<br />';
                    }
                  } else {
                    $zv_display_select_option ++;
                  } 

In the next location I change the code:

                  // READONLY
                  case ($products_options_names->fields['products_options_type'] == PRODUCTS_OPTIONS_TYPE_READONLY):
                  if (empty($tmp_html)) {
                  } else {
                  $options_name[] = $products_options_names->fields['products_options_name'];
                  $options_menu[] = $tmp_html . "\n";
                  $options_comment[] = $products_options_names->fields['products_options_comment'];
                  $options_comment_position[] = ($products_options_names->fields['products_options_comment_position'] == '1' ? '1' : '0');
                  }
                  break;