phpBB User Creation

[Jadnet]

As far as i can tell, there was a bug in the includes/classes/class.phpbb.php file on line 189 the code is:

$sql = "insert into " . $this->phpBB['users_table'] . "
                (user_id, username, user_password, user_email, user_regdate)
                values
                ('" . (int)$user_id . "', '" . $nick . "', '" . md5($password) . "', '" . $email_address . "', '" . time() ."')"; 

The problem is the "(int)" in the SQL

My fix code is:

$sql = "insert into " . $this->phpBB['users_table'] . "
                (user_id, username, user_password, user_email, user_regdate)
                values
                ('" . $user_id . "', '" . $nick . "', '" . md5($password) . "', '" . $email_address . "', '" . time() ."')"; 

Without this change, the user was not created in my phpBB forums when a user creates their user account in zen-cart. After making this code change it works perfectly for me...

Jadnet

[TheOracle]

In that file,

find:

$user_id = ($phpbb_users->fields['total'] + 1); 

replace with:

$user_id = (isset($phpbb_users->fields['total']) && is_numeric($phpbb_users->fields['total'])) ? $phpbb_users->fields['total'] + 1 : 0; 

This should work as expected with the int.