Additional Customers Fields

[rbepple]

Here is my /catalog/includes/languages/english/extra_definitions/additional_customers_fields_create_account.php
I am still getting multiple fields on my customer registration page. I only create sales_rep in my database.

<?php
//----------------------------------------------------------------------------------------
//--- Additional customers fields MOD v2.1 -----------------------------------------------
//----------------------------------------------------------------------------------------
// --- Coded by TheOracle on June 16 2007. -----------------------------------------------
// --- Support: http://www.zen-cart.com/forum --------------------------------------------
// --- Designed for Zen-Cart v1.3x versions ----------------------------------------------
//----------------------------------------------------------------------------------------
// If you like this MOD, please send a donation to: scoutch###################### . ------------------
//----------------------------------------------------------------------------------------

// Defines the additional customers fields title in order to show in HTML forms.
define('ENTRY_ADDITIONAL_CUSTOMERS_FIELDS_TITLE', 'Sales Representative');
define('HEADING_TITLE', '');

// Defines the hobbies title name for the additional customers fields.
$additional_customers_fields_form_create_account_textarea_title['customers_hobbies'] = array('Hobbies: ');

// Defines the customers sales representative for the additional customers fields.
$additional_customers_fields_form_create_account_pull_down_title['sales_rep'] = array('Sales Representative: ');
$additional_customers_fields_form_create_account_pull_down_content['sales_rep'] = array("None", "Mel Kimmel", "Boyd Thomas");

// Defines the customers cellphone number for the additional customers fields.
$additional_customers_fields_form_create_account_input_title['customers_cellphone'] = array('Cellphone: ');

// defines the customers age (radio button version):
$additional_customers_fields_form_create_account_radio_title['customers_pod'] = array('POD: ');
$additional_customers_fields_form_create_account_radio_content['customers_pod'] = array(1, 2, 3, 4, 5);
?>

let me know if you need other files.

[TheOracle]

1 / 2 - and from your template files -

beginning from:

// Additional customers fields 

to:

// End of additional customers fields 

?

[TheOracle]

Just downloaded this mod from Oracle's site this morning and am working on installing it. I noticed in the header_php.php file, there is some code that is not flagged as being part of the mod. However, should it be?

I don't understand why some questions are being adressed indirectly but, as I recall, I wrote this MOD and I offer support for it. If you do experience some problems with the MOD, please address it to me. As for the current problem you're experiencing, I have posted an update yesterday on this matter. Simply download the latest version from my site as you should see the identified paragraph where you must add the entries from your header_php.php file.

[creative]

I decided just to follow the lines that were flagged and...um...wow. I'm one of the "Fatal Error" recipients.

After following the installation readme, I am stuck at Admin>Customers>Add Customer Fields. I receive this error:

Fatal error: Call to undefined function: get_table_fields() in /Library/Apache2/htdocs/ddi/ddiadmin/additional_customers_fields.php on line 196

PHP Version 4.3.9
MySQL 4.0.21
Zen Cart 1.3.7

Any help would be much appreciated.

Thank you!

[TheOracle]

Easy problem. You did not followed instructions regarding the comparaison of your includes/classes/db/mysql/query_factory.php file. Additional methods needs to be added. Please follow my installation instruction file carefully (no need to speed things up).

[creative]

Oracle,

I didn't realize I had to address each post directly to you because I had assumed any post in here WAS made to you. As mentioned in my post, I downloaded the mod from your site this morning. However, I must be overlooking something obvious so I posted my question.

[TheOracle]

Oracle,

I didn't realize I had to address each post directly to you because I had assumed any post in here WAS made to you. As mentioned in my post, I downloaded the mod from your site this morning. However, I must be overlooking something obvious so I posted my question.

I believe the very first post on this topic mentions it as is ...

[Blitz49]

This has already been reported before as I have asked for details and no one did replied to it. In order to make the proper corrections (as I can assume this could be a bug), please post all the details by telling me 'what does it make so that would happend precisely and not just by reporting the problem.

So, again, what have you done so that these multiple fields appear twice ?
19th June 2007 12:59 PM

I did exactly what i did on my test server, and works fine on test server, but on live shop it duplicates the field. I checked the create_account.php in \includes\modules\your_template\ multiple times to see what is wrong, but I can't figure out why it is doing that. Cause that file is untouched, so I just uploaded the file that you have created, plus I checked it with winmerge and there is little difference expect for the code that you put in. Guess for now I will mess around with it to see if I can fix both problems, or just wait till you have a fix.

Thanks for everything.

[djjoshuad]

TheOracle:

First off, thanks a bunch for the effort involved with this project. I apologize if my issue has already been addressed, but I have searched to no avail.

I have found several bugs that I think deserve attention. First, I think you need to look into default values when creating varchar fields. Second, your code allows the user to create a field with a given name more than once. I know you forbid us doing that... but it is still possible. It is likely that a user will encounter this when an error is created on their first attempt, as in the varchar field issue I mentioned above.

example:

1.) user attempts to create field name "test_1" of type "varchar" length "200" default "blah"
2.) php code creates an entry in the customers_additional table with field_id 1, field_name "test_1" and field_status 1
3.) mysql generates error: because blah is not a valid default value for a varchar field - TABLE_CUSTOMERS is not updated
4.) user tries again, this time with no default and:
5.) php code creates an entry in the customers_additional table with field_id 2, field_name "test_1" and field_status 1
6.) php code (successfully) alters table TABLE_CUSTOMERS to include the new test_1 field

now, if the user tries to delete his mistake, the code removes the field from TABLE_CUSTOMERS first, then removes the row from customers_additional. we are left with a row in customers_additional that has no associated field in TABLE_CUSTOMERS. try and delete that one... the code tries to alter TABLE_CUSTOMERS first and fails because that field has already been removed. Now there's no way to remove the row from customers_additional without bypassing your interface.

the other bugs I've found are related to header information being re-sent after ZC has already sent them... not apparent to the front end, but it registers on the httpd logs:

[client <ip address>] PHP Warning: Cannot modify header information - headers already sent by (output started at <site_base>/zencart/admin/additional_customers_fields.php:25) in <site_base>/zencart/admin/includes/functions/general.php on line 34, referer: http://zencart.mydomain.com/admin/ad...stomers_fields

anyway, thanks again for the hard work. This is certainly more convenient than the old way of adding fields, and I think with some more work it could be useable by your average joe. nicely done!

[TheOracle]

but on live shop it duplicates the field.

Again - the activity of what causes this ?

1.) user attempts to create field name "test_1" of type "varchar" length "200" default "blah"

Try varchar 255. That's what I always do for string text (example: for customers email address).

2.) php code creates an entry in the customers_additional table with field_id 1, field_name "test_1" and field_status 1

Correct. That means - field_id + 1, field name: your field name, field_status: deactivated (set by default for testing purposes before actually putting this field live).

5.) php code creates an entry in the customers_additional table with field_id 2, field_name "test_1" and field_status 1

Can you actually see identical test_1 names under your TABLE_ADDITIONAL_CUSTOMERS + your TABLE_CUSTOMERS table in your phpmyadmin ? If so, how many ? There should only be one (unique) for a listed name and a physical name.

php code (successfully) alters table TABLE_CUSTOMERS to include the new test_1 field

Good to hear, at least, the import session is importing all your additional unlisted fields into the TABLE_ADDITIONAL_CUSTOMERS table as expected. As for your analysis, I think it's the best one I had so far. Now, all that is left is the three last posts I'm still expecting reports on the precise way (and detailed) the way that duplicated fields are happening. If you can confirm this one as well, I will look into it.

Now, which PHP, mySQL and Zen-Cart version are you using ?

the other bugs I've found are related to header information being re-sent after ZC has already sent them... not apparent to the front end, but it registers on the httpd logs:

[client <ip address>] PHP Warning: Cannot modify header information - headers already sent by (output started at <site_base>/zencart/admin/additional_customers_fields.php:25) in <site_base>/zencart/admin/includes/functions/general.php on line 34, referer: http://zencart.mydomain.com/admin/ad...stomers_fields

If you searched for it ... I find it hard to believe a little bit since it's everywhere in the first posts of this topic. This has already been issued that this is a zen_redirect problem, built by one of the DEV team, as I have posted a patch on one of the posts under this topic. Since then, no problems were reported. Just need to search a little bit further (even though it is understandable for the mount of replies involved on this topic).

[client <ip address>] PHP Warning: Cannot modify header information - headers already sent by (output started at <site_base>/zencart/admin/additional_customers_fields.php:25) in <site_base>/zencart/admin/includes/functions/general.php on line 34, referer: http://zencart.mydomain.com/admin/ad...stomers_fields

If you refresh the page when this message appears, what does it say on the top of the header page ?

I did exactly what i did on my test server, and works fine on test server, but on live shop it duplicates the field. I checked the create_account.php in \includes\modules\your_template\ multiple times to see what is wrong, but I can't figure out why it is doing that. Cause that file is untouched, so I just uploaded the file that you have created, plus I checked it with winmerge and there is little difference expect for the code that you put in. Guess for now I will mess around with it to see if I can fix both problems, or just wait till you have a fix.

The problem relies on my additional created functions actually - NOT on the modules. However, I'm still waiting for other reports regarding the duplicated fields. A patch (or upgrade version) will be released from that point.