Text email not displaying custom payment footer

[dbrewster]

Howdies!

I have a custom purchase order payment module, and I have configured the email order to display the additional data: account name, account number, PO number. It is working for HTML but not working for text emails.

In HTML the email looks like this:

Payment Method
Purchase Order with the following information:
Account name: test acct name
Account number: test acct number
PO Number: test order number

in a text email, it looks like this:

[FONT=Courier New]Payment Method
------------------------------------------------------
Purchase Order

with the following information:
Account name: %s
Account number: %s
PO Number: %s[/FONT]

I was unable to use Dr. Byte's updated email footer detail, it just wasn't printing the info in the HTML email. I had once had a discussion with Dr. Byte about this, and he had proposed the following code, but it did not work:

$html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']]) && $GLOBALS[$payment_class]->email_footer != '') ? nl2br($GLOBALS[$payment_class]->email_footer) : $this->info['cc_type']; 

This is what's working for HTML email:

includes/languages/english/modules/payment/po.php

 define('MODULE_PAYMENT_PO_TEXT_EMAIL_FOOTER', 'with the following information:<br>
 Account name:&nbsp; %s<br>
 Account number:&nbsp; %s<br>
  PO Number:&nbsp; %s'); 

includes/classes/order.php around line 992

// This is for purchaseorder module email info
    $html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']]) ? sprintf($GLOBALS[$payment_class]->email_footer, $this->info['account_name'], $this->info['account_number'], $this->info['po_number']) : ' '); 

I guess the $html_msg means that this is excluded from a TEXT email. I'm wondering how to deliver the info to a text email?

thanks!!! I love you guys.

---Diana

[TheOracle]

I guess the $html_msg means that this is excluded from a TEXT email. I'm wondering how to deliver the info to a text email?

The $html_msg array is for the HTML emails. The $email_order would the variable you would look for. The $html_msg['TEXT'] is the global usage for text emails and the $html_msg['HTML'] is for the global usage of the HTML emails.

[TheOracle]

Additionally to the above, there's also a correction posted by DrByte from this topic:

http://www.zen-cart.com/forum/showthread.php?t=54819

[dbrewster]

Thanks for reply, Oracle!

I did use Dr. Byte's fixed version, that didn't work for me at all.

I've tried adding this to includes/classes/order.php

      $email_order .= EMAIL_TEXT_PAYMENT_METHOD . "\n" .
      $email_order .= (is_object($GLOBALS[$_SESSION['payment']]) ? sprintf($GLOBALS[$payment_class]->email_footer, $this->info['account_name'], $this->info['account_number'], $this->info['po_number']) : ' ');
      EMAIL_SEPARATOR . "\n";
      $email_order .= PAYMENT_METHOD_GV . "\n\n"; 

and made this change to includes/languages/english/modules/payment/po.php

 define('MODULE_PAYMENT_PO_TEXT_EMAIL_FOOTER', 'with the following information:' . "\n" .
 'Account name: ' . $this->info['account_name'] . "\n" .
 'Account number: ' . $this->info['account_number'] . "\n" .
 'PO Number: ' . $this->info['po_number']); 

The %s was not being interpreted for the text email, although it was working for HTML email. This is, of course, not the right way to handle a define, but I just don't know how to get the info out there.

The one "good" result is that the text email and the HTML email look the same now:

Payment Method
------------------------------------------------------
Purchase Order

with the following information:
Account name:
Account number:
PO Number:

the problem is how to push the data out to the email.

It is showing correctly in the invoice and checkout screens.

Ideas? (I am unfortunately not a programmer, I can write a little code, but definitely not an accomplished programmer in any language.)

[TheOracle]

In that case, I'd call this a bug.

[DrByte]

Diana, can you post a zip of your custom po module and its language file?

[dbrewster]

thanks, Dr. Byte!!!!

I'm including classes/order.php because it has some related modifications.

(I've included the % handling module for USPS too, in case you want to include that feature in a future release. Flat fee handling for a large order can be costly. Just ignore the shipping bits if you're not interested.)

---Diana

[TheOracle]

Two things I noticed:

1 -

$this->email_footer = MODULE_PAYMENT_PO_TEXT_EMAIL_FOOTER; 

seems to be the one line using that definition - not too sure why ...

2 -

global $HTTP_POST_VARS; 

I wonder why this is being used since Zen-Cart does not use VARS anywhere ...

[dbrewster]

Oracle,

Since I'm just a PHP hack, could you please explain your comments to me?

what is the problem with one line using the PO footer definition? (was that in order.php?)

what's the problem with

global $HTTP_POST_VARS; 

?

As you can see, the PO module is built on an old OSCommerce module. It does work, except for the email footer. The email footer works in HTML email, but not in text email.

---Diana

[DrByte]

I'm guessing that this might take care of it:

In the po.php payment module, around line 98, you have the before_process() function. Try inserting this line, as shown:

    function before_process() {
      $this->email_footer = sprintf($this->email_footer, $_POST['account_name'], $_POST['account_number'], $_POST['po_number']);
      return false;
    }

And then make sure your order.php class file has these two lines set back to the defaults, like this:

      $email_order .= ($GLOBALS[$payment_class]->email_footer) ? $GLOBALS[$payment_class]->email_footer . "\n\n" : '';

and this:

    $html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']]) && $GLOBALS[$payment_class]->email_footer != '') ? nl2br($GLOBALS[$payment_class]->email_footer) : $this->info['cc_type'];

I also suggest that you convert the <br> tags in your language file to \n carriage returns so that your text-only emails show up properly:

 define('MODULE_PAYMENT_PO_TEXT_EMAIL_FOOTER', 'with the following information: ' . "\n" . ' Account name:  %s ' . "\n" . ' Account number:  %s' . "\n" . ' PO Number:  %s' . "\n");