[Done v1.3.8] Products_Price_Manager update bug Incorrect Integer

[lynx]

Hi All,

Maybe you can help - I'm running 1.3.7 on my test IIS XP server & I've noticed that in the admin panel the product price manager encounters an SQL error when trying to update to the database.

Specifically the error being displayed is:

1366 Incorrect integer value: '' for column 'products_discount_type' at row 1
in:
[update zen_products set products_price='5.0000', products_tax_class_id='0', products_date_available=null, products_last_modified=now(), products_status='1', products_quantity_order_min='1', products_quantity_order_units='1', products_quantity_order_max='0', product_is_free='0', product_is_call='0', products_quantity_mixed='1', products_priced_by_attribute='0', products_discount_type='', products_discount_type_from='', products_price_sorter='0', master_categories_id='2', products_mixed_discount_quantity='' where products_id='1']
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.


From what i can see there no values being supplied for products_discount_type and product_discount_type_from which on the products table null is not allowed for these fields

On my browser window there are no fields called products discount type or product discount type from.

Is anybody else having this problem?

Thanks

[DrByte]

What version of MySQL are you using?

What exact updates were you making when this occurred?

Do you have any mods/customizations installed to your site?

(FYI --- '' and null are not the same)

[DrByte]

On my browser window there are no fields called products discount type or product discount type from.

These would be pulldown menus, only visible if you're adding quantity discounts.

[lynx]

DrByte - I am running MySQL 5.0.41 community

What exact updates were you making when this occurred?

One and then None - it errors on both - First time I was trying to update the special price for the item - I went into edit mode then typed in the new special price & clicked update and got the error.

So I then tried just going into prod price manager and go edit then go update without doing anything & I still get the error.

Do you have any mods/customizations installed to your site?

Yes

I have setup overwrite files for english.php for Australian locale and dd/mm/yyyy date formating - instructions obtained from forum posts.

Add customers from Admin mod

Time Zone Offset 1.3.7 by Gilby mod

Online Group Pricing mod merged into my existing 1.3.7 overwrite files to retain existing mods.

(I'm fairly sure that I was having the problem before Online Group Pricing)

Thanks for your help

-Dave

[DrByte]

/admin/products_price_manager.php
around line 130, you have:

            products_discount_type='" . zen_db_prepare_input($_POST['products_discount_type']) . "',
            products_discount_type_from='" . zen_db_prepare_input($_POST['products_discount_type_from']) . "',

add (int) in two places, as shown:

            products_discount_type='" . (int)zen_db_prepare_input($_POST['products_discount_type']) . "',
            products_discount_type_from='" . (int)zen_db_prepare_input($_POST['products_discount_type_from']) . "',

[lynx]

DrByte - Thanks - I also had to make that mod to the products_mixed_discount_quantity a few lines down so it is as follows:

products_mixed_discount_quantity='" . (int)zen_db_prepare_input($_POST['products_mixed_discount_quantity']) . "'

Problem solved! Thanks again!

-Dave