Javascript error - help please

[crazycucumber]

Hi , I have just written a simple bit of JavaScript to create Parcel tracking , but it is erroring when i insert it into Zen-cart

It works fine as a standalone html page on the same server , but as soon as I add the script into HTML_Header it errors on page with IE7 giving the error : Object Expected

<script language="javascript" type="text/javascript" runat="server">
function goTrackit2(){
            var target = 'http://www.interlinkexpress.com/service/tracking?consignment=' + document.getElementById('consignment2').value;
            if (document.getElementById('consignment2').value != "")
            {
                        document.form1.action = 'http://www.interlinkexpress.com/service/tracking?consignment=' + document.getElementById('consignment2').value;
                        document.form1.submit();
            }
            else
            {
                        alert("You didn't type in a tracking number");
            }
}

</script>

It still works fine , but with an IE error , its going to put people off my site.
It works fine with no errors in firefox ( i love FF ! )


Any guru's out there give me any clues ?

[DrByte]

Your var target= line is referencing an object that doesn't exist yet on the page.
Perhaps define it as an empty string, and then AFTER your IF statement, add the URL to it.

[crazycucumber]

Excellent thanks , that did the trick.

If anyone needs the code to put parcel tracking for interlink on their site , let me know.

[crazycucumber]

Actually NO ! it didnt do the trick !

The page loads fine the first time, as soon as you do a refresh it errors with the same "Object expected"

The code is now being called from a .js file from the Header_html.php

function goTrackit(){
            if (document.getElementById('consignment').value != "")
            {
              document.form1.action = 
'http://www.interlinkexpress.com/service/tracking?consignment=' + 
document.getElementById('consignment').value;
                        document.form1.submit();
            }
            else
            {
                       window.alert("You didn't type in a tracking number");
            }
}

It works standalone , but soon as zen gets hold of it , it errors , I have changed the code slightly again , so not using "target" anymore.

Any suggestions welcome again !

PM me if you want the URL as don't want google to spider it yet !

Cheers MARK

[DrByte]

You'll get "Object Expected" errors if the object doesn't exist as you described it in your code.

Thus, if there is no object with the ID of "consignment", or if that object has no value attribute (ie: isn't an input field that can contain a value) then any references to document.getElementById('consignment').value will fail.

Either your DOM description of the object is not correct or the object doesn't exist on the page you're loading.

[crazycucumber]

hmmm Im confused .

the element/object does exist and it is an input with a value attribute, which is confirmed when it works.

I have tried including the script so that it loads after the input element but that made no difference.

asside from that I can't see what else is wrong unless I have to force the javascript to load last to make sure all the elements exist already?

my side box code is simply :-

<form name="form1" method="post" target="_blank">
<input ID="consignment" name="consignment" type="text">
<input value="Track It" onclick="goTrackit();" type="button">
</form>

[dushyant]

i am having same problem if i run javascript code stand alone in html it works fine but after intigration into zencart it fails. i am calling a php file with javascript at zen central area. i have written three different kind of javascript codes for a double slider and all of them failed while intigration to zencart

[DrByte]

Where can this be seen in action?

[crazycucumber]

My Error can be seen at tapes-direct.co.uk then forward slash trial

Had to write it like that so it doesn't get spidered .

It doesnt error in FF just in I>E and only the Second time you run the page.

Cheers