Dynamic Price Updater

[mc12345678]

Thank you for looking into it. I really appreciate the time you've invested.

So, thing number 1, turned off the loading graphic, price doesn't update at all, logged in or not. I also tried having the loading graphic turned on, while logged in, nothing, no change on the perpetual spinning. I would like the price updater to work whether the client is logged in or not.

I turned off all the modules I could, to see if that would make a difference and no change.

I'm turning off the module for the time being until we can figure out what's the issue.

Thank you for all the effort you've put into it. =)

The issue appears to have initially been whatever is in place (or not) that is requiring a user to be logged in. Not so much that the individual is or is not logged in, but something I found just in navigating the site is that sometimes when trying to change to another page I am redirected to the login screen... Sometimes I am not.. Do you have some sort of additional session handling/handler? BTW, since the software is completely turned off, there is no way that I can identify anything further because this is something affecting your site specifically and for some reason... I can't recreate it on anything that I operate. If it could remain enabled but without the replacement image then at least it could be further investigated/tested and at least one can see the base price (rather than the price being hidden by a spinning dial).

Otherwise, if you wish to figure it out on your own, I suggest you become familiar with the debugger of the browser of your choice. There are some javascript related issues that were identified with your particular page (outside of this plugin) and as far as "finding" a newer jquery, your particular ZC store already has 1.12.0 and therefore there is no other jquery that needs to be loaded (assuming that the other software needing jquery can operate in that environment.)

[mc12345678]

On second thought, what "change" are you expecting to see? The example product that I have seen technically contain only one attribute. Therefore, the price displayed is the only price to be displayed... Just after I posted the above, I went to the site and the plugin was still enabled... I didn't see any errors returned and the price was identified as starting at: XX.XX... Therefore from my perspective the plugin was working just fine. Now if there was a product that had two or more attributes where at least two of the attributes had a different price, then maybe we could be talking about the updates not occurring. Of course now that the plugin has actually been disabled I can't do anything further other than report what was observed while it was present.

[mvstudio]

Right. We were focusing on the perpetual spinning wheel and were not able to actually see the price change not taking effect as it was masked completely by the image. It wasn't until turning off the image loading last night that I realized the price wasn't updating at all and I assumed both events - the perpetual spinning and the price not updating - were related. In this product http://www.byvalenti.com/bvostoretem...&products_id=2 with 2 attributes and two different price points the price doesn't update at all. I've turned the mod back on and removed the image loader for you to see the behavior. No error logs are generated.
Thank you!

[mc12345678]

Right. We were focusing on the perpetual spinning wheel and were not able to actually see the price change not taking effect as it was masked completely by the image. It wasn't until turning off the image loading last night that I realized the price wasn't updating at all and I assumed both events - the perpetual spinning and the price not updating - were related. In this product http://www.byvalenti.com/bvostoretem...&products_id=2 with 2 attributes and two different price points the price doesn't update at all. I've turned the mod back on and removed the image loader for you to see the behavior. No error logs are generated.
Thank you!

No thank you for continuing to test. I've sent a PM with some proposed code changes to try to address this. If it works, then I have a good starting point on which to further improvement to get over what looks like a proxy server related issue. If it seems to resolve the issue (or doesn't) I have another idea, but ultimately I can see a need for some code changes to make addressing things like this a little easier/cleaner. I am aware of one solution reported to work, but I'm concerned of the ramifications.

Also, regarding the spinning image and disabling "replace" there is a code change/modification that would allow the image to appear, but not obscure the price(s). An admin switch has not yet been added to do this, but I think it would help.

The subject code change to allow it to appear but not replace the text is to modify includes/modules/pages/product_info/jscript_dynamic_price_updater.php line 49 from:

var imgLoc = "replace"; // Options are "replace" or , "" (empty)

to:

var imgLoc = ""; // Options are "replace" or , "" (empty)

by deleting just the word replace... This will revert DPU back to an "earlier" condition where the image would appear for posterity. :)

Then reenable loading the image from the configuration menu.

[izar74]

Hi all,

just trying a small modification. Actually the plugin is working great, i would like to modify it so that if an article is out of stock (quantity = 0) an image is displayed instead of the price. In the old version of my site i have modified the file \includes\templates\YOUR_TEMPLATES\templates\tpl_product_info_display.php adding around lines 83 (after the // base price start) the following:

//BOF No price if out of stock, show image instead
  //echo $one_time . ((zen_has_product_attributes_values((int)$_GET['products_id']) and $flag_show_product_info_starting_at == 1) ? TEXT_BASE_PRICE : '') . zen_get_products_display_price((int)$_GET['products_id']);
  if ($products_quantity > 0) {
  echo $one_time . ((zen_has_product_attributes_values((int)$_GET['products_id']) and $flag_show_product_info_starting_at == 1) ? TEXT_BASE_PRICE : '') . zen_get_products_display_price((int)$_GET['products_id']);
} else {
  echo "<img src=images/esaurito.gif>";
   }
//EOF No price if Out of stock, show images instead 

I've done the same with the new version of my site (which have installed last version of DPU) but after displying the OUT OF STOCK image for a few second, DPU replace it with the price...
Before messing with DPU code I prefere to ask if someone have a good hint on how to have it work.

Thanks

Zencart 1.55e
DPU last version

[mc12345678]

Hi all,

just trying a small modification. Actually the plugin is working great, i would like to modify it so that if an article is out of stock (quantity = 0) an image is displayed instead of the price. In the old version of my site i have modified the file \includes\templates\YOUR_TEMPLATES\templates\tpl_product_info_display.php adding around lines 83 (after the // base price start) the following:

//BOF No price if out of stock, show image instead
  //echo $one_time . ((zen_has_product_attributes_values((int)$_GET['products_id']) and $flag_show_product_info_starting_at == 1) ? TEXT_BASE_PRICE : '') . zen_get_products_display_price((int)$_GET['products_id']);
  if ($products_quantity > 0) {
  echo $one_time . ((zen_has_product_attributes_values((int)$_GET['products_id']) and $flag_show_product_info_starting_at == 1) ? TEXT_BASE_PRICE : '') . zen_get_products_display_price((int)$_GET['products_id']);
} else {
  echo "<img src=images/esaurito.gif>";
   }
//EOF No price if Out of stock, show images instead 

I've done the same with the new version of my site (which have installed last version of DPU) but after displying the OUT OF STOCK image for a few second, DPU replace it with the price...
Before messing with DPU code I prefere to ask if someone have a good hint on how to have it work.

Thanks

Zencart 1.55e
DPU last version

So, one of the future features desired for this is to allow it to consider the status of stock of an attribute or attribute combination. Considering that this is being used to support attribute selection, I would think that while you may not have such implemented, that you might have interest in such future capability. With that in mind, there are a few places I could see some code modification to support the possibility of attribute stock determination without requiring significant rework in the future, or a way to just have DPU not load/activate if the products_quantity within the products table is 0 or less (this part assuming that it is not desirable/possible for the store to "oversell" product).

Most of the modification I would see in the includes/classes/dynamic_price_updater.php file, possibly in the insertProduct function where some data would be collected based on the current selection(s), to test the quantity of product available in the store, and then in prepareOutput to consider that data collected and basically assign the "price" to your html for your image (suggest to build the image using the ZC built in functions rather than "hard coding", but whatever seems to work I guess). This way, when the "price" is replaced, it will update the image with whatever your "sold-out" image is.

If you just want to cut DPU off at the pass, then in the top of includes/modules/pages/product_info/jscript_dynamic_price_updater.php (or includes/modules/pages/YOUR_PRODUCT_TYPE/jscript_dynamic_price_updater.php) add an additional test for no quantity of the product and whatever further "allowance" to disable DPU on this product page and therefore, the image added to your template file will not be displayed.

Then, there is the thought that perhaps the price should be displayable AND an image to be provided... That can be accomplished in either of the above two ways or by modifying the insertion point of the image in the template file to be outside the class identifiers for where the price is to be displayed. But, it would seem that if that were the case or desired, then the original change would not have been made. Unfortunately such a modification (not displaying price) also leaves "everyone" in the dark about whether the site is competitive for recently out-of-stock items or as unmonitored/out-of-date for product that remain visible for an extended period of time.

[izar74]

Hi Mc,

as always You are full of ideas and hints!
First thing first, the last one you wrote is something I was considering just know. Why show just the image and not the price? Logically the image showing the OUT OF STOCK status is good, but removing the price could, as You stated, make some customer considering looking elsewhere cause the price is not competitive.
Dunno if this is the better way, commercially speaking, but now that You have highlighted it I could not stop thinking that i have to try it. More, doing so I will avoid a huge coding (It just show an image when the quantity is 0 or below).

Just for coding purpose I've tried to modify the includes/modules/pages/product_info/jscript_dynamic_price_updater.php adding test for quantity, still testing.