Set number of products displayed per page (support thread)

[rbarbour]

I will revert includes/modules/YOUR_TEMPLATE_FOLDER/product_listing.php (based on the ~ Column Layout Grid for Product Listing copy) to see if the problem goes away.

But you missed what I said about includes/templates/YOUR_TEMPLATE_FOLDER/templates/tpl_modules_product_listing.php~. This is broken.

You are correct sir,

includes/templates/YOUR_TEMPLATE_FOLDER/templates/tpl_modules_product_listing.php~ is broken.

Copy/Paste Error from demo site

find both instances of:

<!-- (BOF - 1.3) Set number of products displayed per page (24) -->
<?php } ?>
<!-- (EOF - 1.3) Set number of products displayed per page (24) --><br class="clearBoth" />

and change to:

<!-- (EOF - 1.3) Set number of products displayed per page (24) -->
<?php }
  }
 ?>
<!-- (EOF - 1.3) Set number of products displayed per page (24) --><br class="clearBoth" />

I will update the example file.

Thanks for pointing this out Scott

[swguy]

And sure enough, that fixed my display issue. So that was the root cause of the problem.

Thanks for the quick diagnosis! I will edit out my suggested fix which was wrong.

[rbarbour]

And sure enough, that fixed my display issue. So that was the root cause of the problem.

Thanks for the quick diagnosis! I will edit out my suggested fix which was wrong.

I suspect the intention was to add a closing brace on line 50 and on line 85.

Only wrong depending on the text editor and line count, I think you had it figured out way before I did.

[swguy]

Another thing I noticed was that when the "Items per page" selection was made into a dropdown, it seemed to clobber the next/previous links. I think this might be reproduceable on your test site if you set PRODUCT_LISTING_DISPLAY_OPTION to true and look at this page:

http://zcadditions.com/24/index.php?...&keyword=price

[swguy]

Also, the last call to draw_max_ppp in tpl_modules_product_listing.php is not wrapped in a select call as previous ones are. Suspect this is a bug.

[rbarbour]

Another thing I noticed was that when the "Items per page" selection was made into a dropdown, it seemed to clobber the next/previous links. I think this might be reproduceable on your test site if you set PRODUCT_LISTING_DISPLAY_OPTION to true and look at this page:

http://zcadditions.com/24/index.php?...&keyword=price

Not sure what you mean by clobber - may have to do with below reply

Also, the last call to draw_max_ppp in tpl_modules_product_listing.php is not wrapped in a select call as previous ones are. Suspect this is a bug.

I made an additional copy/paste error, my demo has altered code for the purpose of showing both links and drop-down and on the second section for the bottom I did not change the DEMO to actual ADMIN CONFIG

find:
<?php if (PRODUCT_LISTING_DISPLAY_OPTION_DEMO == 'true') { ?>

change to:
<?php if (PRODUCT_LISTING_DISPLAY_OPTION == 'true') { ?>

[rbarbour]

Also, the last call to draw_max_ppp in tpl_modules_product_listing.php is not wrapped in a select call as previous ones are. Suspect this is a bug.

Also

1st call to draw_max_ppp is for top drop-down
2nd call to draw_max_ppp is for top links
3rd call to draw_max_ppp is for bottom drop-down
4th/last call to draw_max_ppp is for bottom links

2nd and 4th/last should not be wrapped in a select call for they are links.

[swguy]

When I said "clobber" I meant "the next/prev links do not appear."