Cross Sell Module Mods

[mydssbin]

after installing xsell here is what the layout looks like and if someone can tell me how to fix it.



http://www.megafta.com/index.php?mai...&products_id=4

[kuroi]

after installing xsell here is what the layout looks like and if someone can tell me how to fix it.

http://www.megafta.com/index.php?mai...&products_id=4

Can't see (and wouldn't expect) any evidence of cross sell on the page to which you have linked. Could you re-link and/or explain what the problem is.

[kuroi]

Ah. I think there was a problem with your link and you really meant this page.

[kuroi]

I'm not currently seeing a way that the Cross Sell mod could have this effect. However, I am seeing lots of dodgy code hidden in your product descriptions that is causing validation errors and corrupting the structure of your pages.

[YairOz]

Hey Guys

First of all thank u for this great module.

I'm having a few problems with this module:

1. After installing this update (to add addto cart bottuns) the layout of the products is kinda messed up now... instead of showing the products in a row it show them one under the other....

2. weird thing, after adding to cart one of the products from the module, and then adding the main product, it adding the "may we recommend" product again... no matter how many times I try to add the main product to cart, it always add the product from the module...

Please have a look at it at:

4playrusDOTcom/ and look at product number 3 (Adult Content....)

(can't write the full link - zencart blocks my keyword...)

Thank You

[kuroi]

1. After installing this update (to add addto cart bottuns) the layout of the products is kinda messed up now... instead of showing the products in a row it show them one under the other....

It's not clear whether the update to which you refer is a mod that you have added or a bit of custom code. However, the end result is a version of cross sell that doesn't have the normal classes that tie into the stylesheet for layout, or the embedded HTML that sets the width of cross sell product. The latter is particularly important for allowing the products to line up horizontally.

2. weird thing, after adding to cart one of the products from the module, and then adding the main product, it adding the "may we recommend" product again... no matter how many times I try to add the main product to cart, it always add the product from the module...

Not so weird. In amongst the other changes the closing </form> tag has been lost. for the first add to cart button. As a result the form extends to the end of the second add to cart button which is the first cross sold product. So now every time you click the first button, it's the product for the second that will be added to the cart.

[YairOz]

It's not clear whether the update to which you refer is a mod that you have added or a bit of custom code. However, the end result is a version of cross sell that doesn't have the normal classes that tie into the stylesheet for layout, or the embedded HTML that sets the width of cross sell product. The latter is particularly important for allowing the products to line up horizontally.

Not so weird. In amongst the other changes the closing </form> tag has been lost. for the first add to cart button. As a result the form extends to the end of the second add to cart button which is the first cross sold product. So now every time you click the first button, it's the product for the second that will be added to the cart.

Thank u kuroy for the quick answer

For the first answer - the changes I done is from the code paulm gave here at the first page of the code... I guess he changed the layout? I gonna look at those files see if I can see something...

as for the second answer - is there any way to fix it? can u tell me how or where to look?

thanks again!

[kuroi]

Ah. That would be the code that he warns

will mess up your current cross sell layout

Yes, I can see elements in your code such as his customer class for the div around the cross sell product data, but you would need to create your own CSS to go with this, both to style the content and to create its structure (since his code ignores the Zen Cart variables created to do this).

The missing closing form tag is, I now see, not missing. It's in its usual place at the bottom of the product_information panel. However, you can't nest your additional add to cart buttons inside it, as they too are forms. So you need to move them down, or more likely close your original form immediately after the original add to cart button.

[YairOz]

Ah. That would be the code that he warnsYes, I can see elements in your code such as his customer class for the div around the cross sell product data, but you would need to create your own CSS to go with this, both to style the content and to create its structure (since his code ignores the Zen Cart variables created to do this).

The missing closing form tag is, I now see, not missing. It's in its usual place at the bottom of the product_information panel. However, you can't nest your additional add to cart buttons inside it, as they too are forms. So you need to move them down, or more likely close your original form immediately after the original add to cart button.

Thank u very much

as you said I placed the </form> a little bit upper, right after (and like that:):

 
 
$myBuyNow = '';
$myBuyNow .= '</form>';

and it fixed the add to cart problem thanks!

as for the layout... would I need to change the code again? or just write the css file? and do I need to tell zencart to use this css file? or I just put it the css directory of my template?

thank u very much for helping me!

[paulm]

you would need to create your own CSS to go with this, both to style the content and to create its structure (since his code ignores the Zen Cart variables created to do this).

That's correct. I did not include any styling, but just dropped in some "random" classes. Maybe some default Zen classes would fit nicely?


And I forgot about the fact that I included the xsell box below the closing form tag, while most will probably include it just above or below also purchased (which is before the form closure).

I think at first I wanted the form to redirect to the xsell product when a customer would add it to the cart (and achieved that by giving each xsell product it's own form + action). But later I realized that some customers might be distracted to much by this redirect to the xsell product and possibly would never return to the original product to buy it.....
(of course this behaviour depends on your "Display Cart After Adding Product" setting too)

Anyway, the way it is setup now it's easy to change the form action as desired.