SplitTaxLines mod support thread

[numinix]

The error only occurs if MORE than 1 item is added to the cart. I know my latest version of CTE is good so I will release it publicly. Hopefully alan can fix this major bug in STL.

[numinix]

There error in the code is coming from includes/classes/order.php:

      if (isset($this->info['tax_groups'][$products_tax_description[$tax_entry_description]])) {
        $this->info['tax_groups'][$tax_entry_description] += $tax_add;
      } else {
        $this->info['tax_groups'][$tax_entry_description] = $tax_add;
      } 

Specifically...

      if (isset($this->info['tax_groups'][$products_tax_description[$tax_entry_description]])) { 

...is always returning false and therefore the tax_groups value is always going to be the tax_add of the last product. Adding += to both lines makes it work, but it would be better to have the line above returning true.

[numinix]

Change that line to:

if (isset($this->info['tax_groups'][$tax_entry_description])) { 

And the issue appears to be solved for the order_total, but I will have to look at the shipping next...

[numinix]

The shipping looks fine. Just change line 578 to the line I've put above and all issues will be solved. The newest version of CTE is available at http://www.numinix.com and has also been uploaded to the Zen Cart downloads section and should be active soon.

I'll leave it up to alan to OFFICIALLY update his module with the fix.

[alanhigg]

Wow numinix, you've been busy this weekend!

I'll have a look at your proposed bugfix today and release an updated STL asap.

I'm happy someone stepped up and supported you in making the necessary changes to CTE so that it plays nicely with STL. Thanks (to them, and to you) for extending that effort to STL in the form of this bugfix.

Alan

[numinix]

NP Alan. I hope that Zen Cart incorporates the split tax lines module into the Zen Cart core as apparently Canadian retailers must legally display GST and PST on seperate lines. Hopefully DrByte, a fellow Canadian, can understand this legal obligation.

[alanhigg]

Hi All,
As promised, an updated SplitTaxLines package has been uploaded to the Zen-Cart downloads area and should be available soon. EVERYONE who is using STL on zen-cart 1.3.8 should either:

- download and install the new package ( STL v1.11 for zc 1.3.8)

or

- make the single change as suggested by numinix above. (well spotted, numinix!)
change:

 if (isset($this->info['tax_groups'][$products_tax_description[$tax_entry_description]])) {

to:

 if (isset($this->info['tax_groups'][$tax_entry_description])) {

Folks using zc1.3.7.1 can ignore this message. Just a reminder, STLv1.01 is the most recent version for 1.3.7.1-based carts.

Enjoy!
Alan

[MsHutch]

Does anyone using this mod have PayPal Express Checkout enabled on their account? My customers are unable to complete the checkout process with the SplitTaxLines set to true.

Colleen

[alanhigg]

Does anyone using this mod have PayPal Express Checkout enabled on their account? My customers are unable to complete the checkout process with the SplitTaxLines set to true.

Colleen

Hi Colleen,
I have never tried STL with PayPalExpress so I'm afraid I don't have any quick help for you. Can you tell me a little more about the issue? At what point does the checkout process fail, and what is the failure? Is STL working well for your other customers (ie. customers not using PPE)? Hopefully we can narrow it down and find a solution.

Alan

[MsHutch]

Hi Alan,

The actual error I get is

PHP Fatal error:  Unsupported operand types in /home/hutch5/public_html/bayviewlaserengraving/includes/functions/functions_taxes.php on line 176

This occurs at the final stage of checkout. Everything works great when other payment methods are used, like check/money order.

Thank you again for your time,

Colleen