SplitTaxLines mod support thread

[numinix]

Hi guys,

Someone supported me to update the CTE module with STL, which I have done without a problem.

But, I am having a problem with STL with the classic template and version 1.3.8a:

GST (5%) - for all goods in Canada
PST (7%) - for all goods in BC
GST (5%) - for all services in Canada

When I install STL it displays the tax for each product as Array% and the GST is only calculated on the second item plus shipping and the PST is calculated on only the second item.

Qty. Item Name Tax Total
1 x test prod 1 cat 2 Array% $55.00
2 xt est prod 1 Array% $20.00

Sub-Total: $75.00

Flat Rate (Best Way): $5.00

GST (5%): $1.25 (should be $4.00)

PST (7%): $1.40 (should be $5.25)

Total: $89.25 (total is correct)

Everything is 100% perfect when STL is set to false.

When I activate CTE with STL the totals are always correct. I have tested STL without CTE to get the above errors.

[numinix]

CTE with zen_get_multiple_tax_rates() support is completed and is ready to release. But it seems pointless to do so with the STL errors...

[numinix]

Ok, solved the array% problem which was due to missing some lines for merging on tpl_checkout_confirmation_default.php. I'm now using the file included with the package and receiving the incorrect amounts on each tax line. All the taxes skip the first item in their calculations and only display on the last item of each tax class.

[numinix]

The error only occurs if MORE than 1 item is added to the cart. I know my latest version of CTE is good so I will release it publicly. Hopefully alan can fix this major bug in STL.

[numinix]

There error in the code is coming from includes/classes/order.php:

      if (isset($this->info['tax_groups'][$products_tax_description[$tax_entry_description]])) {
        $this->info['tax_groups'][$tax_entry_description] += $tax_add;
      } else {
        $this->info['tax_groups'][$tax_entry_description] = $tax_add;
      } 

Specifically...

      if (isset($this->info['tax_groups'][$products_tax_description[$tax_entry_description]])) { 

...is always returning false and therefore the tax_groups value is always going to be the tax_add of the last product. Adding += to both lines makes it work, but it would be better to have the line above returning true.

[numinix]

Change that line to:

if (isset($this->info['tax_groups'][$tax_entry_description])) { 

And the issue appears to be solved for the order_total, but I will have to look at the shipping next...

[numinix]

The shipping looks fine. Just change line 578 to the line I've put above and all issues will be solved. The newest version of CTE is available at http://www.numinix.com and has also been uploaded to the Zen Cart downloads section and should be active soon.

I'll leave it up to alan to OFFICIALLY update his module with the fix.