[Not a bug] Language overwrite bug?

[yellow1912]

I dont know if this is a bug, or probably just me doing something stupid.

I have
includes/languages/english/advanced_search_result.php
includes/languages/english/mytemplate/advanced_search_result.php

I expected on the file in mytemplate to be loaded, but it seems like both of they are loaded? Am I doing something wrong here?

[DrByte]

No, it is not a bug.
The custom language file is loaded first.
Then the master language file is loaded afterward ... just in case an out-of-date language file is used in override.

Most upgraders tend to not be thorough, and miss merging things in their language files.
Thus, at the present time, the default master file is also loaded to "catch" any defines that haven't been set properly in the override language file.
This only happens on "page-based" language files, not module-based files.

And, yes, doing things this way causes PHP warnings about "constant already defined". It's a cost of protecting upgraders from their own mistakes.

For now, that's how it's done.
It may change in the future.

[Absolute]

Would it be possible to create a new zen_define() function, with a global option to check if the constant has already been defined?

The reason for having this as an global option, rather than a permanent feature is that it would obviously add a small amount of time to each page load, and where users are running sites where fast page loads are essential, or slow shared hosts, the page load times are always a concern.

Thank you,

Absolute