Simple SEO URL (OLD version) [support thread]

[FMB]

Give me till this weekend, I have a new version coming out soon which will fix all known bugs.

Even the one with Paypal IPN ? I've been struggling quite a lot with it but I have not really understood what actually happens yet. If it can help, here are the logs generated by the module:

Jun 01 2008 15:22 -- Keys for submission: Array
(
    [charset] => iso-8859-1
    [lc] => FR
    [page_style] => Primary
    [custom] => zenid=dbd9e25d5b5790c22a0a714a5a6142ea
    [business] => [email protected]
    [return] => https://my_https_host/checkout_process/referer/paypal?zenid=dbd9e25d5b5790c22a0a714a5a6142ea
    [cancel_return] => https://my_https_host/checkout_payment?zenid=dbd9e25d5b5790c22a0a714a5a6142ea
    [shopping_url] => https://my_https_host/shopping_cart?zenid=dbd9e25d5b5790c22a0a714a5a6142ea
    [notify_url] => https://my_https_host/ipn_main_handler.php
    [redirect_cmd] => _xclick
    [rm] => 2
    [bn] => zencart
    [mrb] => XXXXXXXXXXXXXXX
    [pal] => XXXXXXXXXXXXXXXX
    [first_name] => XXXX
    [last_name] => XXXXXXX
    [address1] => XXXXXXX
    [city] => XXXXXXXXX
    [state] => XXXX
    [zip] => XXXX
    [country] => X
    [email] => [email protected]
    [H_PhoneNumber] => XXXXXX
    [night_phone_b] => XXXXXXX
    [day_phone_b] => XXXX
    [no_shipping] => 1
    [upload] => 1
    [currency_code] => EUR
    [cmd] => _ext-enter
    [item_name] => XXXXXXXXX
    [item_number] => MODULE_PAYMENT_PAYPAL_PURCHASE_DESCRIPTION_ITEMNUM
    [amount] => 7.20
    [shipping] => 0.00
    [tax] => 0.00
    [tax_cart] => 0.00
)

Jun 01 2008 15:27 -- IPN PROCESSING INITIATED. 
*** Originating IP: 66.211.170.66  notify.paypal.com

Jun 01 2008 15:27 -- PDT Returned Data Array
(
)


Jun 01 2008 15:27 -- PDT WARNING :: Order not marked as "Completed".  Check for Pending reasons or wait for IPN to complete.
[payment_status] => 
[pending_reason] => 

Jun 01 2008 15:27 -- PDT WARNING :: Transaction already exists. Perhaps IPN already added it.  PDT processing ended.

Jun 01 2008 15:27 -- IPN INFO - POST VARS to be sent back for validation: 
To: www.paypal.com:80
POST /cgi-bin/webscr HTTP/1.1
Host: www.paypal.com
Content-type: application/x-www-form-urlencoded
Content-length: 143
Connection: close

Array
(
    [cmd] => _notify-sync
    [tx] => 
    [at] => XXXXXXXXXXXXXXXXXXX
)


Jun 01 2008 15:27 -- IPN INFO - Confirmation/Validation response 

FAIL


Jun 01 2008 15:27 -- IPN WARNING :: PDT Transaction was not marked as SUCCESS. Keep this report for potential use in fraud investigations.
IPN Info = 
FAIL

Jun 01 2008 15:30 -- IPN PROCESSING INITIATED. 
*** Originating IP: 66.211.170.66  notify.paypal.com

I don't understand how SSU could interfere with Paypal, but it does. However according to the logs it seems that there IS bidirectional communication.
Unfortunately I can't use SSU until this problem can be solved...
Please show up if you need some help to code or to do some tests for your new version.

[FMB]

Oh, and maybe I should mention that the payment is accepted by Paypal, but Zen Cart does not receive any notification of it, so it does not appear in the admin homepage.

[hitch]

Hi all,

Just wondering if anyones has had this problem and conquered it?

i have installed this mod and it seems to be working great but there are a few links that don't work. An example is on the product info page. The tell a friend link displays as:
http://my_domain/tell_a_friend/%s.
All the problem ones all have the %s/%p things happening and display a bad request. 95% of links are all working fine though.

I only have it locally at the mo so i cant post an example but i have checked out a few other carts who have the mod live and find the same problem.

thanks for any hints.

[FMB]

You can decide to manually add each of these pages to the exclude list (admin -> configuration -> Simple SEO URL -> exclude list). Personally I decided to modify the function ssu_params in includes/init_includes/init_ssu.php this way:

	// this function takes the parameters in the query string and turns that to our nice looking link
	function ssu_params(&$page, $parameters, $re_calculate_cpath= false){
		$parameters = trim($parameters,' ?&');
		$cachefile = $this->pc_cache_folder.md5($page.$parameters);
		$params = '';
		$use_cache = false;
		$set_cache = false;
		$contains_cpath = (strpos($parameters,'cPath=') !== false);
		$contains_products_id = (strpos($parameters,'products_id=') !== false);
		$is_product_info_page = in_array($page, $this->products_handlers);
		$is_category_page = ($page == 'index' && $contains_cpath);
		$both_id = (!$is_product_info_page && !$is_category_page && $contains_cpath && $contains_products_id);
		$only_products_id = (!$contains_cpath && $contains_products_id);

		if(!empty($parameters)){
			// if this contains cPath or products_id lets attempt to use cache
			if($contains_cpath || $contains_products_id){
				$use_cache = true;
		        if (($params = @file_get_contents($cachefile)) === false)
		        	$set_cache = true;
			}
			
			// process params if we dont use cache or need to reset cache
			if(!$use_cache || $set_cache){
				// No need for '?'
				//$parameters = str_replace('?', '', $parameters);
				$parameters = str_replace(array('&','&','=','?'),'/',$parameters);
		
				// clean up
				//$parameters = preg_replace('/\/\/+/', '/', $parameters);
				$parameters = trim($parameters, '/');
				
				$cPath='';
				$products_id='';
				
				// Appending category name and product name into the link
				$parameters = explode('/',$parameters);
				$param_counter = count($parameters);
				
				// we want to make sure the order of params for product info and category pages 
				if($is_product_info_page || $both_id)
					$params = "%s/%p";
				elseif($is_category_page)
					$params = "%s";
				elseif($only_products_id)
					$params = "%p";
			
				for($i=0; $i < $param_counter; $i++){
					if($parameters[$i]=='cPath'){
						$cPath = $parameters[++$i];
						if(!$is_product_info_page && !$is_category_page && !$both_id)
						$params .= "/%s";
					}
					elseif($parameters[$i]=='products_id'){
						$products_id = $parameters[++$i];
						if(!$is_product_info_page && !$is_category_page && !$only_products_id && !$both_id)
						$params .= "/%s";
					}
					elseif(!empty($parameters[$i]) && !empty($parameters[$i+1])){
						$params .= "/".$parameters[$i]."/".$parameters[++$i];
					}
					else
						$i++;
				}

				// dont trust the info passed to us, always rebuild the cPath in this case
				if($is_product_info_page && !empty($products_id)){
					$cPath = zen_get_product_path($products_id);
				}
				elseif(!empty($cPath) && $re_calculate_cpath && !empty($products_id)){
					$cPath = zen_get_product_path($products_id);
				}
		
				if(!empty($cPath)){
				$params = str_replace('%s', $this->get_category_name($cPath), $params);
				}

				if(!empty($products_id)){
				$params = str_replace('%p', $this->get_product_name($products_id), $params);
				}
			}
		}
		
		if($is_product_info_page || $is_category_page)
			$page ='';
		
		$params = trim($params, '/');
		if($set_cache) $this->_write_to_file($cachefile, trim($params,'/')); // we cache the whole link so that we dont have to recalculate it again

		// TODO: change the way we check if the language is already in the link
		$params .= (isset($_SESSION['languages_code']) && strpos($params, 'language/') === false && $_SESSION['languages_code'] != DEFAULT_LANGUAGE) ? '/language/' . $_SESSION['languages_code'] : '';
				
		return $params;
	}

Thanks to $only_products_id and $both_id, we can process the links referring to pages which are not product or category pages, but whose URL contain category or product identifiers (like tell_a_friend and product_reviews_write).
If you want to use this solution, you can cut and paste the code, overwrite init_ssu.php with the file in attachment, or use the patch with the command "patch -p0 < init_ssu.patch".
Of course this is provided without any warranty and should be tested before using it on your Zen Cart shop (in your case it seems you already use a test shop, though).

I had not proposed yet these modifications as I was not sure everyone met this problem.

To hunt dead or broken links on a website, you can use lynx (lynx -accept_all_cookies -traversal -crawl -realm PATH_TO_YOUR_LOCAL_WEBSITE) or Xenu (wich unfortunately only has a Windows version but it works fine with wine). Of course it is best to use it on your own PC or local network as it consumes A LOT of bandwith.

Hope this helps,

FMB.

[bigbadboy]

Some mods work perfectly, some don't.
Installed as per the entire instructions, checed, checked and checked again but now I still get errors:

/home/PATH/TO/ADMIN/includes/classes/module_installer.php on line 201
Error Error: Nothing to do - no query or query-file specified.
Error Failed to set up version tracker table
Warning /home/PATH/TO/ADMIN/includes/module_installation/yellow1912_ssu/current_version.txt is missing
Error Module version could not be found in file and database

Plus all files are called as domain.com/cSSU_ID_DELIMITER1

The files are installed but it simply won't work.
htaccess checked, everything checked.

it seems some errors are calling for files that don't exist or at least are not included in the package I just downloaded.

[hitch]

You can decide to manually add each of these pages to the exclude list (admin -> configuration -> Simple SEO URL -> exclude list). Personally I decided to modify the function ssu_params in includes/init_includes/init_ssu.php this way:

Thanks to $only_products_id and $both_id, we can process the links referring to pages which are not product or category pages, but whose URL contain category or product identifiers (like tell_a_friend and product_reviews_write).
If you want to use this solution, you can cut and paste the code, overwrite init_ssu.php with the file in attachment, or use the patch with the command "patch -p0 < init_ssu.patch".
Of course this is provided without any warranty and should be tested before using it on your Zen Cart shop (in your case it seems you already use a test shop, though).

I had not proposed yet these modifications as I was not sure everyone met this problem.

To hunt dead or broken links on a website, you can use lynx (lynx -accept_all_cookies -traversal -crawl -realm PATH_TO_YOUR_LOCAL_WEBSITE) or Xenu (wich unfortunately only has a Windows version but it works fine with wine). Of course it is best to use it on your own PC or local network as it consumes A LOT of bandwith.

Hope this helps,

FMB.

For anyone else with the same linking problem as me this worked like a treat. thanks FMB!