Help with Code needed.

[bumba000]

Hello All,

I would like to use something like this in the tpl_product_info.php to dispaly different adds depending on click count. This works as a test page but when added to the product info I get a blank page. Im adding this to the bottom of the product info

$add1= "Read all about it. . . ";
$add2= "Read about something else";

session_start();
$_SESSION['var'] = isset($_SESSION['var']) && $_SESSION['var'] <= 5 ? ($_SESSION['var'] + 1) : 1;

if ($_SESSION['var'] == 1)
{
echo "$add1";
}

if ($_SESSION['var'] == 2)
{
echo "$add2";
}

and on and on . . .

When this didn't work I tried adding to the begining

require($_SERVER["DOCUMENT_ROOT"] . "/2008_TestSite/includes/configure.php");
$connection = mysql_connect(DB_SERVER, DB_SERVER_USERNAME, DB_SERVER_PASSWORD) or die(mysql_error());
mysql_select_db(DB_DATABASE, $connection);

but still I get nothing.

Using version 1.3.8a Why won't this work?


Thank you,
John

[yellow1912]

session_start(); 

// session already started, no need for this

$_SESSION['var'] = isset($_SESSION['var']) && $_SESSION['var'] <= 5 ? ($_SESSION['var'] + 1) : 1; 

Should be

$_SESSION['var'] = (isset($_SESSION['var']) && $_SESSION['var'] <= 5) ? ($_SESSION['var'] + 1) : 1; 

[kobra]

yellow1912,
Good catch!!

bumba000,
Scrap Dreamweaver and use a good code editor that color codes php & errors

[bumba000]

O'kay. Here is my code that doesnt work, as basic as it gets. What's wrong?

<?php

$_SESSION['var'] = (isset($_SESSION['var']) && $_SESSION['var'] <= 5) ? ($_SESSION['var'] + 1) : 1;  
if ($_SESSION['var'] == 1)
{
echo "1";
}

if ($_SESSION['var'] == 2)
{
echo "2";
}

if ($_SESSION['var'] == 3)
{
echo "3";
}

if ($_SESSION['var'] == 4)
{
echo "4";
}

if ($_SESSION['var'] == 5)
{
echo "5";
}

if ($_SESSION['var'] == 6)
{
echo "6";
}


?>

Should I be including the query stuff above it?

Dreamweaver highlights for php. I just don't know php at all. What editor would you recommend?

Thanks,
John

[yellow1912]

1. Use switch or else if statement in this case. If you use 6 if(s), your code will have to check that value 6 times(when it only needs to do so once)

2. Follow the tut here to turn on strict error mode and check the error code:
https://www.zen-cart.com/tutorials/index.php?article=82

3. For simple script like this, I use Notepad++, quick and easy to work with.

[kobra]

yours:

$_SESSION['var'] = (isset($_SESSION['var']) && $_SESSION['var'] <= 5) ? ($_SESSION['var'] + 1) : 1;

yellow1912's

$_SESSION['var'] = isset($_SESSION['var']) && $_SESSION['var'] <= 5 ? ($_SESSION['var'] + 1) : 1;

Red is open blue is close

[yellow1912]

yours:

$_SESSION['var'] = (isset($_SESSION['var']) && $_SESSION['var'] <= 5) ? ($_SESSION['var'] + 1) : 1;

yellow1912's

$_SESSION['var'] = isset($_SESSION['var']) && $_SESSION['var'] <= 5 ? ($_SESSION['var'] + 1) : 1;

Red is open blue is close

Actually, it's the other way around, the second piece of code bumba000 posted used my suggested code.

[yellow1912]

BTW, just to make sure, are you running this within a page in ZC, or are you testing it as a stand alone script?

[bumba000]

Im running this in inc/templates/MyTemp/tempDef/tpl_product_info.php.
It worked as a stand alone with the connect db stuff up top.
Also I don't know what the switch is.

For an you say "if" and then "else if" as many times as needed?

Thanks
John

[yellow1912]

switch:

switch($_SESSION['var']){
case 1:
echo "1";
break;
case 2:
echo "2";
break;
case 3:
echo "3";
break;
case 4:
echo "4";
break;
case 5:
echo "5";
break;
case 6:
echo "6";
break;
} 

ifelse:

if ($_SESSION['var'] == 2)
{
echo "2";
}

elseif ($_SESSION['var'] == 3)
{
echo "3";
}

elseif ($_SESSION['var'] == 4)
{
echo "4";
}

elseif ($_SESSION['var'] == 5)
{
echo "5";
}

elseif ($_SESSION['var'] == 6)
{
echo "6";
} 

The 2 sample codes above is better than yours because:
In your code, even if the var is 2, the code will still execute all the other if statements.