New Jrox JAM integration code for 1.3.8

[schoolboy]

Just had word that Jrox JAM has obtained (via zencart chaps) the new integration code for 1.3.8.

------------------------
// bof JROX integration
if (isset($zv_orders_id) && (int)$zv_orders_id > 0 && isset($order_summary) && is_array($order_summary)) {
  if (!isset($_SESSION['affiliate_order_id']) || $_SESSION['affiliate_order_id'] != $zv_orders_id ) {
      $_SESSION['affiliate_order_id'] = $zv_orders_id;
     $commissionable_order_formatted = number_format($order_summary['commissionable_order'], 2, '.', '');
     echo '<script language="javascript" type="text/javascript" src="http://www.yourdomain.com/affiliates/sale.php?amount=' . $commissionable_order_formatted . '&trans_id=' . $order_summary['order_number'] . '"></script>';
    }
}
// eof JROX integration
------------------------- 

My questions are:-

1. Does this code perform the same calculation(s) as the old footer integration code - particularly with regard to deducting discounts from the sub total. Here is the relevant line in the old code:-

  $commissionable_order = ($order_subtotal - $coupon_amount - $group_pricing_amount); 

2. And is it possible to ALSO subtract Gift Certificate amount, which a few of us think is vital to the correct calculation of affiliate commissions:-

$commissionable_order = ($order_subtotal - $gv_amount - $coupon_amount - $group_pricing_amount); 

If the NEW code can't do (2) above, is it still okay to use the old code?

[yellow1912]

Wouldnt it be better to contact JAM directly? Since this is THEIR code.

[schoolboy]

I've spent most of the morning in the JAM forum asking the same question.


Here's their Forum Admin response:-


this is code given to us directly from the folks over at zencart.

you are welcome to change it, however you see fit.

[DrByte]

My questions are:-

1. Does this code perform the same calculation(s) as the old footer integration code - particularly with regard to deducting discounts from the sub total. Here is the relevant line in the old code:-

  $commissionable_order = ($order_subtotal - $coupon_amount - $group_pricing_amount); 

2. And is it possible to ALSO subtract Gift Certificate amount, which a few of us think is vital to the correct calculation of affiliate commissions:-

$commissionable_order = ($order_subtotal - $gv_amount - $coupon_amount - $group_pricing_amount); 

If the NEW code can't do (2) above, is it still okay to use the old code?

The "new" code is based on making use of the code in the bottom of /includes/modules/YOUR_TEMPLATE/checkout_process.php

Specific to your questions:
1. is built-in, as described
2. Gift Certificate amounts are automatically deducted, since they are handled by a credit-class OT module.
However, if needed, you can customize as desired, using an override of checkout_process.php
3. Yes, if you don't like the new code, you can use the old code; however, you're using more SQL queries and CPU cycles needlessly.

[schoolboy]

Thanks a ton doc... I'll stick with the old code for now. Next month I'll put up a test site to see how the new footer code performs!

[KADesign]

Hi,
I also have a question concerning Jam. I added the following code to the bottom of my tpl_footer. Is this correct? They do state the code is provided by ZenCart. I am using 1.3.8 but now I am noticing an issue during check out since adding the code. At the last stage of checkout, confirm order, I am getting a warming that the page contains secure and unsecure items. Is this possibly due to the code?

##########################################
## START JAM INTEGRATION WITH ZEN CART ##
## ZC Integration code by DrByte 8/2006 ##
##########################################
if ((int)$orders_id > 0) {
$JAM = $db->Execute("select class, value from " . TABLE_ORDERS_TOTAL . " where orders_id = '".(int)$orders_id."' AND class in ('ot_coupon', 'ot_subtotal', 'ot_group_pricing')");
while (!$JAM->EOF) {
switch ($JAM->fields['class']) {
case 'ot_subtotal':
$order_subtotal = $JAM->fields['value'];
break;
case 'ot_coupon':
$coupon_amount = $JAM->fields['value'];
break;
case 'ot_group_pricing':
$group_pricing_amount = $JAM->fields['value'];
break;
}
$JAM->MoveNext();
}
$commissionable_order = ($order_subtotal - $coupon_amount - $group_pricing_amount);
$commissionable_order = number_format($commissionable_order,2,'.','');
echo "<script language=\"JavaScript\" type=\"text/javascript\" src=\"http://www.mydomain.com/affiliates/sale.php?amount=$commissionable_order&trans_id=$orders_id\"></script></td></tr>

</table>";
}
#######################################
## END JAM INTEGRATION WITH ZEN CART ##
#######################################

Thanks,
Kelly

[KADesign]

It was it...
I just changed the src=\"http://www.mydomain.com/affiliates/sale.php?
to src=\"https://www.mydomain.com/affiliates/sale.php?
I seems to have fixed the problem...I hope!

Thanks,
Kelly

[schoolboy]

If changing the "http" to "https" results in no errors, then what you have done should be OK.

[Website Rob]

Another option is to change:

from
src=\"http://www.mydomain.com/affiliates/sale.php?

to
src="/affiliates/sale.php?

That allows your Browser to decide if using an 'https' or 'http' connection.

You only need to use a full URL (includes the Domain name) when the link is to another site. Then you have to decide if 'https' or 'http' is to be used.

[KADesign]

Thanks Rob!! I think that is a much better idea.